From mboxrd@z Thu Jan  1 00:00:00 1970
From: mike.rosset@gmail.com
Subject: Re: qtwenengine anybody?
Date: Tue, 07 Jan 2020 11:14:18 -0800
Message-ID: <875zhnxenp.fsf@gmail.com>
References: <e846d57e-0d46-728c-dd0f-6bffcfabf1d7@crazy-compilers.com>
 <87immgqryj.fsf@gmail.com>
 <d5a8081f-fdb8-7187-9400-4a9d1e9f7c49@crazy-compilers.com>
 <871rt4qnp9.fsf@gmail.com>
 <aab3a7ca-af72-665c-ec21-dcfd0b3ac483@crazy-compilers.com>
 <87immgp582.fsf@gmail.com>
 <5955729d-ef57-ffb8-feb8-36a9f53658a2@crazy-compilers.com>
 <87d0clpbt6.fsf@gmail.com> <87y2v7e0g4.fsf@ambrevar.xyz>
 <87v9qb56gg.fsf@gmail.com> <87sglfotvj.fsf@ambrevar.xyz>
 <87o8w354m5.fsf@gmail.com> <87blrod2so.fsf@ambrevar.xyz>
 <878smsd2pe.fsf@ambrevar.xyz> <87mub7krlq.fsf@gmail.com>
 <87tv5e9acb.fsf@ambrevar.xyz> <87o8vmn6an.fsf@elephly.net>
 <87zhf2c5jy.fsf@gmail.com> <87lfql7k9w.fsf@elephly.net>
 <87d0bw2xtj.fsf@devup.no> <87pnfvg01v.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:51627)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mike.rosset@gmail.com>) id 1iouJ8-0006DW-FB
 for guix-devel@gnu.org; Tue, 07 Jan 2020 14:14:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mike.rosset@gmail.com>) id 1iouJ7-0004bJ-B8
 for guix-devel@gnu.org; Tue, 07 Jan 2020 14:14:26 -0500
In-Reply-To: <87pnfvg01v.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
 "Tue, 07 Jan 2020 09:09:32 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org, GNU Guix maintainers <guix-maintainers@gnu.org>

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Fantastic, Marius!  Some nits below:
>
>>  ;;; Copyright =C2=A9 2019 Marius Bakke <mbakke@fastmail.com>
>
> 2020 for Marius?
>
>> +       ;; FIXME: libxml2 needs to built with icu support though it link=
s to
>> +       ;; libxml2 configure summary still states. Checking for compatib=
le
>> +       ;; system libxml2... no
>
> Punctuation:
>
> ... still states "Checking for compatible system libxml2... no".
>
>
>> +       ;; Tests are disabled due to Could not find QtWebEngineProcess e=
rror
>> +       ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS=
_PATH
>> +       ;; before running tests It's also possible some tests need a net=
work
>
> Punctuation:
>
> Test are disabled due to "Could not find QtWebEngineProcess" error.
> It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH
> before running tests.  It's also possible some tests need a network.

Will fix these ASAP, thanks for pointing theses out.

>> +             (define (third-party? file)
>> +               (if (string-contains file "third_party/")
>> +                   #t
>> +                   #f))
>
> Maybe just
>
> (define (third-party? file)
>   (string-contains file "third_party/"))
>
> ?

I have a patch to fix this will include it with punctuation.