bug#39648: Reverse my commits on GNOME meta-package

bug#39648: Reverse my commits on GNOME meta-package

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hello Guix!

@Danny

Could you please reverse my following commits:

1) d36fa50fbf8169018193774782fd21f1b13b9c0e

2) 7922b6f795eb575084546ec9bfb9d40508a9378e

3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f

4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

I will re-test throughly and re-commit them later. I also apologize for
the mishap.

Thank you!

Regards,
RG.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39648: Reverse my commits on GNOME meta-package

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

Raghav Gururajan 写道：
> Could you please reverse my following commits:
>
> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>
> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>
> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>
> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b

Copy-pasted from #guix:

Whoa there, that's drastic, let's put that on hold.

The first two only add packages (did they break anything? what?), 
the third has no effect on packages if your commit message is 
accurate.

The fourth is the only one that removes packages, and even that 
might be better tweaked (this time: with comments noting what each 
non-core package brings to the GNOME table) than flat-out 
reverted.

What do you think?

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#39648: Reverse my commits on GNOME meta-package

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]


> Copy-pasted from #guix:
> 
> Whoa there, that's drastic, let's put that on hold.
> 
> The first two only add packages (did they break anything? what?), 
> the third has no effect on packages if your commit message is 
> accurate.
> 
> The fourth is the only one that removes packages, and even that 
> might be better tweaked (this time: with comments noting what each 
> non-core package brings to the GNOME table) than flat-out 
> reverted.
> 
> What do you think?

I made a mistake of not reading comments of previous commits that were
done to gnome meta-package. Since we got lot of feedbacks regarding
gnome experience, I will re-conyemplate my plans for gnome, make the
changes, test it throughly and then re-commit later.

Also, this reverse should be smooth and does not break anything. It
just takes the GNOME meta-package back to the time before I started
making my commits to it.

Regards,
RG.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39648: Reverse my commits on GNOME meta-package

[Gábor Boskovits]

Hello Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
ezt írta (időpont: 2020. febr. 17., H, 20:03):
>
> Raghav Gururajan 写道：
> > Could you please reverse my following commits:
> >
> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
> >
> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
> >
> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
> >
> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.

I agree.

>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>

I believe the fourth can be reverted if needed.

> What do you think?
>
> Kind regards,
>
> T G-R


Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

bug#39648: Reverse my commits on GNOME meta-package

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

> I believe the fourth can be reverted if needed.

Some packages that were removed, I made a mistake of not reading the
comments of why it were added in the first place. Some of them were
non-core and some were core but depracated. It gonna take some time for
me to read and understand their exact role and effect on GNOME
experience. Since I am planning+working on new changes anyway, I will
study and test them throughly all together to see how the experience is
and then commit them. :-)

Regards,
RG.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39646: bug#39648: Reverse my commits on GNOME meta-package

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

Hi Tobias & all!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Raghav Gururajan 写道：
>> Could you please reverse my following commits:
>>
>> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
>>
>> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
>>
>> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
>>
>> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.
>
> The first two only add packages (did they break anything? what?), the
> third has no effect on packages if your commit message is accurate.
>
> The fourth is the only one that removes packages, and even that might
> be better tweaked (this time: with comments noting what each non-core
> package brings to the GNOME table) than flat-out reverted.
>
> What do you think?

I agree.  As a stop-gap measure, I propose to commit the following
change real soon.  I’ve tested it in a VM; it addresses the points Andy
raised by re-adding the important bits mentioned in
<https://issues.guix.gnu.org/issue/39648>.

Raghav, don’t worry, we all make mistakes!  We can refine this calmly
later on.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1659 bytes --]

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3c63ab283d..c64b182869 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7906,7 +7906,29 @@ world.")
        ("yelp" ,yelp)
      ;; Others
        ("hicolor-icon-theme" ,hicolor-icon-theme)
-       ("gnome-online-accounts" ,gnome-online-accounts)))
+       ("gnome-online-accounts" ,gnome-online-accounts)
+
+       ;; Packages not part of GNOME proper but that are needed for a good
+       ;; experience.  See <https://bugs.gnu.org/39646>.
+       ;; XXX: Find out exactly which ones are needed and why.
+       ("font-cantarell"            ,font-cantarell)
+       ("font-dejavu"               ,font-dejavu)
+       ("at-spi2-core"              ,at-spi2-core)
+       ("dbus"                      ,dbus)
+       ("dconf"                     ,dconf)
+       ("desktop-file-utils"        ,desktop-file-utils)
+       ("gnome-default-applications" ,gnome-default-applications)
+       ("gnome-themes-standard"     ,gnome-themes-standard)
+       ("gst-plugins-base"          ,gst-plugins-base)
+       ("gst-plugins-good"          ,gst-plugins-good)
+       ("gucharmap"                 ,gucharmap)
+       ("pinentry-gnome3"           ,pinentry-gnome3)
+       ("pulseaudio"                ,pulseaudio)
+       ("shared-mime-info"          ,shared-mime-info)
+       ("system-config-printer"     ,system-config-printer)
+       ("xdg-user-dirs"             ,xdg-user-dirs)
+       ("yelp"                      ,yelp)
+       ("zenity"                    ,zenity)))
     (synopsis "The GNU desktop environment")
     (home-page "https://www.gnome.org/")
     (description

bug#39646: bug#39648: Reverse my commits on GNOME meta-package

[Raghav Gururajan]

Hi Ludo!

> I agree. As a stop-gap measure, I propose to commit the following
> change real soon. I’ve tested it in a VM; it addresses the points Andy
> raised by re-adding the important bits mentioned in
> <https://issues.guix.gnu.org/issue/39648>.

Sure, I can do that.

> Raghav, don’t worry, we all make mistakes! We can refine this calmly
> later on.

Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

Regards,
RG.

bug#39646: bug#39648: Reverse my commits on GNOME meta-package

[Ludovic Courtès]

Hi,

"Raghav Gururajan" <raghavgururajan@disroot.org> skribis:

>> I agree. As a stop-gap measure, I propose to commit the following
>> change real soon. I’ve tested it in a VM; it addresses the points Andy
>> raised by re-adding the important bits mentioned in
>> <https://issues.guix.gnu.org/issue/39648>.
>
> Sure, I can do that.
>
>> Raghav, don’t worry, we all make mistakes! We can refine this calmly
>> later on.
>
> Thank you. All good. I just thought reversing would be better for time being, but that's okay. :-)

OK, pushed as 9f2fef4fb164df81034c2b114292d836a9f6d4f8.

Thanks,
Ludo’.