From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jB7eP-0002x3-6D for guix-patches@gnu.org; Sun, 08 Mar 2020 21:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jB7eO-000712-49 for guix-patches@gnu.org; Sun, 08 Mar 2020 21:56:13 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jB7eN-00070l-WD for guix-patches@gnu.org; Sun, 08 Mar 2020 21:56:12 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jB5xh-0001W4-Ok for guix-patches@gnu.org; Sun, 08 Mar 2020 20:08:01 -0400 Subject: [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches. Resent-Message-ID: References: <87imjmeagu.fsf@cbaines.net> <20200302210735.13337-1-mail@cbaines.net> <875zffg97p.fsf@gnu.org> From: Christopher Baines In-reply-to: <875zffg97p.fsf@gnu.org> Date: Mon, 09 Mar 2020 00:07:46 +0000 Message-ID: <875zfee6gd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39873@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Christopher! > > Christopher Baines skribis: > >> In http-multiple-get. > > Leftover? :-) No, just clarifying what function is being referred to. Although the line below reveals that also. >> * guix/scripts/substitute.scm (http-multiple-get): Switch port to p in o= ne >> occurrence. >> --- >> guix/scripts/substitute.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm >> index dfb975a24a..5ed43d36c9 100755 >> --- a/guix/scripts/substitute.scm >> +++ b/guix/scripts/substitute.scm >> @@ -545,7 +545,7 @@ initial connection on which HTTP requests are sent." >> (() >> (reverse result)) >> (remainder >> - (connect port remainder result)))) >> + (connect p remainder result)))) > > LGTM! > > Did you notice an occurrence of this bug somewhere? I was looking for something that could be going wrong here as I was seeing some kind of error talking to Cuirass using this in the Guix Data Service, and happened to notice this in the code. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl5liNJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeJvg/+Pb3lzcFhNPDt83Fs6nDeLv9DGRCD9eRHyk6AHj0c1MtXwY43ezcF4ZJm gAQAxgfTYVJMJMes7rXmXtzxPZroneHjGymFFCpR8iqM2umC1cwR8LLvHufSU6tq /ACB9oM5TK7WCrQodffua8mOq0Y4uLWk8g0bJycQo+w53Grsp2FSPjLyDcGtyxLW bm0iM5cz82QeFH/1N/Vmrr2YSRMN1K45Jd9UE311qEEMp9pkNQI3TF58XBuCpCyw 5vaztgtZDLg1zEdIVFokJjkFrmd/Tm7BEqhXO9U6wulL+Q0j+eo4bOGFMMoG/Y80 8utWzb+9sQqIpiHX242fo5+p1iwofuJbb5/Ef9CVwD37sK2QoeiAezz34U2s8XJF lVhd4JRxY6vDP106HNWN9htPQFR1VtGmu2tF7TlJi3O3vBVNq1+B4+CCbfhXhJm5 GHCvJHyRVLV1sLdFDQgc6SKwfAUtMVchKrNs2j7IrreDPDOX9DofD5iqqXNF1kta ZCeuLdU8Ytvx41jp8+PQw3heK/LJAhm0lmYbVlcRYRmARZEGzvaknbH/v7H84PC+ zt+kWPqC47Xva6GneyYfpD6iuaF3uvfYBdyPqZPGxZVVF4evxWHARRrJFvokhpcd TD02u5iLv67LpgzSUDvbATTQIO8NJcTPwrQKrHpWdnl3rFXvhEs= =fWO2 -----END PGP SIGNATURE----- --=-=-=--