From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: mike@rohleder.de, 43204@debbugs.gnu.org
Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib.
Date: Mon, 07 Sep 2020 14:15:41 +0200 [thread overview]
Message-ID: <875z8pkck2.fsf@gnu.org> (raw)
In-Reply-To: <87wo18piv4.fsf@gmx.com> (Pierre Langlois's message of "Sat, 05 Sep 2020 12:23:43 +0100")
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Hi!
Pierre Langlois <pierre.langlois@gmx.com> skribis:
> Actually, thinking about this a little more, I'm not sure I understand
> upstream decision to propagate -lz. The commit fixes [0] which indicates
> it's so that taglib can be linked statically, but then that means if
> we're dynamically linking, the application will also dynamically link
> with zlib when it doesn't need to (at least not directly). And in guix
> we only build shared libs for taglib so we're never statically linking
> it AFAIK.
>
> So, here I'm a bit torn here, should we just follow what upstream is
> indicating? Even it doesn't look right to me, but I might be wrong! Or,
> should we revert the change that propagates -lz?
I had the following patch that I intended to push, to avoid propagation.
WDYT?
Ludo’.
[-- Attachment #2: Type: text/x-patch, Size: 2038 bytes --]
commit d8124a707602980556fd33c7dbf9f7483fe1d0df
Author: Ludovic Courtès <ludo@gnu.org>
Date: Mon Sep 7 09:56:08 2020 +0200
gnu: taglib: 'taglib-config --libs' shows -L flag for zlib.
Fixes compilation of emacs-emms-print-metadata.
* gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases.
diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 7ee009df74..a7574f0cf9 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -1,6 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
-;;; Copyright © 2014, 2015, 2017 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2014, 2015, 2017, 2020 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
@@ -174,7 +174,18 @@ a highly stable and efficient implementation.")
(build-system cmake-build-system)
(arguments
'(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on.
- #:configure-flags (list "-DBUILD_SHARED_LIBS=ON")))
+ #:configure-flags (list "-DBUILD_SHARED_LIBS=ON")
+ #:phases (modify-phases %standard-phases
+ (add-before 'configure 'adjust-zlib-ldflags
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; Make sure users of 'taglib-config --libs' get the -L
+ ;; flag for zlib.
+ (substitute* "CMakeLists.txt"
+ (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
+ (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
+ (assoc-ref inputs "zlib")
+ " -lz)")))
+ #t)))))
(inputs `(("zlib" ,zlib)))
(home-page "https://taglib.org")
(synopsis "Library to access audio file meta-data")
next prev parent reply other threads:[~2020-09-07 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:38 [bug#43204] [PATCH] gnu: taglib: Propagate zlib Michael Rohleder
2020-09-04 16:12 ` Pierre Langlois
2020-09-05 11:23 ` Pierre Langlois
2020-09-07 12:15 ` Ludovic Courtès [this message]
2020-09-07 13:26 ` Michael Rohleder
2020-09-07 13:41 ` Pierre Langlois
2020-09-07 22:55 ` bug#43204: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z8pkck2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43204@debbugs.gnu.org \
--cc=mike@rohleder.de \
--cc=pierre.langlois@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.