From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KO3SCPcR/1/PRQAA0tVLHw (envelope-from ) for ; Wed, 13 Jan 2021 15:29:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yGSwBPcR/18mPgAAB5/wlQ (envelope-from ) for ; Wed, 13 Jan 2021 15:29:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9BDD29403AC for ; Wed, 13 Jan 2021 15:29:58 +0000 (UTC) Received: from localhost ([::1]:54080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzi5t-0004jx-1x for larch@yhetil.org; Wed, 13 Jan 2021 10:29:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzi25-0000jT-VV for guix-patches@gnu.org; Wed, 13 Jan 2021 10:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzi25-0005SI-ON for guix-patches@gnu.org; Wed, 13 Jan 2021 10:26:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzi25-0000LJ-Kk for guix-patches@gnu.org; Wed, 13 Jan 2021 10:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 0/1] Add pinentry-rofi Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Jan 2021 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.16105515051242 (code B ref 45190); Wed, 13 Jan 2021 15:26:01 +0000 Received: (at 45190) by debbugs.gnu.org; 13 Jan 2021 15:25:05 +0000 Received: from localhost ([127.0.0.1]:36302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi1B-0000Jy-5R for submit@debbugs.gnu.org; Wed, 13 Jan 2021 10:25:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi1A-0000JN-49 for 45190@debbugs.gnu.org; Wed, 13 Jan 2021 10:25:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57986) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzi14-0004oR-UE; Wed, 13 Jan 2021 10:24:58 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39546 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kzi13-0005NJ-PO; Wed, 13 Jan 2021 10:24:58 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> <87o8i5zpme.fsf@gnu.org> <878s926emu.fsf@posteo.net> Date: Wed, 13 Jan 2021 16:24:56 +0100 In-Reply-To: <878s926emu.fsf@posteo.net> (Fredrik Salomonsson's message of "Fri, 08 Jan 2021 18:14:01 -0800") Message-ID: <875z4097w7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45190@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9BDD29403AC X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: dDVyBzYGwsEe Hi, Fredrik Salomonsson skribis: >>> + (arguments >>> + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is f= ailing >> >> Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure thi= s is necessary? > > It was failing with a warning as there are no binaries to strip. But > it's not an error so I removed this in v2. Right, it=E2=80=99s just a warning, due to the fact that .go files are ELF = but the =E2=80=98strip=E2=80=99 command doesn=E2=80=99t know what to do with th= em. >> Since I think you=E2=80=99re also upstream :-), how about adding somethi= ng like >> that at the top of the installed executable: >> >> (eval-when (load expand eval) >> (set! %load-path (cons "@moddir@" %load-path)) >> (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) >> >> ? > > Yup, I'm upstream as well. I don't mind adding that, just need to know > what it solves :). I'm guessing that it removes the need to wrap the > executable, is that correct? > > And are the "@moddir@" and "@godir@" expected to be expanded by > automake? I tested to just add it in the source code and automake did > nothing with them. It=E2=80=99s replaced provided =E2=80=98configure.ac=E2=80=99 defines them = and AC_SUBSTs them, along these lines (here they have a longer name): https://notabug.org/guile-zstd/guile-zstd/src/master/configure.ac#L43 >> It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2= =80=9Crofi=E2=80=9D >> string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80= =A6/bin/rofi=E2=80=9D in a post-install >> phase? > > Is there a rule of thumb or something to know when to use propagating > inputs? I'm a bit confused when to use is it. Is it just when dealing > with libraries? What are the downsides of using propagating inputs? > Apologize if this is already mentioned in the manual. Only sections I > could find that mentions propagated inputs are section 5.2 and 8.2.1. In general, propagated inputs should be avoided as they =E2=80=9Cpollute=E2= =80=9D the user=E2=80=99s profile (you install X and find yourself with X, Y, and Z). The preferred method in situations like this is to patch the source so it uses absolute file names for commands. Thanks for sending an updated patch! Ludo=E2=80=99.