From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WB4gBQegBWBxMwAA0tVLHw (envelope-from ) for ; Mon, 18 Jan 2021 14:49:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YGH8AAegBWAoOgAAB5/wlQ (envelope-from ) for ; Mon, 18 Jan 2021 14:49:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61B67940501 for ; Mon, 18 Jan 2021 14:49:42 +0000 (UTC) Received: from localhost ([::1]:34502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1Vqe-0001A1-8c for larch@yhetil.org; Mon, 18 Jan 2021 09:49:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1Vp4-0000sB-Qc for bug-guix@gnu.org; Mon, 18 Jan 2021 09:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1Vp4-000582-GJ for bug-guix@gnu.org; Mon, 18 Jan 2021 09:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1Vp4-0005kb-EF for bug-guix@gnu.org; Mon, 18 Jan 2021 09:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45836: [PATCH] services: Let cups-service-type reuse base lp group. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 18 Jan 2021 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45836 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler Received: via spool by 45836-submit@debbugs.gnu.org id=B45836.161098125422051 (code B ref 45836); Mon, 18 Jan 2021 14:48:02 +0000 Received: (at 45836) by debbugs.gnu.org; 18 Jan 2021 14:47:34 +0000 Received: from localhost ([127.0.0.1]:46824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1Vob-0005ja-QM for submit@debbugs.gnu.org; Mon, 18 Jan 2021 09:47:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1VoZ-0005jN-HX for 45836@debbugs.gnu.org; Mon, 18 Jan 2021 09:47:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57198) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1VoS-0004oA-F5; Mon, 18 Jan 2021 09:47:24 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55750 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1VoQ-0008Lv-4b; Mon, 18 Jan 2021 09:47:23 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210114130610.31936-1-leo.prikler@student.tugraz.at> <875z3wzq1k.fsf@gnu.org> <5c790abbd52abae17c6b449b4982380f9ae26806.camel@student.tugraz.at> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Jan 2021 15:47:20 +0100 In-Reply-To: <5c790abbd52abae17c6b449b4982380f9ae26806.camel@student.tugraz.at> (Leo Prikler's message of "Sat, 16 Jan 2021 20:49:10 +0100") Message-ID: <875z3ul2tj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45836@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 61B67940501 X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: l32EZRbyuMEB Hi, Leo Prikler skribis: >> > diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm >> > index 0538fb1a24..7c57222716 100644 >> > --- a/gnu/system/shadow.scm >> > +++ b/gnu/system/shadow.scm >> > @@ -321,13 +321,13 @@ of user '~a' is undeclared") >> > objects. Raise an error if a user account refers to >> > a undefined >> > group." >> > (define accounts >> > - (filter user-account? accounts+groups)) >> > + (delete-duplicates (filter user-account? accounts+groups) >> > eq?)) >> >=20=20 >> > (define user-specs >> > (map user-account->gexp accounts)) >> >=20=20 >> > (define groups >> > - (filter user-group? accounts+groups)) >> > + (delete-duplicates (filter user-group? accounts+groups) eq?)) >>=20 >> Why use =E2=80=98eq?=E2=80=99? I=E2=80=99d use =E2=80=98equal?=E2=80=99= , but note that >> records >> cannot necessarily be compared with =E2=80=98equal?=E2=80=99 because of = the thunked >> =E2=80=98home-directory=E2=80=99 field (=E2=80=98equal?=E2=80=99 is mean= ingless for procedures). > My personal reasoning (and perhaps a rather strong opinion) is, that it > is an error to add duplicate users even if they happen to be equal?.=20 > eq? is only provided as a way out for the specific case of services, > that need to do so for safety reasons =E2=80=93 e.g. cups to not allow > overriding of the lp group if it has been removed from the OS groups > for whichever reason. Ah I see, makes sense to me! Thanks, Ludo=E2=80=99.