all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Vinícius dos Santos Oliveira" <vini.ipsmaker@gmail.com>
Cc: 46231@debbugs.gnu.org
Subject: [bug#46231] Add emilua
Date: Sun, 21 Feb 2021 02:21:42 +0100	[thread overview]
Message-ID: <875z2mxljt.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAK9RveLd+iUDd7y+L2z4u6Lw1z45=pPfOYsE4LyG=m7Ndu540w@mail.gmail.com> ("Vinícius dos Santos Oliveira"'s message of "Mon, 1 Feb 2021 07:00:42 -0300")

Hello,

Vinícius dos Santos Oliveira <vini.ipsmaker@gmail.com> writes:

> I've created a new package for guix. Here's its definition:
> https://gitlab.com/emilua/emilua/-/snippets/2068658

Thank you!

> Please let me know if it has any issues so I can fix them until it's
> ready for inclusion in the main repository.

There are some issue to fix:
- the name of the custom luajit2 package should be changed. Maybe
  openresty-luajit?
- that package should have a proper version and build tag out of it.
- I see that emilua uses #:recursive? set to #true. Could some
  submodules could be unbundled by any chance?
- You disabled tests. I would be nice to provide a reason for that.
- You don't need `string-append' in the description. Just write the full
  textin a single string.

Could you split this into two patches and send them here, for easier review?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-02-21  1:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:00 [bug#46231] Add emilua Vinícius dos Santos Oliveira
2021-02-21  1:21 ` Nicolas Goaziou [this message]
2021-02-21 12:04   ` Vinícius dos Santos Oliveira
2021-02-22 10:04     ` Nicolas Goaziou
2021-02-23 20:35       ` Vinícius dos Santos Oliveira
2021-02-24 13:07         ` Nicolas Goaziou
2021-02-24 13:20           ` Vinícius dos Santos Oliveira
2021-02-24 15:49             ` Nicolas Goaziou
2021-02-25 14:11               ` Vinícius dos Santos Oliveira
2021-02-27 11:20                 ` bug#46231: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z2mxljt.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46231@debbugs.gnu.org \
    --cc=vini.ipsmaker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.