From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 46564@debbugs.gnu.org
Subject: [bug#46564] [PATCH core-updates]: Use autoconf-wrapper instead of autoconf
Date: Sun, 21 Feb 2021 23:05:11 +0100 [thread overview]
Message-ID: <875z2lgjqg.fsf@gnu.org> (raw)
In-Reply-To: <87zh03dgty.fsf@telenet.be> (Maxime Devos's message of "Tue, 16 Feb 2021 19:10:17 +0100")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> This patch replaces autoconf with autoconf-wrapped in the native-inputs
> almost everywhere (except for some packages in
> gnu/packages/autotools.scm). As this would cause many rebuilds, this
> patch targets the "core-updates" branch and not "master".
OK.
> A wine package has autoconf in the inputs instead of native-inputs,
> I wonder if that's intentional or a bug? I left that package untouched
> for now.
I think that’s a bug.
> Why this change?
>
> * consistency / reducing confusion: some packages use autoconf, some use
> autoconf-wrapper, and there's no (to me) obvious reason why two variants
> of autoconf should be used.
>
> * <whatever pro's nckx had in mind on #guix>
>
> * some progress towards booting without /bin/sh
>
> Scenario I have in mind (untested):
>
> 1. boot a system that doesn't have /bin/sh
> 2. decide to hack on guix (run git clone ...., cd $REPO)
> 3. guix environment guix
> 4. sh ./bootstrap (calls autoreconf -vfi)
> 5. ./configure --localstatedir=/var
> 6. more stuff
>
> Without this patch, step (5.) will fail without this patch because
> the generated ./configure script refers to /bin/sh, which doesn't
> exist.
>
> That said, there are some #!/bin/sh shebangs in the source code,
> so there are some problems in (6.).
Yeah, I’m not sure this is a worthy goal.
> Why not?
>
> * ‘make dist’ will produce unusable tarballs
> when in an environment from ‘guix environment PACKAGE’.
> This should now be replaced with ‘guix environment PACKAGE --ad-hoc
> autoconf'.
Yeah. I would be in favor of unifying things the other way around:
using ‘autoconf’ instead of ‘autoconf-wrapper’ everywhere. Since
there’s the ‘patch-shebangs’ phase, we don’t need ‘autoconf-wrapper’.
There’s one exception I think: Automake. This one needs
‘autoconf-wrapper’ so it can actually run its test suite. Perhaps
Libtool too.
WDYT?
Ludo’.
next prev parent reply other threads:[~2021-02-21 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 18:10 [bug#46564] [PATCH core-updates]: Use autoconf-wrapper instead of autoconf Maxime Devos
2021-02-21 22:05 ` Ludovic Courtès [this message]
2021-02-22 17:23 ` Maxime Devos
2021-02-23 8:19 ` Ludovic Courtès
2021-03-17 22:12 ` bug#46564: " Ludovic Courtès
2021-02-23 8:19 ` [bug#46564] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z2lgjqg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=46564@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.