From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iD7LGOWcgGBgfgAAgWs5BA (envelope-from ) for ; Wed, 21 Apr 2021 23:45:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sB9xFOWcgGCuQgAAB5/wlQ (envelope-from ) for ; Wed, 21 Apr 2021 21:45:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15C3620B8D for ; Wed, 21 Apr 2021 23:45:09 +0200 (CEST) Received: from localhost ([::1]:34670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZKei-0004qa-6Q for larch@yhetil.org; Wed, 21 Apr 2021 17:45:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZKec-0004qS-NH for guix-patches@gnu.org; Wed, 21 Apr 2021 17:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZKec-00032h-F7 for guix-patches@gnu.org; Wed, 21 Apr 2021 17:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZKec-0005bk-CV for guix-patches@gnu.org; Wed, 21 Apr 2021 17:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47930] [PATCH] gnu: Add pbgzip. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Apr 2021 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47930 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roel Janssen , 47930@debbugs.gnu.org Received: via spool by 47930-submit@debbugs.gnu.org id=B47930.161904150121536 (code B ref 47930); Wed, 21 Apr 2021 21:45:02 +0000 Received: (at 47930) by debbugs.gnu.org; 21 Apr 2021 21:45:01 +0000 Received: from localhost ([127.0.0.1]:59958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZKeZ-0005bF-Dx for submit@debbugs.gnu.org; Wed, 21 Apr 2021 17:45:01 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:40008 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZKeV-0005b0-N7 for 47930@debbugs.gnu.org; Wed, 21 Apr 2021 17:44:58 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1619041489; bh=YOulrT5SdjLOzvrd1nDDQ6wYo7O3gsSzQohu59tOMUE=; h=From:To:Subject:In-Reply-To:References:Date; b=o9p0NashWLcDtBvndM5lf5CXPGuAvY9UIET+bCGeDGxiHbXLxOBO3tBPBP5cPyEd1 fZIZxUJqloCKfF+jbVWREUZysdsF9FgfDLq4Y7OV2qHo9wLfdrkgzZdjyXsTJUls8Z F8ER+6HBBYrlMf0P7/PPym/DGMOhmbunUW86MsN8= In-Reply-To: References: Date: Wed, 21 Apr 2021 23:44:48 +0200 Message-ID: <875z0f71nz.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619041509; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=y1fzAZbnnISbpNyiULeZouDLUnHPYvJSV0TYiJLYKMY=; b=hW8a+bVmZCzp8Y6mqAxZx7s+5wzQazoXqRl/CLTYMvOEESNOXdo7WOzKaivGuOAhGL+Oe6 SkkEKdyCe0WrRGMgyY5uBfqkzxa88gIdmv5RAUNE4NrWu/XtlEfzaJKIPPYLWpuN2xDSut TsVxbMryS8K5Oq5vN0bqRgVSvb9YoQJJfLnIedLMCSTHvfoXboFxZerLHqp2sZyPELUSOJ pQJA+ZOW1lsGcp8p81lt6e7nrboerS2E7mPVuAy+B7id0JguOuEaDqulF60mJxH8/VPu1r fCkShzr4vTKoeByBaTWJhNsFhANrgiWqr9UyPmJd8RGR4zqqzy5rD/PzQuGIGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619041509; a=rsa-sha256; cv=none; b=qFoe7bcUVQPuw6i/ebucpcLHOFqN5mL0RbyJIs88LU3zGaCJHsOnzJH/Zl0vLWHlWY3D8Z 5btHfeiRMrac0tHzwTFNtAsC8zaHe8muk/1HrEWkfbj5oby5vdtfSzAcN7tPs8CmE7PVP7 FF6rKh2FjTAUOmdTioLdfTShcjjGwSLfhFhDfh2SPcKpgKQtk8xbXCpnEXqvEgJnmx74gh 2WarH5u298qmNVCNspKkkpFMJSMOxGcy0+VxkgB52W7kj3YhHCbv6dfGZ/Fg5DyGqpYnxV 3H7Vf7+7fPiV4Zf/5zVfMbYSpfsNELnq3smAmxlqeznmMJU4k53qa2sVntYTQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=o9p0Nash; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=o9p0Nash; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 15C3620B8D X-Spam-Score: -3.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: L4x3Iqk8NLgC --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Apr 21 2021, Roel Janssen wrote: > * gnu/packages/bioinformatics.scm (pbgzip): New variable. > > [...] >=20=20 > +(define-public pbgzip > + (let ((commit "2b09f97b5f20b6d83c63a5c6b408d152e3982974")) > + (package > + (name "pbgzip") > + (version (string-take commit 7)) I think using (git-version VERSION REVISION COMMIT) is preferred. Something like (git-version "0.0.0" "0" commit). > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nh13/pbgzip") > + (commit commit))) > + (file-name (string-append name "-" version)) Use (git-file-name name version). > + (sha256 > + (base32 > + "1mlmq0v96irbz71bgw5zcc43g1x32zwnxx21a5p1f1ch4cikw1yd"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (zero? (system* "sh" "autogen.sh"))))))) IIRC, phases don=E2=80=99t have to return #t, so you could remove =E2=80=98= zero?=E2=80=99. Builds fine, but I haven=E2=80=99t tested it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmCAnNAVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5gzoP/ix8CAlbjDKcYjkIWPg4sn9CMnrp iY9N/AqBRf/gdLr8uBLIryClg/9MK6ihpLzFxn0Aa9Ildbn/kEl40OjfSfhap5lP d8N/HHaJuXd6JY6xF9xi/Nd24/Uzjg0hXO1pUFYJdq6JhYGkIFaZfBDgpUvKi51b a0pl3Nh511RnevAN9flHpdY0sso/QXYEyYo7fIOY7XPxstpjd0yYtdunmxSgsUb4 Lt9FhqzYcVMZYAbBCdn3PYQ/sV3XQbemdmf0+BtDTe2h35AT9u4ShhucF4xeFq/n zTIptWkZXQFCU6VdkTHka905ltuqiCPk7bxfPC2Q8wBDMlwHa9SVoakuQbFlC83C dZ/qFVukImnGSIn3DRWVD9OY0zlJQA4uqZbmjvIkV6fy+QDEnDDs0BMV8hfajzZY NjT4RFNWVn7554P1AGEGkRDKbeRia61laHnpBYhvgCWZmHlEcxDcVtvrqg/g/B4F ErZRQo71iLZ09MzebDefDq98JjLt0OAqmb8bsZ+Iav8WyIBz1JUqM06ySwq+DksC bvfjiF19zz40Rp1PxkeAzVEIuIeCu6NX4vWq2LInAZQMy1JamscA53aRHXJCu7p5 RhK4goD70bwK5FakduxEBM7K83eR3UG3bd/Jyyzff08bbuhGxD6r/en+hicQZD8G dzlOM36nbDONq8OR =lCr3 -----END PGP SIGNATURE----- --=-=-=--