From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UNaGOe63rGAHWQAAgWs5BA (envelope-from ) for ; Tue, 25 May 2021 10:40:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YJcyNe63rGAQMwAAB5/wlQ (envelope-from ) for ; Tue, 25 May 2021 08:40:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 850852E1BA for ; Tue, 25 May 2021 10:40:14 +0200 (CEST) Received: from localhost ([::1]:33016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llSbl-0003wk-JS for larch@yhetil.org; Tue, 25 May 2021 04:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llSba-0003w5-Ri for guix-patches@gnu.org; Tue, 25 May 2021 04:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llSbZ-0007aP-S2 for guix-patches@gnu.org; Tue, 25 May 2021 04:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llSbZ-0002pz-P4 for guix-patches@gnu.org; Tue, 25 May 2021 04:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48642] [PATCH] Add kanatest Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 May 2021 08:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48642 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 48642@debbugs.gnu.org Received: via spool by 48642-submit@debbugs.gnu.org id=B48642.162193196110854 (code B ref 48642); Tue, 25 May 2021 08:40:01 +0000 Received: (at 48642) by debbugs.gnu.org; 25 May 2021 08:39:21 +0000 Received: from localhost ([127.0.0.1]:44649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llSav-0002oz-5M for submit@debbugs.gnu.org; Tue, 25 May 2021 04:39:21 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:42561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llSas-0002ol-L2 for 48642@debbugs.gnu.org; Tue, 25 May 2021 04:39:19 -0400 Received: by mail-ej1-f53.google.com with SMTP id lg14so45983239ejb.9 for <48642@debbugs.gnu.org>; Tue, 25 May 2021 01:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=TSLVspC1e/rQivuS1ozAUVhREAOutOEcwFzjLsA/AvE=; b=ota83bETpEwgtifiURkKGp8CxtfMJvVUxYwxMuuMC3JuIOni6GdhZf6SH8o2aNDsXx W+UFE2MifHwpV1pfpR84VN+TQbvqH5Y6AZCaaaDn9uRvop7WLGZ8zgQVdMdDsvRnCdG1 5H4iQ5zVRMyIXPn6oH2ygNZBflstL2OeLQZzojaN0QOFxEeru70moMqsY3NmGqV9i41Z xsuPXccneOIo+Jd6YXovXpcp8vWmbLnTnN2REInoVfAYDMCA7hWqjCccI39Ia4w3PDqi n7GSGQXhggfKbB3TvbozmtfWmpVIhzFOUCLYaykTX4+qZ2QXoKHItBfQfwQ/lSbex6sX Jpsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=TSLVspC1e/rQivuS1ozAUVhREAOutOEcwFzjLsA/AvE=; b=JAsYHwFHQQgE/fpIJxJhwZsdob9urU5b/F4zVJOulqcMVycm03Z1VYZHteNBcEtgTU he1eVaxctptnB/eEtZ7H6UdyH6sAsh03QrlaZcBwNm5cnMQS7rNCzx03WOwLWGgsJgbg CA/x/srtEs+SW3jVRW9rmT21aL81LGtBpSzhmbgQyScnJN8H0WzjaBv8w1/+9dFu1he1 qGJZBBla3hsT/5659HPDJY6w7by8GJaohVU1vVrx5bNwT3ES7sr88aGrXNSQGNNWcpWr 9C8lSAkAozEudHfl8I+Vrql+NiAJcTG7w0aNIWlzxlh7hXaSrtvaAjy2Is/WnBuKHCLC w1/w== X-Gm-Message-State: AOAM530bJ+VLB4jqqmFbwHjw0EYmEjp1Ri0FpXR3KWswyo0PKfI403O/ q7D6Xsr3+c1jc6kwZ/Ey0xNlsDVReaM= X-Google-Smtp-Source: ABdhPJxEM98J5jZJIjtgVexgK+u/iiCP99a2IQQP4K5eXnHTzhtnDoNP8p07vq7gepZAVh+ahaBIfg== X-Received: by 2002:a17:906:b0c:: with SMTP id u12mr27485786ejg.37.1621931952642; Tue, 25 May 2021 01:39:12 -0700 (PDT) Received: from guixSD (host-79-17-142-89.retail.telecomitalia.it. [79.17.142.89]) by smtp.gmail.com with ESMTPSA id i5sm10492975edt.11.2021.05.25.01.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 01:39:12 -0700 (PDT) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <87h7irkycq.fsf@yoctocell.xyz> References: <878s435lct.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87h7irkycq.fsf@yoctocell.xyz> Date: Tue, 25 May 2021 10:39:10 +0200 Message-ID: <875yz75hsh.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621932014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TSLVspC1e/rQivuS1ozAUVhREAOutOEcwFzjLsA/AvE=; b=bP+rtZwG9gQfFCImH9t0n97Yo2kmZXPY8ScDxMj2zfH14Jhtd8D3ROfz8JQVxETCu+U4Pk at7iOuanb6OkmciMMEpDYODwt2UzYf/jKoGDoMPxSxjthh/+dS9z8bqyebEXkX9lIOj3Os ZZu4Bhs/O2zP1x/SnCrQrAyImAgS3QWVQtaM4Qb1UoIjqiiOAznk1SJ1eI/6lyY2xp7Sfz 42JsLGLdUtYYACYfL7WNT6hSzGEXxVkI6lKlk9CUr89qshayZ4Osm/3VR55dhr3C11HIVC MMxx8UJ4xH6vlgYC6fPgqc0eQ7Sg7uU8HkRjANc3w28d/b5ad79+OpoM1oscOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621932014; a=rsa-sha256; cv=none; b=cPx4KKuAoIHLBZ/KLU/tLlnuNJ8ARSSCBqH5MRJjvdBmn3uGTBTPYOFyRcPn1peR5t9bLy Z8T/YU3Xd+I4rFUndm7SGwX/xQvO7AjKGpXpOdCvX9m+scVHEvH94Df0KaZUf+XI+ydzhL IWxtVU/AGQBzxco6rCweZGZZtGADVFAcxKZyXaL2BkmPZl+lYcF10GyGliKsaiq1oU+YR0 H1UWfBRFiSDuQYrTs/qv2A69z208u4yfpDnEYk/q1YKMDfFGMIYNSRMHgUkNhI8cC1rKUJ PSxjC74Siud16bETkzCi/0tLCo/a20eHkZBeXZ7kbY3S0Kq3WX3lgyXS8bazZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ota83bET; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ota83bET; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 850852E1BA X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 451QYlbycjev --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Thanks for the fast review! Xinglu Chen writes: > On Tue, May 25 2021, Nicol=C3=B2 Balzarotti wrote: > >> +(define-public kanatest >> + ;; Latest release tarball is 0.4.8, which is really old and does not = build >> + ;; commit on sourceforge are not tagged, we take the latest >> + (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff")) >> + (package >> + (name "kanatest") >> + (version (string-append "0.4.10." (string-take commit 7))) > > Use =E2=80=98(git-version VERSION REVISION COMMIT)=E2=80=99. > I added revision "0" along with commit in the let block and used git-version as suggested. >> [...] >> + (home-page "https://kanatest.sourceforge.io/") > > Nit: =E2=80=98home-page=E2=80=99 usually comes before =E2=80=98synopsis= =E2=80=99. > Moved above! > Otherwise, LGTM! Builds fine as well. Thanks, here's version 2 of the patch! Thanks again for the review, Nicol=C3=B2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-gnu-Add-kanatest.patch >From e40dcce2eb93a033124fb5bcdb7c0be87e63313c Mon Sep 17 00:00:00 2001 From: nixo Date: Tue, 25 May 2021 09:02:41 +0200 Subject: [PATCH v2] gnu: Add kanatest. * gnu/packages/education.scm (kanatest): New variable. --- gnu/packages/education.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm index cd28e35b78..266dc89bdd 100644 --- a/gnu/packages/education.scm +++ b/gnu/packages/education.scm @@ -865,6 +865,43 @@ languages and keyboard layouts, and typing statistics are used to dynamically adjust the level of difficulty.") (license license:gpl2))) +(define-public kanatest + ;; Latest release tarball is 0.4.8, which is really old and does not build + ;; commit on sourceforge are not tagged, we take the latest + (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff") + (revision "0")) + (package + (name "kanatest") + (version (git-version "0.4.10" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://git.code.sf.net/p/kanatest/code") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0dz63m9p4ggzw0yb309qmgnl664qb5q268vaa3i9v0i8qsl66d78")))) + (build-system gnu-build-system) + (native-inputs + `(("gettext" ,gettext-minimal) ; for msgfmt + ("pkg-config" ,pkg-config))) + (inputs + `(("libxml2" ,libxml2) + ("gtk+" ,gtk+))) + (home-page "https://kanatest.sourceforge.io/") + (synopsis "Hiragana and Katakana simple flashcard tool") + (description "Kanatest is a Japanese kana (Hiragana and Katakana) simple +flashcard tool. + +During test the Kanatest displays randomly selected kana char (respecting mode +and lesson) and waits for user answer expected as romaji equivalent. This +process continues until all questions will be answered or all questions will +be answered correctly (depends on options). At the end of test a short info +about drilling time and correctness ratio is displayed. The results are +stored and user can review his performance in any time.") + (license license:gpl2+)))) + (define-public anki (package (name "anki") -- 2.31.1 --=-=-=--