From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id rufrFEZurWDPOwAAgWs5BA (envelope-from ) for ; Tue, 25 May 2021 23:38:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ABMFEEZurWBnDQAAbx9fmQ (envelope-from ) for ; Tue, 25 May 2021 21:38:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 505F51B7B4 for ; Tue, 25 May 2021 23:38:13 +0200 (CEST) Received: from localhost ([::1]:52134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lleke-0002sj-2X for larch@yhetil.org; Tue, 25 May 2021 17:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llehb-0001Wi-1c for guix-patches@gnu.org; Tue, 25 May 2021 17:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lleha-0004F4-Jj for guix-patches@gnu.org; Tue, 25 May 2021 17:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lleha-0003Op-Fm for guix-patches@gnu.org; Tue, 25 May 2021 17:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 May 2021 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48630 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki , 48630@debbugs.gnu.org Received: via spool by 48630-submit@debbugs.gnu.org id=B48630.162197848513039 (code B ref 48630); Tue, 25 May 2021 21:35:02 +0000 Received: (at 48630) by debbugs.gnu.org; 25 May 2021 21:34:45 +0000 Received: from localhost ([127.0.0.1]:47201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llehJ-0003OF-FX for submit@debbugs.gnu.org; Tue, 25 May 2021 17:34:45 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:33786 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llehE-0003Nx-L6 for 48630@debbugs.gnu.org; Tue, 25 May 2021 17:34:43 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1621978472; bh=BcfM/t87FHbvZDbki7C+gjPSmBBE3pqUasd8Bt0HdTA=; h=From:To:Subject:In-Reply-To:References:Date; b=M+SLR2q90yAsLd98z/bgn/f93UMa5V/6f1dzMTsJDa4n2iuDkY10HKJDM/1/uIsnh gV87Qm90oSWyZKApOHAaKarPO7Y9wvV1/DLsJRZzK6nCZtHuYOkhBTL/ryOgUsc2LU Vr5BZfmYn6ABWM1GPvrxkpFwq3PZXlhlCSwoQqA8= In-Reply-To: <20210525191259.23awunfcwdr6p3cg@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> <20210525191259.23awunfcwdr6p3cg@silver> Date: Tue, 25 May 2021 23:34:26 +0200 Message-ID: <875yz67b19.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621978693; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ANkHiTwfeDWjZCtRb3duk5dzIy3Gm+cNOMDXEYFCIjs=; b=gr/4KBOyv4VkPh+dCxhDP7Ezhsu3aLP+TkfMXgICmiLyKGexKtPEvmXa7hNZOhD5/qvYd4 fPRdudnq7UTaoLCS5A3CiRR9lC7C9SsE7Tq5ZZeRsfdgY0hlHDuAy0R7owcOvVgq4dS63r jxziP/SMaFL0OW7Y9aNuf+ofYNuUP0ZXpI49xFmTPtdpou/nNOjEoFo+pic9+OMyYMCik/ IEWo0xkIK3Ckp9HKm/HiYZ2w+/u7hSOieNNdgnMMw7S+6LbhwQIEHbbU7nNt+Fuj5p8XnC 24HCh5zFcIy0yDu5+p1oc86LqaE09xnQsWM9Ynws4c04AWF75g57VNNOvdXf7Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621978693; a=rsa-sha256; cv=none; b=TJm6ir49Zy3z1arTiCKsrjqqKFq6K+yZprIe0AD0RMiRTmpzXEQJQEl6pKgmaN5ir9rgKT 1iQVf3DqaLbPKKAeYBYTQ0ZoSBMi9F36CwdI7/GvNwWHhHvwJIrYdCbB+zIkV/4TIHxwTO 2uwVuxm6eveJUNkUXJm0z3nlN/hborv9x06Ku1e9HPjTMgbesRFDXvgJeJQOyRpKQTktTo JtFyph2BelZMSrHehK8cO28v+IkrrmPP3PJ0rsLAeNTuh61IUX5Sc2doIEFmdEMG/ueXHb a5pIAuWKysyT7SqcJVSJ/a1ub5qB9Z+xXiWCs0IMux9Dz3woUf2hrCaP51tueQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=M+SLR2q9; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=M+SLR2q9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 505F51B7B4 X-Spam-Score: -2.59 X-Migadu-Scanner: scn1.migadu.com X-TUID: y30agxuvAGeH --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, May 25 2021, Gabriel Wicki wrote: > thanks for the advice, i'll update and split the patch into a small > series soon! Great! :) > the tests are deactivated because 3 of 841 fail. they seem to check > some kind of shebang #! paths. see this excerpt from the build log: > > # Failed test 'Util::sets_match( TEST_TYPE with -t perl )' > # at t/ack-type.t line 43. > > # actual[ > # 't/swamp/0:1:#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30= .2/bin/perl -w', > ... > # ] > # expected[ > # 't/swamp/0:1:#!/usr/bin/perl -w', > ... > # ] > > these lines are being ignored by the patch-generated-file-shebangs > phase, maybe because the #! aren't at the beginning of the line? > > i'm a total novice in Perl, so i'm not sure what exactly is happening > there or why this is even tested. > > should i try and add my own version of a patch-shebang after the > patch-generated-file-shebangs phase? Yes, you could add add a phase after the =E2=80=98patch-generated-file-sheb= angs=E2=80=99 phase that replaces #!/usr/bin/perl with #!/gnu/store/...-perl/bin/perl. Something like this should work (untested): #+begin_src scheme (add-after 'patch-generated-file-shebangs 'patch-more-shebangs (lambda (#:key inputs #:allow-other-keys) (substitute* '("t/ack-type.t" ...) (let ((perl (assoc-ref inputs "perl"))) (("/usr/bin/perl") (string-append perl "/bin/perl")))))) #+end_src=20=20=20=20=20=20=20=20=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmCtbWIVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x51D4QALpTSaGICSvR/DwjdpAFdEDZL2tP LRfQ8aR4bwihMgisSnX9MjIJ0KemK6vPKdCAYuXHfQAEWeBNzFaTmqlPkctlNRXx uT+VKMWz6GeAYX1p8YjLET5EXLo3351OBeGLkSGH8aTFEHqLH031FZfxPGXvtg7X 1WiJq4Zwh5GBpJlV4WPz1LRVRHF8xeOVrKRtW41XLncrxHAJuxUOsZK5uJ9jzzLA E3yJbFR/Yg3sMksS76TGKOP72zl09A11o6lO7aViKxilngBzDWPalKYSf/Gu/qai pZ8tLD/USGbDdb41TVEhR1SNtCt+boyAY4LeoNrFsAo4nwDGV2jj8NPDMPz0DKHG IWaovGJdKnwnbeY/XLftPg8QIvkQwTyHowDWCS1yJgscZa+eFPMqqE/NCceIekvB CcVdkpjlDUE67KSRCYa0RDqzr9Ibbpnls0KeST99xQH7PGGIp3uWkoQJq68lljBq 8vUFxgUeqyC9FQRpzRP6rnpnwO8HRhHCUCnDfwTM5ueU+OFqodVrLF/1F3d3ShHr PWFkfJLFDkXc3JZ0u3FuxU3LpwTc9ODKSzt1rnIeTGPI04K4biMUtJ1J8dMSKq5h kt7p4Qwhw1DHVRYolSxEMUls2KyJZXTjH8wL3PeFerKCOyg1eBnLmuVWeWbPXE2I 1fxMGRKCHiMbcnrs =79BR -----END PGP SIGNATURE----- --=-=-=--