On Sat, Sep 18 2021, phodina wrote: > Hi Xinglu, > > anything else to be fixed to upstream this patch? Sorry for taking so long to reply! The patch looks good, except that the description should consist of full sentences (the first sentence doesn’t have a subject), something like: This Rust library implements automatic rotation for modern Linux screen and input device. Compatible with wayland and X11. Uses built-in accelerometer with configurable threshold. The person who commits the patch (I don’t have commit access) can probably adjust the description for you, so you don’t have to send a reroll just for this small change. :-)