From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MDrVLpuvuGFgMQEAgWs5BA (envelope-from ) for ; Tue, 14 Dec 2021 15:52:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OJyXKpuvuGEvDQAAbx9fmQ (envelope-from ) for ; Tue, 14 Dec 2021 14:52:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77F902803B for ; Tue, 14 Dec 2021 15:52:11 +0100 (CET) Received: from localhost ([::1]:50320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mx9A1-0001lc-Nb for larch@yhetil.org; Tue, 14 Dec 2021 09:52:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx99u-0001h5-RE for guix-patches@gnu.org; Tue, 14 Dec 2021 09:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mx99u-00005j-IE for guix-patches@gnu.org; Tue, 14 Dec 2021 09:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mx99u-0004PF-FB for guix-patches@gnu.org; Tue, 14 Dec 2021 09:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52470] [PATCH] services: bluetooth: Add missing config parameters Resent-From: Demis Balbach Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52470 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret , 52470@debbugs.gnu.org Cc: dev@jpoiret.xyz Received: via spool by 52470-submit@debbugs.gnu.org id=B52470.163949349916909 (code B ref 52470); Tue, 14 Dec 2021 14:52:02 +0000 Received: (at 52470) by debbugs.gnu.org; 14 Dec 2021 14:51:39 +0000 Received: from localhost ([127.0.0.1]:57912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx99X-0004Of-HW for submit@debbugs.gnu.org; Tue, 14 Dec 2021 09:51:39 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:19834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx99V-0004OR-Vs for 52470@debbugs.gnu.org; Tue, 14 Dec 2021 09:51:38 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4JD1Xz6VyZzQlZ1; Tue, 14 Dec 2021 15:51:31 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minikn.xyz; s=MBO0001; t=1639493489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qyMoIu73UUorUr42rwUMtYOYBdFZE5qDKQyYd5SvXTo=; b=gdYA0J8BiwfqHu9qVW75VtzogYt4LKrg45KwFx+zNqgfAe/6otTNGnFiVENsjXe1kMrRpN TDkWNLdoPl5XuAE6wiAfsF9dHO4x7J1oHl83fjF+cG1lkyP6AEz4RdGwYJP6idOFnx31Fi IMGF/Db/vpmTY212UjWqe3yzm6juqSMS0laCcesVrGcLetmbxhNTxbEO+ufjSC/i8xTpDT sBrPRJTPLWhH0at690VurjEyBBhF7pdakSpkJmig6GOniPIXxoSRSYyghckHPOyMC3KViU XRrZLVCbqgAyN0LLg3uH6hTCZ0YCwjQLriDaQbe3ZhRaU3aYlxSrvop/eze21A== From: Demis Balbach In-Reply-To: <87bl1jfiel.fsf@jpoiret.xyz> References: <20211213192014.8386-1-db@minikn.xyz> <87bl1kthz3.fsf@minikn.xyz> <87bl1jfiel.fsf@jpoiret.xyz> Date: Tue, 14 Dec 2021 15:51:26 +0100 Message-ID: <875yrrqlxt.fsf@minikn.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639493531; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qyMoIu73UUorUr42rwUMtYOYBdFZE5qDKQyYd5SvXTo=; b=jLbjsx+nNPAlY73taqcPlFFvT2/TN0Tv08+dFOg4SA+1Q5Z0hANjnMC0Mt1wkTyiIDE91q Qlcc4cI3QGIB63mY/i6/77866+nWF5/3fw+/R7nQ7qVucaPHUqseeuWeE448BAmqD4SXHP bkf7PGy2QUgSFcsIKtZxJII+yP7jjRK/p/N1FA0XWQ4vgpBGvMysFXIqFHlxTYQTQje1JT TwPL//adzzxXQH8nEPU7UeNWY2U1t6JJhLsvSTfSCqGVgET0pgU2Lx3yPVy1O/pE7w6+ml Ctd5JDDTrYwZFBFEkDstiW2PKokU1ZIbF4Kep+ddyEQ+oiRlgVrBgcPGj1P5Qw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639493531; a=rsa-sha256; cv=none; b=l+jSHI4QBc79GQtxmZqPldYZvruH94m1EL3FMiquCq1CjkHintP2oVjvHXI95WkIYJLVbL TYR7rBma+wz7tlDQyjBhhdBfmUm+N7bFuVyDCkrGyh7tmCJC9vohge0utlwp3buIO+MA9Q 6PO4xcc7w+BdIntil9Q0CLUjJ+fcr9ct969g70Z4jjBNdBdHo83VcuSx/L3wXh+/BTtnsJ 4ValGaJH3ZXpoKVWT7y90zBZrorOKvBIMmqxCxZ2XzRQckTIcvaqztirWV6+qpYuwULnJ6 cyOBoSV5VYi9PXjPReI+smbiWhLLEBUTAS/vswIbnMJg2LgxMCeUXlfkkCf5/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=minikn.xyz header.s=MBO0001 header.b=gdYA0J8B; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=minikn.xyz header.s=MBO0001 header.b=gdYA0J8B; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 77F902803B X-Spam-Score: -4.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: cBrq07gj/jNV --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-12-14 14:03, Josselin Poiret wrote: Hello, > Since Guile isn't typed, the usual approach is to use `#f` for default > values, and then use `(if (bluetooth-configuration-inquiry-scan-window > config) ...)` for example. Any value other than #f will be considered > as truthful for conditionals (see "(guile)Booleans"). I tried that, and I could have sworn I got an error regarding the type. I was under the impression that the default values' type set the type for the whole field. But I was wrong of course because I tested your suggestion and it worked. > Small nitpick, I'd rather have `""`, the else part of this if syntax, on > its own line, aligned with `(string-append`. Please do nitpick. I appreciate it. I think the `[General]` part looks pretty messy indentation-wise, but I don't really know what layout to settle on. > Could you also document the `bluetooth-service-type` Scheme value in > doc/guix.texi, as well as `bluetooth-configuration`, if that's not too > much to ask? I only see one for `bluetooth-service` right now. I'm not > sure if all configuration values should be documented there though, > since there are a lot. Sure. How can I test the changes to the documentation? Like generating a pdf or something along those lines. > By the way, shouldn't `bluetooth-service` be deprecated, given how > simple it is to use the `-type` version? I'm not the one to answer that :) > What do others think? > > Best, > Josselin Poiret =2D-=20 Best regards / Mit freundlichen Gr=C3=BC=C3=9Fen, Demis Balbach --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEEz9zHmXzCRksxyCGU8X3bmMw8QFwFAmG4r24OHGRiQG1pbmlr bi54eXoACgkQ8X3bmMw8QFzkghAAqhYkNa1llPjd4qVKkYBOar+GRsbYtlSsiexK Y75mZpScIG2iaIWMOPMHudiFzJgVIIkEgUqrFp0yjOBDwAvDpXACsLAXu2QCXYq9 UC+EymiPHMVOw138E2jnh+ebOMFIi097hyyrxhlZcUFQiOObvb+jcn2lt/gm9IH/ q+UR6DDpaOl/k/YmRm3m7GXJ+W70TJM86HHOhUXWGSFSRQiI0Kwl2hCFaOPFzPsM uFVEKonFyT/01qRF/ev5bOd3KDa0sB25+DZd/a1+/7ZYPWcdjNSA8N795whPu7tP n1oz7ZavJOlP3PVRajw74xDkvTu/RfbowJQ/ca/C2enmRzjx0LnZpn14xrN01KHL 8igBrFHhXDHYDDPDSBxSfu+FJpTyD5ndabGGy53iJ/k0jFAQ4Ts0r5Nl39sZWlfi IwsBG7qSQ9jhaW35vwIU1RF7eoTNOQtTW9ddxBy6BLoq876/fFOKy9ifp6U8wJNv 6GivDpBLu7CH0EPRx4W+3G8FPSPfternvzBbfWhS0w+kNu5ZJv8HLxjtdw5qe5As ctcY0azxTjRl7+d3yg+Hg96cmrx8T4OJl07rF2QO9r1tzpdWX0PHJ6P+EG0vpNNi AChQ9qZGY7ZghmVsPLorMVZ41HPRzxVHpjq92bxo/cXtDa+6ED7GN3TCFqltY612 yDcjhrc= =S0/X -----END PGP SIGNATURE----- --=-=-=--