From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ONy9FCI7QGNlcgEAbAwnHQ (envelope-from ) for ; Fri, 07 Oct 2022 16:43:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CDXvFCI7QGNroQAA9RJhRA (envelope-from ) for ; Fri, 07 Oct 2022 16:43:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E1942E89A for ; Fri, 7 Oct 2022 16:43:46 +0200 (CEST) Received: from localhost ([::1]:55894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogoZl-0004Fk-4j for larch@yhetil.org; Fri, 07 Oct 2022 10:43:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogmOY-00011a-RX for guix-patches@gnu.org; Fri, 07 Oct 2022 08:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogmOY-0001eX-Jd for guix-patches@gnu.org; Fri, 07 Oct 2022 08:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogmOY-0004YN-DK for guix-patches@gnu.org; Fri, 07 Oct 2022 08:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58345] [PATCH 2/3] guix-install.sh: Introduce 'die' utility function. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Oct 2022 12:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58345 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 58345@debbugs.gnu.org Received: via spool by 58345-submit@debbugs.gnu.org id=B58345.166514539117444 (code B ref 58345); Fri, 07 Oct 2022 12:24:02 +0000 Received: (at 58345) by debbugs.gnu.org; 7 Oct 2022 12:23:11 +0000 Received: from localhost ([127.0.0.1]:34677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogmNi-0004XI-V1 for submit@debbugs.gnu.org; Fri, 07 Oct 2022 08:23:11 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:47032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogmNh-0004X5-Cb for 58345@debbugs.gnu.org; Fri, 07 Oct 2022 08:23:09 -0400 Received: by mail-qt1-f178.google.com with SMTP id hh9so2638982qtb.13 for <58345@debbugs.gnu.org>; Fri, 07 Oct 2022 05:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JgWRf5W6azpLPYkF4uUqdMN7uRuzvHmqaEqCsaCK3I0=; b=RwziynJuZE+tXCq4Aas2nYcrn98PtlYYKiLrukyLyNeIOPptZauohRk2wywTBkBfeV tKZg+Sr+aEu33pFW4frmowIELs3cpIvPktfEkksAl0eop6B7dloIFEYSpO5LEnPGDvs0 t/hvLuUtPfcg245giFj2kTOJPkNiWahec5udqCZGOSTNxckyu2kVda6lREJOO/eK09yo LwFkYE2uY3bpL/y5EiRwrMx3X5eVQIcMZhdlmqBvQliJf+yKDIVd9xrHDueLb/uSoia2 oy0YqW7lq0dwMCzN/1XRXRELiHLd9QvQnNqPe8TATEXjfqtukw47axvg6cJE9FkKG1oE IlMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JgWRf5W6azpLPYkF4uUqdMN7uRuzvHmqaEqCsaCK3I0=; b=h9mKJ3apxaokjShhhx3m/G0uNMXVRuLSuCvbMImBLOaa8vxqchYSEwzWS9gLkYR14a Jo0inugJ3K3p7HhrYaiMaYu3E5RnoVr0A+wwjEBsnsae0a2QzmLQTqUBbQIhQzjsoqKC 8/XNyrEwMXV1MnogUM/1UyFes6RDPwGfA/wxilDXK2a39b0CHOJdhhqiBe2aY4YUZf6J LEftU/qA0hpTtWWnwEamCIxofaSWThaJ5o1bQJung9f0IGrmO9NSzuAlnBUaaXzw+eZD FjIFjVlz6cHoRyM7OSZvajNJD943vrxmphUMdGjedPqOGKRCQ4GuAPTGthWBcKjSWYqb j2EA== X-Gm-Message-State: ACrzQf1ez92IkD25mrR2FDnNbRV/4fN4e8s6v6lDixa4L7KWvgdhTfHZ rZwrtCxOi66nlxsrOTGmK8cr0bt4R9E= X-Google-Smtp-Source: AMsMyM4ty53DIJ5TO1OB3Lg9+FQTc/1qcjNJZYyjqfZbnQCjA9a7+ehIQA01x9LEoA2hqx95SzhlEg== X-Received: by 2002:a05:622a:1190:b0:397:43cd:4ee with SMTP id m16-20020a05622a119000b0039743cd04eemr125846qtk.605.1665145383648; Fri, 07 Oct 2022 05:23:03 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1005]) by smtp.gmail.com with ESMTPSA id v13-20020a05622a188d00b0035a6b89412bsm2036631qtc.46.2022.10.07.05.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 05:23:03 -0700 (PDT) From: Maxim Cournoyer References: <20221007053200.21177-1-maxim.cournoyer@gmail.com> <20221007053200.21177-2-maxim.cournoyer@gmail.com> <87v8owt4qw.fsf@gmail.com> Date: Fri, 07 Oct 2022 08:23:02 -0400 In-Reply-To: <87v8owt4qw.fsf@gmail.com> (zimoun's message of "Fri, 07 Oct 2022 10:30:47 +0200") Message-ID: <875ygv7rh5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665153826; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JgWRf5W6azpLPYkF4uUqdMN7uRuzvHmqaEqCsaCK3I0=; b=bwmc0BdfiEzOtu56mf/kBCg0tBvjyKihr6FvMX8/yX/f1wkw0SfIfzhjYGMBlL1xXB2nD6 OyiVDsLFsIdr6NPOzqY62kiAkwut0Pe32gSZAKgkPguRSX/THV0qaYtLZZQz2TZzFO5ZQ0 GDZmzRtwR8YZ/i2QL0pF/H6/JLY0+DKaoIanU7VzeWjqMvf5n6PeBc73xjQCIupXaBvqbU wVa4h4NXolTVgWmr+Q8q2QGNetw0qYXTQsbiMgC1HL2Y5/IQWwIV32O2SjX9Bl4o2Nh+ZL u3UuGxL5QdAaude5CAALYnCqmatm34HOmr4gbidex7J5oWUMOPE9WLW4GIGAAA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665153826; a=rsa-sha256; cv=none; b=pjC8xq1zuLkGUFTZuH4VKtw/Sal3vWD9D5B+4vjabXZNXk1hWeHZ2MfImG7gOjER+uyCyX k45P7ePTfCEsSv+bZPdTEsx5wKHZ4B2PPV5zgYYIANF4m79++CV3l1JQwlEt1XCXDKLdld kUFuGykCDXGCxsgdFJtK6trHy++b02zBA6P7Nj04JUa2GYaAmdFA0AHGnxnRaj+ODyTGHo o7CxJxOVTxr+RDbb+o6ojP8sRj3OoLcxSP4scPK325OlhB1FuaCjkU7LzJrvsJcD9JuUdQ D1GuDF+cpJNDyZvNGljd+xLbtVbMiR9iioPYkPv0CeCtV+IUAnA7reXojMzuwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RwziynJu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RwziynJu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0E1942E89A X-Spam-Score: 7.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: aLU7D9e3ZYBy Hello, zimoun writes: > Hi Maxim, > > On ven., 07 oct. 2022 at 01:31, Maxim Cournoyer wrote: > >> +die() >> +{ >> + _err "${ERR}$*" >> +} >> + > > [...] > >> - _err "${ERR}Unsupported CPU type: ${arch}" >> - exit 1 >> + die "Unsupported CPU type: ${arch}" > > This new script using =E2=80=99die=E2=80=99, does it exit correctly and r= eturn an > appropriated exit code on failure? Good catch, I had forgotten to include "exit 1" after the _err call in die(). Fixed! --=20 Thanks, Maxim