From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SMtPGrb0R2ObVQEAbAwnHQ (envelope-from ) for ; Thu, 13 Oct 2022 13:21:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EGYbGbb0R2PIpwAAG6o9tA (envelope-from ) for ; Thu, 13 Oct 2022 13:21:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CB133692F for ; Thu, 13 Oct 2022 13:21:26 +0200 (CEST) Received: from localhost ([::1]:41094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiwHF-0003wY-8X for larch@yhetil.org; Thu, 13 Oct 2022 07:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivzT-0006qG-7K for guix-patches@gnu.org; Thu, 13 Oct 2022 07:03:20 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oivzS-0004m2-FW for guix-patches@gnu.org; Thu, 13 Oct 2022 07:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oivzR-00074W-RX for guix-patches@gnu.org; Thu, 13 Oct 2022 07:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Oct 2022 11:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58381 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Graves Cc: 58381@debbugs.gnu.org Received: via spool by 58381-submit@debbugs.gnu.org id=B58381.166565895927158 (code B ref 58381); Thu, 13 Oct 2022 11:03:01 +0000 Received: (at 58381) by debbugs.gnu.org; 13 Oct 2022 11:02:39 +0000 Received: from localhost ([127.0.0.1]:59718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivz4-00073y-Pl for submit@debbugs.gnu.org; Thu, 13 Oct 2022 07:02:39 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivz1-00073j-8a for 58381@debbugs.gnu.org; Thu, 13 Oct 2022 07:02:37 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id F287027BBE9; Thu, 13 Oct 2022 12:02:33 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d86f6a58; Thu, 13 Oct 2022 11:02:33 +0000 (UTC) References: <87r0zil1bh.fsf@ngraves.fr> <20221008163932.15808-1-ngraves@ngraves.fr> <87pmeyab3i.fsf@cbaines.net> <878rlmwo2x.fsf@ngraves.fr> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Thu, 13 Oct 2022 11:58:31 +0100 In-reply-to: <878rlmwo2x.fsf@ngraves.fr> Message-ID: <875ygo7zqw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665660086; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=c2R34Epg5QPfSe9hBviw0XPO8VVNEAUL3wGiSN07pBw=; b=u9nMHqPQLdTfBfCHWuqamgD4GrK7ThAoTEE6CZbBGod0FlSZiyxg0Snpr/vafsOXAOxmmU SHIllwUzNIEUSYV5+4ERA2GcRgnt3kcWjTFLDaFzcZR30qxeNuHqMl6mBSEoz4L/+TIKPn HZHFHgP1YbIPhUWbaUW5b8EF5IpDo1tsYUW2xifV7krZ5FTwcXeOi0aI1QmV+uXwLUV+sP /jONjAaVGJSQd+k54JsExe0cbb1V/ESjuvdiORC2W+ouhFh4+F8lOfg0wI4KXuS8pn2pTd 0Us0HUY5ga/ml+r0EfwMdLjoRLN+pmWz1ug80F/0UjwI86Uz0+LNw3ig4uKbpg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665660086; a=rsa-sha256; cv=none; b=d30kpId4QANfMXlyEoVifTX/0Vehx6QquWCXeeM+HBWfvchyM0NgNmSmo44nabfMsapkx4 NYfYsD5/WY5bavaJWkYnmXgJONLsLqgRsLghobzaLerLStIDw948cUSXfPYrTXug+k1MGz /e4Nb/oq/3PH3iMQxcY9NkPrQZYRm9Tpds3YBaOwrFwvzKQVFy5iiHBxbX9Gj+1g8Q64bM H7J0WR7EpGbCB9I02g2NxsSE3iLTX3wr1KE3xMiKP9ZCbMqitpGkXifT7VJLH5nAwGz4gB 4GzDFMBa46rVhI1woWGqLAWlowMflm/zrbieQ3l0LBz6k7Xr7IaIwut03Mq17g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2CB133692F X-Spam-Score: -4.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: VNVJKzoBW4g4 --=-=-= Content-Type: text/plain Nicolas Graves writes: > On 2022-10-11 11:48, Christopher Baines wrote: > >> What relation does pcsc-lite have to this package, and why does it need >> to be propagated? >> >> If this can be avoid, that would be good. Otherwise it would be good to >> mention why the propagation is needed in a comment. > > For piv-go, in their README: > > To build on Linux, piv-go requires PCSC lite. To install on Debian-based distros, run: > sudo apt-get install libpcsclite-dev > > ==> So probably no need to propagate here. > > ---- > > For yubikey-agent: > > The package relies on pcscd (daemon) to run on linux, which is already > available in guix. Maybe it's better to say that in the README ? Instead > of the package, what it needs is actually the service. > > I've also written some tested lines for a yubikey-agent > configuration/feature (as done in the RDE project) shepherd service, > although as it is really tiny, I didn't know if I should've contributed > this. > > It looks like that, and did work (it also depends on the acceptance of > the patch https://issues.guix.gnu.org/52900 in this case): > > (define* (feature-yubikey-agent > #:key > (yubikey-agent yubikey-agent)) > "Configure Yubikey-Agent." > (ensure-pred file-like? yubikey-agent) > > (define (get-system-services _) > (list > (service pcscd-service-type) > (udev-rules-service > 'yubikey > (file->udev-rule > "70-u2f.rules" > (file-append libfido2 "/udev/rules.d/70-u2f.rules"))))) > > ;; (define (get-home-services config) > ;; (list > ;; ;; MAYBE: It should be installed system-wide? > ;; (simple-service > ;; 'yubikey-agent-add-yubikey-agent-package > ;; home-profile-service-type > ;; (list yubikey-agent)) > ;; (simple-service > ;; 'start-yubikey-agent-at-startup > ;; home-shepherd-service-type > ;; (list (shepherd-service > ;; (documentation "Run the yubikey-agent.") > ;; (provision '(yubikey-agent)) > ;; (requirement '()) > ;; (start #~(make-forkexec-constructor > ;; (list (string-append > ;; #$yubikey-agent "/bin/yubikey-agent") > ;; "-l" "/tmp/yubikey-agent.sock"))) > ;; (stop #~(make-kill-destructor))))))) > > (feature > (name 'yubikey-agent) > (values `((yubikey-agent . ,yubikey-agent))) > (system-services-getter get-system-services) > ;; (home-services-getter get-home-services) > )) > > > I'm not sure what would be the guideline here regarding doing or > avoiding propagations. WDYT? (I'm sending a V2 once I have a clearer > idea of what makes sense). I'd try avoiding all the propagated inputs and then tackle the issue of getting the service working separately. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNH8EdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xcpvg//Tj7H9Ll1ouz0bXBAsI8mWMzXMZpZQcE4 yD+jX1EznF+nF4eDSAjyrI0Caf+L9I5WicpWERfuBTFZAQ73bUHJPxwOczf4/ULu ycbqpE4VITap5IDqPHSf9P34qkc1GBtJTUPX3Q/z9ACbLxgzvJY3K3Eg45trXm/d CG3KHnxM3meFWd1D4zSnisUoBk80gJnFT4iLyl5vdJ018CawzWPhPL4gOfKzPwPD OWeLoITtfcYR7OqU2jM4wQoWaSTZp0x441Upt9jWxedtd9Yd+R40b5hMXIIv7dsp b93ys0pW4RxpOnWtN0kHAH7ro5zJleyMGCfYpjW7bcmd0EIY+S9B6PB245sH+p/g 2ANg9i2rPM2hRHMeotYCOtw+Gg70zqRGvzHlCky2arm18UrAuH14tJmknSCCd5RH KODVtW1Rgm0d3mdI67RNGMokhflO5Lfp/NySOCfCHrPz48d932BF0xWqmRSBnuTA ZTAPbx6yhB8bTtXulb5fGnswGq76QzuKvEX44+m9PU1dBW128bd96lkxPVv8yXQA na38stuFyf74emQr9NOZDdN9Clm2Tn9b+2QNHGrv2VqebcbGEWG0U+OupwfPCcCJ FoR/MufQCht6FIGyeY7URCcT1lHh0BwFypsRzYgtnAqmX45gQSN4viPt0r+PWbz5 iRGCdm2KsYg= =YbN1 -----END PGP SIGNATURE----- --=-=-=--