From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 30948@debbugs.gnu.org, Carlo Zancanaro <carlo@zancanaro.id.au>
Subject: bug#30948: [PATCH core-updates] guix: Reap finished child processes in build containers.
Date: Sat, 26 Nov 2022 16:11:12 +0100 [thread overview]
Message-ID: <875yf192en.fsf@gnu.org> (raw)
In-Reply-To: <87cz9cnvys.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Thu, 24 Nov 2022 11:44:27 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>> My view is just that this mechanism belongs in “user code”, not in the
>> low-level mechanisms such as ‘build-expression->derivation’ and
>> ‘gexp->derivation’. It’s a matter of separation of concerns.
>
> Why? On my Guix System, such signal handling is handled by Shepherd, if
> I'm not mistaken. As I user, I can trust the foundation to be sane,
> rather than having to provide the bits to make it so myself.
>
>> Of course we don’t want to duplicate that code every time, but the way
>> we should factorize it, IMO, is by putting it in a “normal” module that
>> people will use.
>>
>> Putting it in gnu-build-system is an admittedly hacky but easy way to
>> have it widely shared.
>
> I think we can do better than hacky here :-)
I think the real issue here is semantic clarity when it comes to
derivation inputs.
If I write:
(gexp->derivation "foo" #~(mkdir #$output))
I can be sure that my derivation depends on nothing but (default-guile).
This is important for tests, but also to make sure we can use this
primitive everywhere—if it pulled in the Shepherd, I wouldn’t be able to
use to build glibc, because there’d be a cycle.
In that sense, having child-reaping code in gnu-build-system.scm, just
like in (guix least-authority), doesn’t seem unreasonable to me.
That said, I’m open to other proposals so please unleash your
creativity! :-)
We’re touching core components though so this will require discussion.
Ludo’.
next prev parent reply other threads:[~2022-11-26 15:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:16 [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers Carlo Zancanaro
2018-03-26 23:39 ` Carlo Zancanaro
2018-03-29 20:07 ` Ludovic Courtès
2018-03-29 21:15 ` Carlo Zancanaro
2018-03-30 8:16 ` Ludovic Courtès
2018-03-30 11:17 ` Carlo Zancanaro
2018-03-30 15:17 ` Ludovic Courtès
2022-11-24 16:40 ` Maxim Cournoyer
2022-11-24 16:44 ` bug#30948: " Maxim Cournoyer
2022-11-26 15:11 ` Ludovic Courtès [this message]
2022-11-27 3:00 ` Maxim Cournoyer
2022-11-28 15:04 ` Ludovic Courtès
2022-11-28 20:10 ` Maxim Cournoyer
2022-11-29 2:07 ` Maxim Cournoyer
2023-12-17 20:23 ` bug#30948: [PATCH core-updates] build-system/gnu: Turn PID 1 into an “init”-style process by default Ludovic Courtès
2023-12-17 21:46 ` Maxim Cournoyer
2023-12-18 17:46 ` bug#30948: [PATCH core-updates] guix: Reap finished child processes in build containers Ludovic Courtès
2023-12-30 3:36 ` Maxim Cournoyer
2023-12-19 22:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yf192en.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30948@debbugs.gnu.org \
--cc=carlo@zancanaro.id.au \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.