From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Jk4MfLQsmOwNgAAbAwnHQ (envelope-from ) for ; Mon, 02 Jan 2023 13:41:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wP1mMPLQsmPp3wAAG6o9tA (envelope-from ) for ; Mon, 02 Jan 2023 13:41:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 906E91E393 for ; Mon, 2 Jan 2023 13:41:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCK7f-0000oZ-HF; Mon, 02 Jan 2023 07:40:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCK7d-0000oQ-70 for guix-devel@gnu.org; Mon, 02 Jan 2023 07:40:57 -0500 Received: from sender4-of-o50.zoho.com ([136.143.188.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCK7a-0003el-Oh for guix-devel@gnu.org; Mon, 02 Jan 2023 07:40:56 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1672663248; cv=none; d=zohomail.com; s=zohoarc; b=L4eVJB0b+S9oymaZxw0cjhRqW3rnIHy+GcyLcMFGPdnO0Al6YgkzKQKWvGOSFa/bqauUXQAoJy6UFXkasgdlM7mL9W7aAA+3S9aVshT3I+3Isv0C4j7Ul+ckAQk4yCo8aZI56xwWalR3WIbQJ1lX2a+zaN64v04H/p/L/6n2sR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672663248; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Iom5tkDzS1leBK2u74mPA4P4/EAESAQzIj1XLCPIkKM=; b=Tuv5n/1vLxOLIVxFFl6uWxulnUrrbKN+3x+znPSsbyqifMd7pRfInmEp3BqqG6a9Mq25vYjUehX0Stja9qz3/3i8YnJuhwAB393JU2ugT2JlA/8XnYNfF0USHFtX2+Ah4B4SwxmrnPhOvo8MG2sgIupS+xyBhb28M1Cotb7qEzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672663248; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Iom5tkDzS1leBK2u74mPA4P4/EAESAQzIj1XLCPIkKM=; b=E2naom0JZyPZX8bLjcl/KAc520D34I4OnKJ7fHguOOAsDdRShmaIBWTjYvUBts70 ICfWEnflVujOFGsVamAY9/Fo26tqpepN/S8RRfrm+m96AiD/ErWQLfgH/w46S2WuLFn WRqqR4xI607YBQ+BQ5pSByizGI1wj42NUIsfqjxA= Received: from localhost (75-111-142-46.pool.kielnet.net [46.142.111.75]) by mx.zohomail.com with SMTPS id 1672663247591833.1691197081891; Mon, 2 Jan 2023 04:40:47 -0800 (PST) References: <874jtb7icl.fsf@elephly.net> User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus To: Hartmut Goebel Cc: guix-devel@gnu.org Subject: Re: All updaters are broken Date: Mon, 02 Jan 2023 13:32:44 +0100 In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <875ydp5ctv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.50; envelope-from=rekado@elephly.net; helo=sender4-of-o50.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672663282; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Iom5tkDzS1leBK2u74mPA4P4/EAESAQzIj1XLCPIkKM=; b=LXV/UX501PGvIJtoeBiQHF9Kj9OyOcheE20hzMF9M8qKnQlepprkRpVd8Ax0gqyFi5Njt7 7BKAr71u8e483Ki7xcpvwsoIO/H+bZg7ZahCxx2dOiJp1K9oHTl4SDmtnYK1tUdl9KTXfQ jmv4d15kVlBBoZS9d3DzYlDnvwYJhpXpuWAGmqZO2OnNtZSsWxB6kFRDdTjz4V/xH6z3xH /3bwwPejaxUxTrMjNDRLseYHh85JwCoGr1UqwvG0DthcnQseOFSVPRzamPn/EfatRyuwih KGBwZ+daPTmX0PwYaPK+KKIaYnNnv+FcNpMIknsTp/tmGOZOhtk2TeDM+LK5pw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=E2naom0J; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=2; s=key1; d=yhetil.org; t=1672663282; a=rsa-sha256; cv=pass; b=YYzCz7lG6n+/3flIXn1HpdrDl9JvQP6L9sxzRZLibElQ4H3KJEXHS96V3AF8Uji7ECyLu6 xmwxNWIPgPo3VgxFj3iLSyOF63AMb6cgRkd6JAWU+/QrANhd8MXI2iPZ5/onl+DuGXSaV1 Wl6SZHISwbhn+NG+7eZitxiX8MXVv6acnuJGcdvb++AOyqhfxPhgCLKM9hJpkgpno2IkEZ 4NSjWZCw/oSDIYwrc0HrewwomxWo7b+MQCWsQnqmHOSG2oH7BtfzzmrXhAqTPTn56ozQFo zjG2rluU0eKtSIv/MVXAAfk3iMERlrUK6BbSrX5S5gogfAGMGuLId+bo7aROoQ== X-Spam-Score: -6.55 X-Migadu-Queue-Id: 906E91E393 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=E2naom0J; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.55 X-TUID: MJ3Pw1FtbkJi Hartmut Goebel writes: > I managed working on this this evening already. Thank you for taking the time! > Am 31.12.22 um 15:27 schrieb Ricardo Wurmus: >> Commit 8aeccc6240ec45f0bc7bed655e0c8149ae4253eb seems like the problem >> here. Hartmut, can you please fix this? Otherwise I=E2=80=99d like to = revert >> this and related commits ASAP. > > I fixed he tests and pushed as d7a9d72bb02a2a3b1a99183655bf878547116032. > > Regarding the command "guix refresh": According to my tests only > invocations not providing a package name failed (see below). Anyhow I > did not manage fixing this: > > options->update-specs need to return update-specs in all cases, and > currently returns packages if no packages have been named on the > command line. It also returns packages when a manifest is provided, or when an expression is evaluated. All the internal procedures also assume that we=E2=80=99re dealing with packages here. The only special case is in =E2=80=9Cargs-packages=E2=80=9D where =E2=80=9Cupdate-specification->update= -spec=E2=80=9D is used. We=E2=80=99ll either have to wrap all package values in (update-spec pkg #f= alse) only to unpack that moments later to get at the wrapped package value or dispatch on the return type of options->update-specs (possibly after renaming it to make clear that this returns or values), treating values differently from values. It=E2=80=99s a bit messy because options->update-specs is poorly typed now.= We could also have it return a compound value (or a union type) with a list of values and a list of values, and process the components separately. --=20 Ricardo