From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SNl2IVslsmNRbQAAbAwnHQ (envelope-from ) for ; Mon, 02 Jan 2023 01:29:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QNZUIVslsmNw7AAA9RJhRA (envelope-from ) for ; Mon, 02 Jan 2023 01:29:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3B0A975F for ; Mon, 2 Jan 2023 01:29:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC8hL-00073d-RR; Sun, 01 Jan 2023 19:29:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC8hK-00073M-C4 for guix-patches@gnu.org; Sun, 01 Jan 2023 19:29:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC8hJ-0000aR-Ti for guix-patches@gnu.org; Sun, 01 Jan 2023 19:29:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC8hJ-0006mL-PM for guix-patches@gnu.org; Sun, 01 Jan 2023 19:29:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60224] [PATCH 0/9] Improvements to our u-boot tooling Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Jan 2023 00:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60224 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 60224@debbugs.gnu.org Received: via spool by 60224-submit@debbugs.gnu.org id=B60224.167261928225967 (code B ref 60224); Mon, 02 Jan 2023 00:29:01 +0000 Received: (at 60224) by debbugs.gnu.org; 2 Jan 2023 00:28:02 +0000 Received: from localhost ([127.0.0.1]:42039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8gM-0006kc-AS for submit@debbugs.gnu.org; Sun, 01 Jan 2023 19:28:02 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:35671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8gK-0006kJ-1f for 60224@debbugs.gnu.org; Sun, 01 Jan 2023 19:28:00 -0500 Received: by mail-qt1-f173.google.com with SMTP id h26so21475115qtu.2 for <60224@debbugs.gnu.org>; Sun, 01 Jan 2023 16:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=7r0C5DKD3jPh5WQGJcj3Hp1yaCD+OUARAreqsh+jbd4=; b=Vjz4Vrl9NXmUfIAK/IbylMXlEGvjKiTvWNtR5/UrUGGCylQxKA0HH6qIbv9/uxDJZ6 nYcNUVf5L195DdSVuBO7odZACE5POi+N15Jz6QTRo5xf9HXsQC6TP34JuO5cG+eYrBSc s/yAlzmASkt07Ve1UR2pt6s67CJUmayhEaKAQaxTJ2TfbkBgV/HzxX+7yfIvJBAFsR+m aldAjUeyiyD+QJ8uzJJPiN1JA5qb9b6Wyevz1QLlHHWqOdM4aXyPC0fYbPLADWOwY8wV mhE/ldjeHvhY+Bqmu4+903leKg9ctzv67DI1CtDOFq2DnnlBUvIjqu3Kx56ZxcopM5jV wATg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7r0C5DKD3jPh5WQGJcj3Hp1yaCD+OUARAreqsh+jbd4=; b=VLjrmcusxqAeMFHhYCESobs2pSn+ru51iCKLH4flC2MC23tGxvPr7vj7e+4Zljdgpt SeREDHAMnTPajYQBvsJ1TTOIWlCKpGef/7qBT6qdHpHyr+/YY2K7mpmpT85HZsDxOgwy BtIwx5BHrTZh61IvfaocslEmNkPBIYIYJOkq9QdHiBCc3iRZw9thJeHNAvr+DJRpUApv nWSwUgVAhVdeQjgv/UcpCBbUUJCNWGN0G+zyt//GqPQ2PbCy2pW2uahsOjVg+R3iTU1F ykYOnLTEDB5SgrJp/PPozwuhB9jBCtIYMF6sT2LxyUt94JQotqFU/A2E7kE35WpPpzwm d+pQ== X-Gm-Message-State: AFqh2kpMK3L2peN8N8a98COiWW2QtFjm8AAs/UIhc2Eqt6BbqzsENiQK WU8rDmCla8R/mcaR0NPaSdZT7tqPyDJiiQ== X-Google-Smtp-Source: AMrXdXvnq+X5aBdT59L7KLysZba1RONYlWrY273Dq9FxlCQ2M1cnYt0VdYJ9Jqb40YZU6qwJ6FEOVg== X-Received: by 2002:ac8:568a:0:b0:3a6:348c:5159 with SMTP id h10-20020ac8568a000000b003a6348c5159mr47227398qta.26.1672619274425; Sun, 01 Jan 2023 16:27:54 -0800 (PST) Received: from hurd (dsl-10-148-224.b2b2c.ca. [72.10.148.224]) by smtp.gmail.com with ESMTPSA id t1-20020ac865c1000000b003a7e4129f83sm16436302qto.85.2023.01.01.16.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jan 2023 16:27:53 -0800 (PST) From: Maxim Cournoyer References: <20221220165038.25114-1-maxim.cournoyer@gmail.com> <875ydu9fch.fsf@elephly.net> Date: Sun, 01 Jan 2023 19:27:52 -0500 In-Reply-To: <875ydu9fch.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 29 Dec 2022 20:18:57 +0100") Message-ID: <875ydp4w6v.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672619355; a=rsa-sha256; cv=none; b=fVS152vbOzaZu/DO5kCLFgJUSdvQcScXZFDdqE9v7x6Ur0tr9Kqmw/8JAsSkqXqW5IJpzZ hCxpw7Pwk++mlyhTB7Wy5dNRdETeKOFLnZGwLuE3miY/CdNdT6QOvlKjqObYD/d72i3JQZ nK308kmhK6dtp0Eu6GLXVQlnLFaiMHWJMtG7ST1uJUExX/8M7odmI+fTPK2mvBXkcwHzz2 biTy5evgl8CDR+7/7ePTPWToQrpAumxFdZnJQOJQTMm1SpONWlYPJrwOe/GJ3NTCQzlLbe jDpFNhTmYiL8lZljOgPpif56xGv8Vcdnei0YGUsrc3yCraUX5KSH6Pj4/8FsCA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Vjz4Vrl9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672619355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7r0C5DKD3jPh5WQGJcj3Hp1yaCD+OUARAreqsh+jbd4=; b=Nnbb2zYg0Wb2gJHY0BmvGtF4nktoRdjDfle0HdnCp5ST4g06IuPFJm6iy5LoHlww85sHtl 1wsjWi4SyoWA7Ag4NjEC5H3W71eN8WVWtyq94hYnAM5i5Imdb445M3sTF0EAI7Tb1IcSqV nUCebdRIRi+yGCDLxuwtWV+h0LbJ5gO9Ag+aRBvS7COTlqO02Or3R2UO7n9zn2h1YPhcRi 6+BfiE7MjLYdW3IorkmFnrm47nhTiLlp1ImEyqo8vvpTQrQ2yc2wyo+mNWaQdRrFP7Qikb f2wIYl8uY21H5ysN6z0FwAkhwGEYLm13NPvvRRhFhlK0mkVveqYgPwDlMsR5dQ== X-Spam-Score: -3.55 X-Migadu-Queue-Id: F3B0A975F Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Vjz4Vrl9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.55 X-TUID: 20gux8+8+2wh Hi Ricardo! Ricardo Wurmus writes: > Hi Maxim, > > this looks reasonable to me. Some comments below. Sorry for the late reply, it hadn't reached my INBOX (please keep me in CC to ensure it does :-)). > A minor comment about the first patch: you still bind =E2=80=9Coutputs=E2= =80=9D in the > build phases, but since you=E2=80=99re using #$output anyway this value i= s never > used. Fixed! > [PATCH 3/9] introduces a comment in the definition of =E2=80=9Cnative-bui= ld?=E2=80=9D, > which references %current-target-system, yet only %current-system is > used. Is this a mistake? Fixed! > [PATCH 4/9] =E2=80=94 This one appends arm-trusted-firmware-rk3399 instea= d of > prepending it. This differs from how it was done with the labeled > inputs. Does this have any consequences? Is the =E2=80=9Cfirmware=E2=80= =9D label used > anywhere (such as downstream packages)? The same applies to patches > 5/9, 7/9, and 8/9. I don't think it matters; the base u-boot package which gets used doesn't include any "firmware" input, and the file provided via arm-trusted-firmware-rk3399 is searched via "search-input-file". I've grepped for 'assoc-ref.*"firmware"' and there doesn't seem to be any remnants except for u-boot-rockpro64-rk3399, which I've now fixed in the last commit. > [PATCH 6/9] =E2=80=94 The change from .bin to .elf confuses me. Is this = due to the > fact that =E2=80=9Ctarget=E2=80=9D is now actually set and the package bu= ild thus > behaves differently? I think so. I was puzzled by it too, especially since some packages already were searching for a .elf file rather than a .bin file. > [PATCH 8/9] removes a reference to =E2=80=9Cfirware=E2=80=9D; this answer= s my question > to patch 4/9, but perhaps other such references remain? Answered above. Thanks for the review! v3 will appear shortly. --=20 Thanks, Maxim