From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iDu3EdaUvmMyFAEAbAwnHQ (envelope-from ) for ; Wed, 11 Jan 2023 11:52:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wD3DEdaUvmMRvAAA9RJhRA (envelope-from ) for ; Wed, 11 Jan 2023 11:52:06 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 411C9280E0 for ; Wed, 11 Jan 2023 11:52:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFYht-0002Vm-7E; Wed, 11 Jan 2023 05:51:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFYhD-00020d-7k for guix-patches@gnu.org; Wed, 11 Jan 2023 05:51:17 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFYhC-0001HA-T3 for guix-patches@gnu.org; Wed, 11 Jan 2023 05:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFYhC-0008UX-BK for guix-patches@gnu.org; Wed, 11 Jan 2023 05:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Jan 2023 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: zimoun Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167343420732548 (code B ref 59513); Wed, 11 Jan 2023 10:51:02 +0000 Received: (at 59513) by debbugs.gnu.org; 11 Jan 2023 10:50:07 +0000 Received: from localhost ([127.0.0.1]:41766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFYgI-0008Su-Fh for submit@debbugs.gnu.org; Wed, 11 Jan 2023 05:50:06 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFYgG-0008Sj-Oz for 59513@debbugs.gnu.org; Wed, 11 Jan 2023 05:50:05 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 3E3A327BBE9; Wed, 11 Jan 2023 10:50:03 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 184e4e2d; Wed, 11 Jan 2023 10:50:01 +0000 (UTC) References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> <868rih9wfi.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Wed, 11 Jan 2023 10:48:29 +0000 In-reply-to: <868rih9wfi.fsf@gmail.com> Message-ID: <875yddfiqw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673434325; a=rsa-sha256; cv=none; b=hi8hDE3FXR15W6NpS9IIiKexH8RkEDDQKV12EFS5A/gkHLzKAdfZfA7/gtmvbGdbaWXIP0 2/cseKMbF+aaw41mkEvOznWIXGfl0AKmsNDiJTU9sffeof0BBsG2M82p9MWizEoKJTj6+A EJevt0E4xOU5hzTx8p81eyfM920/g5ngKA3a3daDgMZ5X/rcdbZ0kyfgqXdx558d2ozKa+ Ka3pY5nSHHrkvkiPTr9LrPQrY8OjnLFAbFccIj61aw2NM3SuKeiPANKzIPwf0jOvl558kO oeyprG9L4Wdinwg5V7sotJM2HRTEcEvjpQEdeYuvIK4bXVFdt9Kl85buH76k3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673434325; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=mLlcct9dlLDTRavEb7rpodDVGDuewwriI96OO9EUjcs=; b=GRoKzvKgQ4bRbPeRIa660J7apUizA8wsLzLwvfynwK4//zUg0Rs3DNb+hr8yf0t1rlSNCV lo1yo9LZmgzscG5fLx7fJ70CvnlJkfLgPrF8z+LmNQYPOKqSpzrfRWTWlCAmtE0SyBwCLh 2PEsi9B1dU27KM7Z3exEn6xFS+ynKsJlQMQb1Q8fCTMmfCw9In04qKfGh18QP0JH+PZe9T m2yThyULO16y6mJ5EitJscVNL9bw+U1s5kYT/fG0UA/Om7/5zvvyb0tE/vZpgWLhvormWH RQx39D1jRudZj6PmSmZZVNdi85OBSg1l/QwkXDkm/yUtHlImwQ2GRFjVjw44Yw== X-Migadu-Queue-Id: 411C9280E0 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -4.69 X-Spam-Score: -4.69 X-TUID: B47MDxkpfjM/ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable zimoun writes: > Hi, > > On Thu, 08 Dec 2022 at 11:20, Christopher Baines wrote: > >> Add more examples of when it can be appropriate to push changes without >> review, as I think this can be appropriate in the case of trivial change= s (as >> mentioned before), but also non-trivial fixes. > > This would be part of the commit message, right? Yeah, this is the commit message. > I would avoid the personal =E2=80=9CI think=E2=80=9D since it is a collec= tive thought > with some consensus (I guess). For instance, > > Add more examples of when it can be appropriate to push changes without > review, as in the case of trivial changes (as mentioned before), but > also non-trivial fixes. It reads better to me with the "I think", and since it's my name on the commit, I've left it as is. >> No longer suggest pushing simple new packages or package upgrades (that = don't >> cause lots of rebuilds) without sending to guix-patches. Now there's some >> automation for testing changes sent to guix-patches, sending changes the= re >> before pushing can mean that more rigerious testing takes place and help= speed > --^ > typo > s/rigerious/rigorous Thanks, I've fixed this. >> +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing >> +list fills the patch-tracking database (@pxref{Tracking Bugs and >> +Patches}). It also allows patches to be picked up and tested by the >> +quality assurance tooling; the result of that testing eventually shows >> +up on the dashboard at >> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where >> +@var{number} is the number assigned by the issue tracker. Leave time > > To be consistent with (guix) Sending a Patch Series [1], I suggest to > use @var{ISSUE_NUMBER} instead of simply @var{number}. > > 1: Sure, I've made this change. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmO+lFdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XenLBAAg2HAu57TKdrOJckRYW7fl7y0Lp8blN5I NZETJvJjBrIN/LENnsH1dT7FiILWfwkgDCPw8aCFw8IPs94w+NWlkyJj0ZKRtUdW lM/ZBBNGWW4geNPgrLZrqoHdToBQO3R9j9ycOsrvDqLWiEGGy5vhcWvK06umTZUa 3gLmnIlyU23bQ3rRokIveb3GnW7Nd3UX1p/NHNZOxfPCc3xtMf/dy7iN+VhvZ0zH pJti4N1UwShlO42iunaTHFUTmJwBe5/PHzgTluII4lyUbIJqkqBZL+aBIh5oST4P 3OqgMUx8l564KHmlO+3q/SyuK6mgocCO186BhfopPNt1IBaA5SxIg/877Q0QJjRL dQiIbkowkVpppXKP0lJ/TCcI1TubJ/VtlZnPcyn240mPpNmT7PPA0Is1ehVbpCp6 bApdgrEJbiDHYpaJaKCXkLnOFSRi5JXcpJ03D9Xa4gELhjCgx2B/0v6uBM8G6HCD dwAPPesfaD3C9WKc0kqtSwMElKUPO8U+4JfMUObPcGOzaH+lqsVenNfJ3LSknOS0 jHCD1w4sNLRkItNRVxzd9YEhv+UWC5FQ9OGrgJ6VMKcB9GeUa8+G8XJF+3yuKg+E MZjzr3DFgFIPJ/eAvdkqkxi1yX9AsxDz+i3vVwXcGKqD6ES/RVZgS0sUxsqwfLN6 Pt77E28Vtas= =DJiS -----END PGP SIGNATURE----- --=-=-=--