From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WGfJDTRR42Pu+gAAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 08:37:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cLQADTRR42NPdgEAG6o9tA (envelope-from ) for ; Wed, 08 Feb 2023 08:37:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C547CC438 for ; Wed, 8 Feb 2023 08:37:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPf0r-0003B3-H2; Wed, 08 Feb 2023 02:37:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPf0q-00039i-7G for guix-patches@gnu.org; Wed, 08 Feb 2023 02:37:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPf0o-0007k5-LI for guix-patches@gnu.org; Wed, 08 Feb 2023 02:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPf0o-0005gp-79 for guix-patches@gnu.org; Wed, 08 Feb 2023 02:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60673] [PATCH 01/39] gnu: Add ocaml-domain-name. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Feb 2023 07:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Csepp Cc: 60673@debbugs.gnu.org X-Debbugs-Original-Cc: 60673@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167584178321786 (code B ref -1); Wed, 08 Feb 2023 07:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Feb 2023 07:36:23 +0000 Received: from localhost ([127.0.0.1]:54613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPf0A-0005fJ-Q0 for submit@debbugs.gnu.org; Wed, 08 Feb 2023 02:36:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:34328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPf09-0005fC-Og for submit@debbugs.gnu.org; Wed, 08 Feb 2023 02:36:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPf07-0002eg-Fy for guix-patches@gnu.org; Wed, 08 Feb 2023 02:36:21 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPf05-0007YX-Qg for guix-patches@gnu.org; Wed, 08 Feb 2023 02:36:19 -0500 Received: from localhost (unknown [IPv6:2a02:1808:280:f63d:f055:17e:cfb4:3]) by mira.cbaines.net (Postfix) with ESMTPSA id 7D09216CFE; Wed, 8 Feb 2023 07:36:15 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 3730aaed; Wed, 8 Feb 2023 07:36:13 +0000 (UTC) References: <20230109003529.23375-1-raingloom@riseup.net> <874jrxdhxi.fsf@cbaines.net> <87wn4t2aik.fsf@riseup.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Wed, 08 Feb 2023 08:32:28 +0100 In-reply-to: <87wn4t2aik.fsf@riseup.net> Message-ID: <875ycc8v82.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675841843; a=rsa-sha256; cv=none; b=rdjAWRBAiKZ/NOmFYhTNSKVqayla0zWkB9iseqhD2WTemsJY8jCTcGLqZVaSlmsATnv7So lvCL/Fx2s3PWGszqhHYHRq+IAFD0tOcC7ZXWsCk3lSOQp6n+nbQ5cNmvRfTXQaZxWB6h5o jdkOKJo61xM4daaaMD72O1PefnZLe+taKXWzgEQhyDdJhcSGBYeqaLVVZysvySfLhAk4Vl qPiAmR8oePtRquDK+fRdDaGuzSdo8oXD0X3B88HPrwIs9+8hbzJuyCeUkAv912RjDA3+zi RUnQG7pTMtaZucxAagEkhqpN3LCeYzY81/rbSXJaP4SiOtZon1rM8zZKi7XATw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675841843; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+i8QMnm5jTQxOQkn2v3pbv6xLTH+w00qWFAgqfoOtRY=; b=JLTTT+tyi9A5rwjiGoTB7HqLHa12mdygaPYkLoa/Ggh8fQuCvkzgybtF9t63B/j+IXSaVM I+DvJU1O9XFO6seDsFxx/7UamH8iq2TZ4nmz1+bLuusuoNDY1cyBQXiXq811SN54/Q6qcY Jk2zbGT8RHh5xPLaanuHpiYpoB2LjyjBvG8eWj7MBTd/gVptldy1cvEa4qynAO2IDDWhFE b+BTXUoavYIcJmgXj9L3p9RHJUogp0yK7l+qUJ+qFLXM3X1GCUxJ87d9MAGZh/thOlHCPC Jy4XL9y14cV3g59YLk5FI+XJnrlBBH4mPb/W3eHmfQeCS8HQtbA3gg9w9eVrFA== X-Migadu-Spam-Score: -5.39 X-Spam-Score: -5.39 X-Migadu-Queue-Id: C547CC438 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: FfEAIPZykE3z --=-=-= Content-Type: text/plain Csepp writes: > Christopher Baines writes: > >> [[PGP Signed Part:Undecided]] >> Hey, >> >> While I think the builds look OK for this series, there are quite a few >> formatting issues raised by the linter (this can be seen on [1] and [2]). >> >> 1: https://qa.guix.gnu.org/issue/60674 >> 2: >> https://data.qa.guix.gnu.org/compare?base_commit=238f965c331990459a69cbc713ca951ad40e6044&target_commit=3b5485b9cdaebda127dc040ad67a287f39e33519 >> >> Could you run the linter on the packages you've added here, address the >> issues it raises and send an updated series? >> >> Thanks, >> >> Chris >> >> [[End of PGP Signed Part]] > > Those are all URL constants, can't really do much about them other than slice > them up with string-append, which I'm not sure really helps with > readability or ease of editing. They were not an issue while I was > editing the code and gnu/packages/ocaml.scm already has a lot of lines > that whitespace-mode highlights as too long, so I thought it wouldn't > matter much and my time would be better spent elsewhere. You're right that there are quite a few other instances of lines that are too long in that module, but I don't think that's a reason not to add more. I think splitting the long URL strings with string-append is a good approach and can help with readability. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPjUO1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeNng//QEGLBpjKu9K+4epn0c3gYLpHC0shKrIC fpgtFwe7pvAz2+vXKziNhkEU2EU++muR8ELHSyOaCum3lR3neGX3TiYhWXI9h0qp yBCYnhM1GLLzbie43ntklU3FdL59P5XuLM8B7HL5Pkdm5wk/DXc0q4wcQz/r/dfs 9oCKeUgGz8xukGv/sTlhw2zR42/nCootTepFcgqBAhKQ7HX8I9ATgzWkbjVFADGD JorGAgYqDcTJ5+CmMGU8ygGYR2RpjCqpCBajZ3fG8oTNzG5YgaT+yoNJ1HNQKmA0 kJs/DaQvZsn7ZmL1iSlsT61L8xDD1zXtMkuF5ny3Q3IujhLlDYZJ5QjbSxsKYPu9 qQkwaK4QAwbih0N97ofmmoFWzlWzhv2ElEv+Tu6gfXt3u8Vljg9LOEKKhanhKPzM 94kkeZ1hjHGl1QS4hNIThbWIIZEPxR5+x9lOw9YIOV72a1zZj62mnxkq6ox5MOJ3 9c2y4LgdNmbg7dOIWYwV9/tWCFcw03TQ8InuKu1mwyp7nxPEAxh4Mf9EpCMLax4z dcge6OM4iEdKe97uurICRE1SEwa480mDk4o4j70TLZ/VWGIkCLD67KDDPwbXqBLd wHwF2BoSDjovtQUnN3vkZoMNeBIuKotbX3sXyRshzlqco9y+odBBlNOT5/YJRpGO ZdpXq9zWvio= =TUka -----END PGP SIGNATURE----- --=-=-=--