From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UMVTACHE/GPugAEAbAwnHQ (envelope-from ) for ; Mon, 27 Feb 2023 15:54:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2A34OiDE/GP7pQAAG6o9tA (envelope-from ) for ; Mon, 27 Feb 2023 15:54:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAEE438127 for ; Mon, 27 Feb 2023 15:54:24 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HUArMe5P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677509664; a=rsa-sha256; cv=none; b=f25y0Gxo8x6K8qoGiq8K2X1wGtsPV+MZ4ElWrNrI4pWt7Esy7X6z+2PloJjW5p0jlpjtug QaUpwPBIzsTkQkWAzZUXONV/gR80ZUDpdGYEwKNvZZZW/UDNYVa68kaxrqmZgVPpO18SLX oIw1xrj60vn0y4ikIxOsdeo0yWKXYGr1lLIm9w2rTJinhx4sXFR+EItkKcBNy1J+F2pcjE FsUn3rEtTwndDt38SquDhKZawUnNuzucJNVSI12FVs5tQi82SrKWQe++bzM6O0GTk+kd35 hL2wo4BjRopPMRhDvJC0nqdzheFAxsl1k1BJteIcYOoxDJZhRvttCIK7bZzU8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HUArMe5P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677509664; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GzY8JVa0TzRvTug6VSUG4OCv+ZroygXRz4lVCPVdNqI=; b=gYod6qCNh6WgQbOe2GYGfwGqRlp45cnrke4UWX115UislqKOc/gwpJ84y9Of7H4lZsNdTr TOTu7vjMfUo6z5ndvineFAdyGoknR7CWA+gOnoXMCtNmtmEUId4qHETbJyFQ/smjVpIXJv CDrcORvBuC+OpcJ+pVpnAmzMtJ7aqvfgfAen3RNVbJmEQhoHrnBgD6gzVXrJ3xmTdh5QrQ TyiV7bYHQRzzygeiayxJqEPbY7g32qgJewdNsV68Z1OP30+D6XVyaU01HSCiaDbiPmBFc7 22/3K5zWDlQJEkRGCBz8tMAqOl0p3x0QAu65TAu6pP0e/Tfe8zWO7nin7r7l8A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWetC-0002Ng-4P; Mon, 27 Feb 2023 09:54:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWet9-0002Ca-44 for guix-patches@gnu.org; Mon, 27 Feb 2023 09:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWet8-0002Iy-Sd for guix-patches@gnu.org; Mon, 27 Feb 2023 09:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWet8-0005Oz-Lp for guix-patches@gnu.org; Mon, 27 Feb 2023 09:54:02 -0500 Subject: bug#61493: [PATCH 0/2] gnu: hwloc: Skip failing test on non-x86 systems. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 27 Feb 2023 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61493 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: 61493-done@debbugs.gnu.org Mail-Followup-To: 61493@debbugs.gnu.org, ludo@gnu.org, simon@simonsouth.net Received: via spool by 61493-done@debbugs.gnu.org id=D61493.167750962420731 (code D ref 61493); Mon, 27 Feb 2023 14:54:02 +0000 Received: (at 61493-done) by debbugs.gnu.org; 27 Feb 2023 14:53:44 +0000 Received: from localhost ([127.0.0.1]:46520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWesq-0005OI-0q for submit@debbugs.gnu.org; Mon, 27 Feb 2023 09:53:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWeso-0005O6-Mi for 61493-done@debbugs.gnu.org; Mon, 27 Feb 2023 09:53:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWesi-0002G8-Qg; Mon, 27 Feb 2023 09:53:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=GzY8JVa0TzRvTug6VSUG4OCv+ZroygXRz4lVCPVdNqI=; b=HUArMe5Pmvf6cWnqNBvi 9s9JXOIovD0h029q5AKbJB3uobtpFxmzRC+2vXVPcjZOzDl6yu1xFqR0ay7NZBXNDiabpZH5Ka+2o WOwygFSi2RA44lBPfHT7131+SuxdvYVrWN0WJFa0Xa1B235IBaHqoqgdTN45pWvoi11U8/VQTrmfq yE7slFA349eeQq3C36S5TL80rzMUfboMVVWQ0oWzgzYJoNLLY1HxUy2hXqdIHXO4tgPVNlv5xj43E lBf7fSpJw1ZgJ+Nk3G2sIbfq9j4xZLuWFuukhVA++saHcYucmmCfvIZ4nVniGXOTgyVtFuL0twoZi otyfKDESdBXm5Q==; Received: from [193.50.110.164] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWert-0005hz-AT; Mon, 27 Feb 2023 09:52:58 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 27 Feb 2023 15:52:43 +0100 In-Reply-To: (Simon South's message of "Mon, 13 Feb 2023 15:56:47 -0500") Message-ID: <875ybnjh38.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: BAEE438127 X-Spam-Score: -2.59 X-Migadu-Spam-Score: -2.59 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: V9y6MrBtUqpm Hi Simon, Simon South skribis: > Here's a patch that circumvents a test failure in hwloc 2.9.0 on non-x86 > systems (and specifically on AArch64), allowing the package to build > successfully on these machines. > > An additional, bonus patch removes a pair of obsolete comments from the h= wloc > package definitions. > > I've tested these changes on x86-64 and AArch64 and generally, things seem > fine. > > - On x86-64, of hwloc's 136 dependents the only seven[0] that fail to bui= ld > appear to be existing failures, according to ci.guix.gnu.org. > > - On AArch64, the package builds fine; many of its dependents fail (in fa= ct I > am still waiting for builds to complete) but again, none of the failures > I've investigated appear to be new. It=E2=80=99s a clear improvement according to . > ---------- > > Here's some background information regarding the fix in case it's useful: > > One of hwloc's primary functions is to provide information about the host > computer's processor topology, in terms of NUMA nodes, CPU clusters and s= o on. > At start-up it it tries to collect this information by querying a sequenc= e of > "topology backends" that each implement a different strategy for detectin= g the > host system's configuration. > > The first source of information is the operating system, so on most Guix > machines the "Linux" backend runs first. This tries to pull information = from > the /sys filesystem tree but since that's inaccessible from within build > containers, this always fails during hwloc's tests. > > For x86 machines specifically, hwloc provides an architecture-specific, > fallback backend that can obtain the same information by querying the har= dware > directly. This normally succeeds within the build environment, and so hw= loc > passes its tests without issue on x86 and x86-64 machines. > > But those are the only platforms for which an architecture-specific topol= ogy > backend is provided: On other systems, once the Linux backend fails, hwlo= c has > nothing else to try and so any tests that rely on the host system's topol= ogy > having been detected will fail. > > My patch fixes the build on these machines by skipping the one (other) te= st > that relies on this information being available, only on non-x86 systems = where > the unavailability of /sys means certain failure. > > For reference, the backends mentioned above are implemented in hwloc's > hwloc/topology-linux.c and hwloc/topology-x86.c. Interesting, thanks for explaining! Ludo=E2=80=99.