all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc.
@ 2023-03-11 14:49 Rostislav Svoboda
  2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
                   ` (3 more replies)
  0 siblings, 4 replies; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 14:49 UTC (permalink / raw)
  To: 62122; +Cc: Rostislav Svoboda

* gnu/packages/emacs-xyz.scm (emacs-sphinx-doc): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 509c640b78..11afbe7778 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12411,6 +12411,34 @@ (define-public emacs-spinner
 ongoing operations.")
     (license license:gpl3+)))
 
+(define-public emacs-sphinx-doc
+  (let ((commit "1eda612a44ef027e5229895daa77db99a21b8801"))
+    (package
+      (name "emacs-sphinx-doc")
+      (version "0.1.0")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/naiquevin/sphinx-doc.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0q72i95yx3xa57jlgr7dik6prf20hi8bp8xf3f5c6ificv7i5378"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-dash emacs-s))
+      (home-page
+       "https://github.com/naiquevin/sphinx-doc.el")
+      (synopsis
+       "Generate Sphinx friendly docstrings for Python functions")
+      (description
+       "Emacs minor mode for inserting docstring skeleton for Python functions
+and methods.  The structure of the docstring is as per the requirement of the
+Sphinx documentation generator.")
+      (license license:expat))))
+
 (define-public emacs-sparql-mode
   (package
     (name "emacs-sparql-mode")
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme.
  2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
@ 2023-03-11 14:49 ` Rostislav Svoboda
  2023-03-17  8:43   ` bug#62121: " Nicolas Goaziou
  2023-03-11 14:49 ` [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel Rostislav Svoboda
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 14:49 UTC (permalink / raw)
  To: 62121; +Cc: Rostislav Svoboda

* gnu/packages/emacs-xyz.scm (emacs-railscasts-theme): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 11afbe7778..d371cfd6f3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -13392,6 +13392,29 @@ (define-public emacs-elpy
 completion, interactive development and more.")
       (license license:gpl3+))))
 
+(define-public emacs-railscasts-theme
+  (let ((commit "1340c3f6c2717761cab95617cf8dcbd962b1095b")
+        (revision "0"))
+    (package
+      (name "emacs-railscasts-theme")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/mikenichols/railscasts-theme")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "021x1l5kzsbm0qj5a3bngxa7ickm4lbwsdz81a2ks9pi1ivmw205"))))
+      (build-system emacs-build-system)
+      (home-page
+       "https://github.com/mikenichols/railscasts-theme")
+      (synopsis "Railscasts color theme for Emacs")
+      (description "Railscasts color theme for Emacs.")
+      (license license:expat-0))))
+
 (define-public emacs-rainbow-delimiters
   (package
     (name "emacs-rainbow-delimiters")
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
  2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
  2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
@ 2023-03-11 14:49 ` Rostislav Svoboda
  2023-03-13 13:01   ` Rostislav Svoboda
  2023-03-11 14:49 ` [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode Rostislav Svoboda
  2023-03-17  8:36 ` [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Nicolas Goaziou
  3 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 14:49 UTC (permalink / raw)
  To: 62123; +Cc: Rostislav Svoboda

* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d371cfd6f3..cbd0e64e65 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17358,6 +17358,44 @@ (define-public emacs-pinyinlib
 letter of Pinyin to Simplified/Traditional Chinese characters.")
     (license license:gpl3+)))
 
+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "1.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/arifer612/pippel")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-dash emacs-s))
+      (inputs
+       (list python))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-curl-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "plz.el"
+                  ("pippel-python-command" (search-input-file
+                                            inputs "/bin/python"))))))))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager pip")
+      (description
+       "Emacs frontend for the Python package manager pip.  As pippel also uses
+@code{tabulated-list-mode}, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-reverse-im
   (package
     (name "emacs-reverse-im")
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode.
  2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
  2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
  2023-03-11 14:49 ` [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel Rostislav Svoboda
@ 2023-03-11 14:49 ` Rostislav Svoboda
  2023-03-24  9:15   ` bug#62124: " Nicolas Goaziou
  2023-03-17  8:36 ` [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Nicolas Goaziou
  3 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 14:49 UTC (permalink / raw)
  To: 62124; +Cc: Rostislav Svoboda

* gnu/packages/emacs-xyz.scm (emacs-column-enforce-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cbd0e64e65..f77673cc44 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26881,6 +26881,32 @@ (define-public emacs-spaceline-next
           (base32 "11lwckqcgzsahrkkm5wk1ph4kc7d4yz05r7251g8c9f0q6vdj9dp"))
          (file-name (git-file-name name version)))))))
 
+(define-public emacs-column-enforce-mode
+  (let ((commit "14a7622f2268890e33536ccd29510024d51ee96f")
+        (revision "0"))
+    (package
+      (name "emacs-column-enforce-mode")
+      (version (git-version "1.0.4" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url
+                       "https://github.com/jordonbiondo/column-enforce-mode")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1vxra5vk78yns2sw89m41bggczqg1akq6xvzfs9kylhkg5yz3g7g"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/jordonbiondo/column-enforce-mode")
+      (synopsis "Highlight text that extends beyond a certain column")
+      (description
+       "Highlight text that extends beyond a certain column.  Can be used to enforce
+80 column rule (well more like suggest, not enforce).  Meant to be a very
+lightweight, zero configuration, way to help enforce the 80 column rule.  It can be
+configured for any N-column rule however.")
+      (license license:gpl3+))))
+
 (define-public emacs-column-marker
   (package
     (name "emacs-column-marker")
-- 
2.39.2





^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
  2023-03-11 14:49 ` [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel Rostislav Svoboda
@ 2023-03-13 13:01   ` Rostislav Svoboda
  2023-03-17  8:51     ` Nicolas Goaziou
  0 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-13 13:01 UTC (permalink / raw)
  To: 62123

Oh, the patch is broken, ignore it. sorry. Here's a correction. Please
have a look at the 'python2 vs. python3' comment. Is it OK to make it
work just for python3?

Cheers
Bost

From 29c79c13c4cdfe5c6014cd9ba35cea41a465a106 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Sat, 11 Mar 2023 15:36:11 +0100
Subject: [PATCH 3/4] gnu: Add emacs-pippel.

* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d371cfd6f3..f4e557e98a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17358,6 +17358,43 @@ (define-public emacs-pinyinlib
 letter of Pinyin to Simplified/Traditional Chinese characters.")
     (license license:gpl3+)))

+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "1.4" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/arifer612/pippel")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (inputs (list python))
+      (propagated-inputs (list emacs-dash emacs-s))
+      (arguments
+       (list #:phases #~(modify-phases %standard-phases
+                          (add-after 'unpack 'substitute-python-path
+                            (lambda* (#:key inputs #:allow-other-keys)
+                              (emacs-substitute-variables "pippel.el"
+
("pippel-python-command"
+                                                           (search-input-file
+                                                            inputs
+;;; For 'python2 vs. python3' see the choice:
+;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dabdb521b976ee79/pippel.el#L65
+
"/bin/python3"))))))))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager pip")
+      (description
+       "Emacs frontend for the Python package manager pip.  As pippel also uses
+@code{tabulated-list-mode}, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-reverse-im
   (package
     (name "emacs-reverse-im")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc.
  2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
                   ` (2 preceding siblings ...)
  2023-03-11 14:49 ` [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode Rostislav Svoboda
@ 2023-03-17  8:36 ` Nicolas Goaziou
  2023-03-27 19:17   ` Rostislav Svoboda
  3 siblings, 1 reply; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-17  8:36 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62122

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-sphinx-doc): New variable.

Thank you. Some comments follow.

> +(define-public emacs-sphinx-doc
> +  (let ((commit "1eda612a44ef027e5229895daa77db99a21b8801"))

Since you're using a non-tagged commit, you also need to bind revision
to "0" or "1". FWIW, I prefer latter because Repology thinks "version-0"
predates "version".

> +    (package
> +      (name "emacs-sphinx-doc")
> +      (version "0.1.0")

Base version is "0.3.0" according to Version keyword. Therefore, this should be

   (git-version "0.3.0" revision commit)

> +      (home-page
> +       "https://github.com/naiquevin/sphinx-doc.el")

You can use a single line here.

> +      (synopsis
> +       "Generate Sphinx friendly docstrings for Python functions")

Ditto. Maybe add "in Emacs" at the end?

> +      (description
> +       "Emacs minor mode for inserting docstring skeleton for Python functions
> +and methods.

This should be a full sentence.

  Sphinx Doc is an Emacs minor mode…

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#62121: [PATCH 2/4] gnu: Add emacs-railscasts-theme.
  2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
@ 2023-03-17  8:43   ` Nicolas Goaziou
  2023-03-27 19:17     ` [bug#62121] " Rostislav Svoboda
  0 siblings, 1 reply; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-17  8:43 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62121-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-railscasts-theme): New variable.

Thanks. Some comments follow.

> +      (home-page
> +       "https://github.com/mikenichols/railscasts-theme")

A single line should suffice above.

> +      (synopsis "Railscasts color theme for Emacs")
> +      (description "Railscasts color theme for Emacs.")

You need to provide a complete sentence. For example,

 Railscasts is a color theme for Emacs.

> +      (license license:expat-0))))

Isn't it plain expat?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
  2023-03-13 13:01   ` Rostislav Svoboda
@ 2023-03-17  8:51     ` Nicolas Goaziou
  2023-03-28 22:34       ` Rostislav Svoboda
  0 siblings, 1 reply; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-17  8:51 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62123

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> Oh, the patch is broken, ignore it. sorry. Here's a correction.

Thanks. Some comments follow.

> Please have a look at the 'python2 vs. python3' comment. Is it OK to
> make it work just for python3?

Guix does not support Python 2 anymore. Note, however,
that you can provide `python-wrapper' as input instead of `python', and
use "python" executable. Anyway sticking to "python3" is OK.

> +      (inputs (list python))
> +      (propagated-inputs (list emacs-dash emacs-s))

Nitpick: usually, inputs and propagated inputs are located after arguments.

> +      (arguments
> +       (list #:phases #~(modify-phases %standard-phases

You can add a newline characther after `list' and another one after
`#:phases'.

> +                          (add-after 'unpack 'substitute-python-path
> +                            (lambda* (#:key inputs #:allow-other-keys)
> +                              (emacs-substitute-variables "pippel.el"
> +
> ("pippel-python-command"
> +                                                           (search-input-file
> +                                                            inputs
> +;;; For 'python2 vs. python3' see the choice:
> +;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dabdb521b976ee79/pippel.el#L65
> +
> "/bin/python3"))))))))
> +      (home-page "https://github.com/arifer612/pippel")
> +      (synopsis "Emacs frontend to Python package manager pip")

pip -> Pip

> +      (description
> +       "Emacs frontend for the Python package manager pip.  As pippel also uses
> +@code{tabulated-list-mode}, it provides a similar package menu like
> +@code{package-list-packages}.")

The first sentence is not complete : "Pippel is an Emacs…"

Also, pip -> Pip, pippel -> Pippel, @code{tabulated-list-mode} ->
Tabulated List mode.

> +      (license license:gpl3+))))

I think you also need to include "pippel.py" file through #:include
keyword and possibly configure `pippel-package-path'.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#62124: [PATCH 4/4] gnu: Add emacs-column-enforce-mode.
  2023-03-11 14:49 ` [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode Rostislav Svoboda
@ 2023-03-24  9:15   ` Nicolas Goaziou
  0 siblings, 0 replies; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-24  9:15 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62124-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-column-enforce-mode): New
> variable.

I tweaked the description and applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc.
  2023-03-17  8:36 ` [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Nicolas Goaziou
@ 2023-03-27 19:17   ` Rostislav Svoboda
  2023-03-30 16:21     ` bug#62122: " Nicolas Goaziou
  0 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-27 19:17 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 62122

Hello Nicolas,
I'm resending the patch.
Cheers Bost



From d7efd6fa74128809cc3f49ca9a8420369e96ad79 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Mon, 27 Mar 2023 20:58:51 +0200
Subject: [PATCH 1/2] gnu: Add emacs-sphinx-doc.

* gnu/packages/emacs-xyz.scm (emacs-sphinx-doc): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da2856abc8..afc0726230 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12487,6 +12487,32 @@ (define-public emacs-sparql-mode
 as Fuseki or DBPedia.")
     (license license:gpl3+)))

+(define-public emacs-sphinx-doc
+  (let ((commit "1eda612a44ef027e5229895daa77db99a21b8801")
+        (revision "1"))
+    (package
+      (name "emacs-sphinx-doc")
+      (version (git-version "0.3.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/naiquevin/sphinx-doc.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0q72i95yx3xa57jlgr7dik6prf20hi8bp8xf3f5c6ificv7i5378"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-dash emacs-s))
+      (home-page "https://github.com/naiquevin/sphinx-doc.el")
+      (synopsis
+       "Generate Sphinx friendly docstrings for Python functions in Emacs")
+      (description
+       "Sphinx Doc is an Emacs minor mode for inserting docstring
skeleton for Python
+functions and methods.  The structure of the docstring is as per the
requirement of
+the Sphinx documentation generator.")
+      (license license:expat))))
+
 (define-public emacs-better-defaults
   (package
     (name "emacs-better-defaults")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme.
  2023-03-17  8:43   ` bug#62121: " Nicolas Goaziou
@ 2023-03-27 19:17     ` Rostislav Svoboda
  2023-03-30 10:39       ` Nicolas Goaziou
  0 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-27 19:17 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 62121-done

Hello Nicolas,
I'm resending the patch.
Cheers Bost



From b3d54b23e109816762397f06ebcc5ba2b152a966 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Mon, 27 Mar 2023 21:06:09 +0200
Subject: [PATCH 2/2] gnu: Add emacs-railscasts-theme.

* gnu/packages/emacs-xyz.scm (emacs-railscasts-theme): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index afc0726230..15bda670ba 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -13446,6 +13446,27 @@ (define-public emacs-elpy
 completion, interactive development and more.")
       (license license:gpl3+))))

+(define-public emacs-railscasts-theme
+  (let ((commit "1340c3f6c2717761cab95617cf8dcbd962b1095b")
+        (revision "0"))
+    (package
+      (name "emacs-railscasts-theme")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/mikenichols/railscasts-theme")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "021x1l5kzsbm0qj5a3bngxa7ickm4lbwsdz81a2ks9pi1ivmw205"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/mikenichols/railscasts-theme")
+      (synopsis "Railscasts is a color theme for Emacs")
+      (description "Railscasts is a color theme for Emacs.")
+      (license license:expat))))
+
 (define-public emacs-rainbow-delimiters
   (package
     (name "emacs-rainbow-delimiters")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
  2023-03-17  8:51     ` Nicolas Goaziou
@ 2023-03-28 22:34       ` Rostislav Svoboda
  2023-03-30 10:38         ` bug#62123: " Nicolas Goaziou
  0 siblings, 1 reply; 15+ messages in thread
From: Rostislav Svoboda @ 2023-03-28 22:34 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 62123

Hi Nicolas

> Nitpick: usually, inputs and propagated inputs are located after arguments.

Done

> > +      (arguments
> > +       (list #:phases #~(modify-phases %standard-phases
>
> You can add a newline characther after `list' and another one after
> `#:phases'.

Done

> Also, pip -> Pip, pippel -> Pippel

Done

> I think you also need to include "pippel.py" file through #:include

Done

> keyword and possibly configure `pippel-package-path'.

Done. Please have a look if it's done correctly.

Cheers
Bost




From 4b83e10686d8189568b756fe514d0be0d2c54750 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Wed, 29 Mar 2023 00:15:12 +0200
Subject: [PATCH] gnu: Add emacs-pippel.

* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da2856abc8..1cdaccd366 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17288,6 +17288,54 @@ (define-public emacs-php-mode
 documentation search and a source and class browser.")
     (license license:gpl3+)))

+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/arifer612/pippel")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:include #~(cons "^pippel\\.py$" %default-include)
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-pippel-package-path
+              (lambda* (#:key outputs #:allow-other-keys)
+                (let* ((out (assoc-ref outputs "out"))
+                       (package-path (string-append
+                                      out
+                                      "/share/emacs/site-lisp/pippel-"
+                                      #$version)))
+                  (emacs-substitute-variables "pippel.el"
+                    ("pippel-package-path"
+                     package-path)))))
+            (add-after 'unpack 'substitute-python-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "pippel.el"
+                  ("pippel-python-command"
+                   (search-input-file
+                    inputs
+                    "/bin/python"))))))))
+      (inputs (list python-wrapper))
+      (propagated-inputs (list emacs-dash emacs-s))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager Pip")
+      (description
+       "Pippel is an Emacs frontend for the Python package manager Pip.  As
+Pippel also uses Tabulated List mode, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-pos-tip
   (package
     (name "emacs-pos-tip")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 15+ messages in thread

* bug#62123: [PATCH 3/4] gnu: Add emacs-pippel.
  2023-03-28 22:34       ` Rostislav Svoboda
@ 2023-03-30 10:38         ` Nicolas Goaziou
  0 siblings, 0 replies; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-30 10:38 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62123-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> Done. Please have a look if it's done correctly.

Applied with the change below. Thank you.
> +            (add-after 'unpack 'substitute-pippel-package-path
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let* ((out (assoc-ref outputs "out"))
> +                       (package-path (string-append
> +                                      out
> +                                      "/share/emacs/site-lisp/pippel-"
> +                                      #$version)))

I used `elpa-directory' here, and removed `out' binding.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme.
  2023-03-27 19:17     ` [bug#62121] " Rostislav Svoboda
@ 2023-03-30 10:39       ` Nicolas Goaziou
  0 siblings, 0 replies; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-30 10:39 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62121-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> I'm resending the patch.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#62122: [PATCH 1/4] gnu: Add emacs-sphinx-doc.
  2023-03-27 19:17   ` Rostislav Svoboda
@ 2023-03-30 16:21     ` Nicolas Goaziou
  0 siblings, 0 replies; 15+ messages in thread
From: Nicolas Goaziou @ 2023-03-30 16:21 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 62122-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> Subject: [PATCH 1/2] gnu: Add emacs-sphinx-doc.
>
> * gnu/packages/emacs-xyz.scm (emacs-sphinx-doc): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-03-30 16:22 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
2023-03-17  8:43   ` bug#62121: " Nicolas Goaziou
2023-03-27 19:17     ` [bug#62121] " Rostislav Svoboda
2023-03-30 10:39       ` Nicolas Goaziou
2023-03-11 14:49 ` [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel Rostislav Svoboda
2023-03-13 13:01   ` Rostislav Svoboda
2023-03-17  8:51     ` Nicolas Goaziou
2023-03-28 22:34       ` Rostislav Svoboda
2023-03-30 10:38         ` bug#62123: " Nicolas Goaziou
2023-03-11 14:49 ` [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode Rostislav Svoboda
2023-03-24  9:15   ` bug#62124: " Nicolas Goaziou
2023-03-17  8:36 ` [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Nicolas Goaziou
2023-03-27 19:17   ` Rostislav Svoboda
2023-03-30 16:21     ` bug#62122: " Nicolas Goaziou

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.