From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iJAQJ3zXLmTyQQEASxT56A (envelope-from ) for ; Thu, 06 Apr 2023 16:30:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kMHXJnzXLmTccAEAauVa8A (envelope-from ) for ; Thu, 06 Apr 2023 16:30:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3AC515AA5 for ; Thu, 6 Apr 2023 16:30:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkQcu-0006J2-9e; Thu, 06 Apr 2023 10:30:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQcm-0006Hc-1r for guix-patches@gnu.org; Thu, 06 Apr 2023 10:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkQck-000190-F7 for guix-patches@gnu.org; Thu, 06 Apr 2023 10:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkQck-0003lS-1d for guix-patches@gnu.org; Thu, 06 Apr 2023 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Apr 2023 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62473 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: reza Cc: 62473@debbugs.gnu.org, Reza Housseini Received: via spool by 62473-submit@debbugs.gnu.org id=B62473.168079138514415 (code B ref 62473); Thu, 06 Apr 2023 14:30:02 +0000 Received: (at 62473) by debbugs.gnu.org; 6 Apr 2023 14:29:45 +0000 Received: from localhost ([127.0.0.1]:54626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQcS-0003kR-QM for submit@debbugs.gnu.org; Thu, 06 Apr 2023 10:29:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQcP-0003kC-Mp for 62473@debbugs.gnu.org; Thu, 06 Apr 2023 10:29:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQcJ-0000X3-TX; Thu, 06 Apr 2023 10:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=KETQPuw9/8tO+NvrhaN8BK3oCOcOtPQWZHYLbsPCTds=; b=Qu+4C71ptTn1UULPUwls jBMwySXRGBK0WPQgfR99LF4BiSw1lPeAGUnvO3uWeMs5NFRcH8D5RM6e8zrKwRN86L2EZiwi8fXF9 X7qiVK2oG4ibPkJd1vmbFx2uJIetBS0re9Mubm4nMumWdVFD0Cb9QAWfqQ20eSOi6bK6FlbGWyHkU MZDVlH3h7nVxZIoY6pivKpHzXirutVMX4t43QOd2nncg9CKVg7+6fcYorTp6wytV9IDTP8y0OM8G/ sml62mkMuS+2IP6YsmCuWHAT4Yi4lPqjFYYF5PusLQzpL5Nit2FEeI6FjgIzYndBqW+Bge4KwDj7a OlNijwMBt6+SfQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQcI-0005oc-2D; Thu, 06 Apr 2023 10:29:34 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8e459feaf2d6a3d0f8720e72299e81259b9e6168.1680707361.git.reza@housseini.me> <0102018752a6c638-f104e797-04c3-4e5e-914e-5997a66b2c46-000000@eu-west-1.amazonses.com> Date: Thu, 06 Apr 2023 16:29:31 +0200 In-Reply-To: <0102018752a6c638-f104e797-04c3-4e5e-914e-5997a66b2c46-000000@eu-west-1.amazonses.com> (reza@housseini.me's message of "Wed, 5 Apr 2023 18:21:14 +0000") Message-ID: <875ya9krsk.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680791420; a=rsa-sha256; cv=none; b=b/lDGZUym3jjlEwSpkWrSYM4PskB7SIKYiB4ZtiJl5eLVqauiac5/ilv6YVFK2xyRtLocx ixpcoPDjEu5XjkpbbjgTZf3ALPLRTYyzmnAyNfavCxmE0pyvY1gxMol4wy0lamdLE2VqYZ OJmqxdHbvFbwcEMG6HZ++R5z5/wMTxsCMQMds1b+YV4mQnpAzy7rGUVsXwq4GiZ9H8gpnk SJYDj4gYCA8+3Udem7osQqgaZuiaMtTunS22ZcldvckrZ6jSP6/rn+p6Gmu5zGsZKmqzmz 597mQI/h9/xiimOQB/nr8rim2R2FAa8RvoD+SpjiZvW+XKoARrS6bijZ1KlLPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qu+4C71p; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680791420; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KETQPuw9/8tO+NvrhaN8BK3oCOcOtPQWZHYLbsPCTds=; b=Ku4y03CvMFez+q1FfgZ7rkaKHLVKrn+yybnYV9f1yw013lrvF8n04Rp1BVhWy2LivoeX7U Ob68MSe0n6lwRwlE6iC9yI2hqMq3N76Af/2SM6MPVn3SrIYLNGhJsUUiZaTXr00E/MScRv wCvBhF5T5tbzlwlnACyaWwPuuvWOplm5ilOqn4dxAFnvkA63CkvzHKqBuf6u3KDoMKRcIu aBKhrfI0laJq0mfUFcLiAM/PjToB2trllaISlMa2oUm/SlKGTUKKmWUc7DvSnLRkss9EtX ObNDa4MdH5pwxz2SN31iRhAHs9p327U+fvv87sE6ssXbEx9onhiGZ09V+MobgQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qu+4C71p; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.42 X-Spam-Score: -4.42 X-Migadu-Queue-Id: F3AC515AA5 X-TUID: VOPqxkCLfypF Hi Reza, Great work, it=E2=80=99s good to have an OpenFoam update! Some comments follow. reza skribis: > From: Reza Housseini >=20 > --- > gnu/packages/check.scm | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) Your mail user agent apparently added DOS-style line endings, which I think is the reason why doesn=E2=80= =99t have any info. Could you try to use =E2=80=98git send-email=E2=80=99 in the future, to avo= id that kind of issue? > +(define-public ftest > + (package > + (name "ftest") > + (version "bf75576064fce2e07f52cd63a3e410f12358728b") That=E2=80=99s not a reasonable version string; see on how to derive version strings for Git checkouts. Furthermore, when packaging a snapshot (as opposed to a tagged release), please add a short comment explaining why we=E2=80=99re not providing a rel= ease. > + (build-system copy-build-system) > + (native-inputs (list cmake-minimal)) Perhaps use =E2=80=98cmake-build-system=E2=80=99? > + (synopsis "Simple and limited unit-test framework for C++") > + (description "A simple and limited unit-test framework for C++") Please write a full sentence: https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.= html Ludo=E2=80=99.