From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yK4UFdcQMGR9OgAASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 14:47:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YEkLFNcQMGRICgEAG6o9tA (envelope-from ) for ; Fri, 07 Apr 2023 14:47:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1322B3B878 for ; Fri, 7 Apr 2023 14:47:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pklUi-00041q-Ip; Fri, 07 Apr 2023 08:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pklUf-000413-TM for guix-patches@gnu.org; Fri, 07 Apr 2023 08:47:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pklUc-0001Rg-Fd for guix-patches@gnu.org; Fri, 07 Apr 2023 08:47:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pklUc-0000W8-BT for guix-patches@gnu.org; Fri, 07 Apr 2023 08:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61982] [PATCH 2/2] home: services: xdg-base-directories: Deprecate XDG_LOG_HOME. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61982 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: philip@philipmcgrath.com, 61982@debbugs.gnu.org Received: via spool by 61982-submit@debbugs.gnu.org id=B61982.16808716091956 (code B ref 61982); Fri, 07 Apr 2023 12:47:02 +0000 Received: (at 61982) by debbugs.gnu.org; 7 Apr 2023 12:46:49 +0000 Received: from localhost ([127.0.0.1]:55945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pklUO-0000VU-Qm for submit@debbugs.gnu.org; Fri, 07 Apr 2023 08:46:49 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:46183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pklUL-0000Uv-Ip for 61982@debbugs.gnu.org; Fri, 07 Apr 2023 08:46:46 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 56E691BF206; Fri, 7 Apr 2023 12:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1680871599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A88C6LY/zM638Nnyi/Z//3SgZalKkgTQhDAK9omXCaM=; b=JpbWZTRSWUvgznKcjWIWEXAYqLgE32z7iAtnO11c3X7hD4WPG2Etfcay/CRMw4oRWP05ok h8g+UJq8Ygw0rLkHLXRRJ7vZd0vq+Hw7PjqToVhdrP14YRzoHKF4wEUczG1sEzUfW8yPA3 iQ39jAhZx7qLuWVZnshJI3dda/QZDVfbSJOA9pySjw8Ve9iFAk9qjYQyIjHowRT3oaY4gL ipHRS7oZJTJ7ZhDvaMb3Ydji5cLnEOQi4qwbez1jpoK8Mwbmriu6TciPl2RcfoJiB2Jw/x EcfPL9pVHo7m16QrU6wdhEYW8O8EZvFgWMsrt/kGTEUNZRRITVncHIcmpGbYkg== From: Andrew Tropin In-Reply-To: <10e30d4c-07f2-8bf9-24ed-7bbf820d12e8@makinata.eu> References: <3005f8a58ec5afc447f2baf40958956bd0d16099.1678029530.git.mirai@makinata.eu> <0a0764da3fa04f9a02f37a7960a0c9608782854d.1678029530.git.mirai@makinata.eu> <87cz4gw06c.fsf@trop.in> <10e30d4c-07f2-8bf9-24ed-7bbf820d12e8@makinata.eu> Date: Fri, 07 Apr 2023 16:46:34 +0400 Message-ID: <875ya7x3kl.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680871639; a=rsa-sha256; cv=none; b=O0S946AKtMju8j+aCeWWFRGD2+ZDqGnLdXrjofmSjkVAqxliIlyPRJQQ6OhdZEv4WKfu9F ZdIzYo7ONTjBBpLpTLUBPrnhdJOzhxqqVadAJQU3MFPnYLTZJzoL4MFEWgUxWq6JcdzEk2 bHVnP9s+KvlJqnuD7T8JozRfUYbTXLP+GXqt+XA59o58FV8P5gRCobigFfK5iNdRQG4z9b 31b1SPi2G/gMQL0h2qgBtZR9A7Cf6/nu1DjwdVfU7r/4ZAYLTJBK2UGfovk+vFK0EJJKeq Zj1C+yH/nVU+rEYphIzX0lNjf89x4XXTt0G2qJROwOeJvwokMNw49BQ0N5y33w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=JpbWZTRS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680871639; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=A88C6LY/zM638Nnyi/Z//3SgZalKkgTQhDAK9omXCaM=; b=LMIcwy1ERrhw1uIcQWI6Oc3lkCme+/x8ddH/chCG4fvRd6Jai8aFz+j8+McmAn99YjxoWO o145IijgfZ9ab4iu625grgI2NfRypZbIq1EWz4KpA0WENKzybQiQZI6kGTMh2fs+gzx4Pg n4MPQORr7R6AbdcT/3cZ9jcI2hKHt8hwPpgiHIcnkvSlTvee1Bb3Uh7GP2Hshbz9j0jPmn xkEzoEDJfoJvKLW1XqvzFVXrDm6MH2WF5kfqxa1fvDqOtOhTdhKfUin4EYMM1eEvx2qYo+ F+oGd2ENayBaof6pmgA8K+41PA//t/VG0KuvYwJKuFW/wgYc7Ndv4hgbOOB2dA== X-Migadu-Spam-Score: 0.58 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=JpbWZTRS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: 0.58 X-Migadu-Queue-Id: 1322B3B878 X-TUID: 9wABxPfjfkD0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-04-07 12:47, Bruno Victal wrote: > Hi Andrew, > > On 2023-04-07 09:45, Andrew Tropin wrote: >> On 2023-03-05 15:19, Bruno Victal wrote: >>> --- a/gnu/home/services/desktop.scm >>> +++ b/gnu/home/services/desktop.scm >>> @@ -206,8 +206,8 @@ (define (home-dbus-shepherd-services config) >>> (default-environment-variables)) >>> #:log-file >>> (format #f "~a/dbus.log" >>> - (or (getenv "XDG_LOG_HOME") >>> - (format #f "~a/.local/var/log" >>> + (or (getenv "XDG_STATE_HOME") >>> + (format #f "~a/.local/state" >>=20 >> If we deprecate XDG_LOG_HOME, maybe it's a good idea to make a helper >> function, which can be reused across different services?=20=20 >>=20 >> Also, how about appending /log subdirectory by default? >>> WDYT? > > I'm wondering if this continued usage of XDG_LOG_HOME was a good idea, > maybe the service should just start using XDG_STATE_HOME as soon as possi= ble? > (in which case, this patch will have to be reworked to reflect that) > This way we avoid introducing yet more code to handle deprecated code. > > It shouldn't result in any kind of problems, XDG_LOG_HOME will still be s= et in the meantime > for scripts and code that happen to use it and are not part of (upstream)= guix. > > WDYT? I meant introducing something like this (define (get-log-dir) (string-append (getenv "XDG_STATE_HOME") "/log")) and use it instead of (or (getenv "XDG_STATE_HOME") (format #f "~a/.local/state" (getenv "HOME"))) =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmQwEKoACgkQIgjSCVjB 3rD0Tw/+Kn9fjK0gunUgwz0wWZ9T/+uvK8PFedGXRpDMH/ZV/iwHXC3AiS5R0I++ eHMTF0slJ6H06buDmaMwSZYy750R5GBJ7Ec4XQjLa+TSLSLaOIjP3BhviMFqxWJP zmGVqzT4ajsUgLHAbTAF7XymZMuHnggN8UZJzg1ZVEiF7amGIygP9CtE3GQbehao Erylha2O1ZZFMvwepmYBF9auhN1pyD5Um5Tn/IijAllc4VpCIsTIQBmozlNUIR0G GktkYIwo6C9H/R5v+O8C/ROFVjjMl/k4GMm/I8pLHUCQiy0FSfoKQmcSzbprY4TT nYVJvnvSnEtZ+CeamdB2l2O3Yqu/v4QdaPOvbq+j2+b818g378ffp5Je4BQ0n32U WmIEfq3W+vWHuffhWyozcb3RTbO14UxIECjVyPSSQezeolNWhJtJnvI8gphsBb+8 MOlm4suVDSpBJPjDkX5vVOn2tayMDyuI4AgqhUKWjDKZ4IaG1Cl+ML3msMqbdyjR 9hkYxnkBK+EeBDizPhuzDjRlFirXxmHUo3FmN6U/r0U127xlUWc52Bpn1tc8Yj0c XSFMn/GHOotJVLTIozd/Q8LFFbAvt6RNmeXg7oWpo3exDdQ730F9Kci0dZsdc+DL Ek0Pkb5yOPPuazbgR3oz85yEEmuyr31USpuaq3o3CKZqVBAtinU= =szw0 -----END PGP SIGNATURE----- --=-=-=--