From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id COS8KZGxNWS0AAEASxT56A (envelope-from ) for ; Tue, 11 Apr 2023 21:14:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OEDWKZGxNWSKtQAAauVa8A (envelope-from ) for ; Tue, 11 Apr 2023 21:14:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C38F19899 for ; Tue, 11 Apr 2023 21:14:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmJRO-00016K-RN; Tue, 11 Apr 2023 15:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmJRL-00015j-G4 for guix-patches@gnu.org; Tue, 11 Apr 2023 15:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmJRL-0001Gd-69 for guix-patches@gnu.org; Tue, 11 Apr 2023 15:14:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmJRK-0006qm-R9 for guix-patches@gnu.org; Tue, 11 Apr 2023 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62753] [PATCH] gnu: Add emacs-eradio. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Apr 2023 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62753 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62753@debbugs.gnu.org Cc: d@delgado.nrw X-Debbugs-Original-To: Dominik Delgado Steuter via Guix-patches via X-Debbugs-Original-Cc: Dominik Delgado Steuter , 62753@debbugs.gnu.org Received: via spool by 62753-submit@debbugs.gnu.org id=B62753.168124043026292 (code B ref 62753); Tue, 11 Apr 2023 19:14:02 +0000 Received: (at 62753) by debbugs.gnu.org; 11 Apr 2023 19:13:50 +0000 Received: from localhost ([127.0.0.1]:38244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmJR8-0006q0-09 for submit@debbugs.gnu.org; Tue, 11 Apr 2023 15:13:50 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:46329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmJR3-0006pd-3U for 62753@debbugs.gnu.org; Tue, 11 Apr 2023 15:13:48 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 8B34B60004; Tue, 11 Apr 2023 19:13:38 +0000 (UTC) From: Nicolas Goaziou References: <20230410084937.12440-1-d@delgado.nrw> Date: Tue, 11 Apr 2023 21:13:32 +0200 In-Reply-To: <20230410084937.12440-1-d@delgado.nrw> (Dominik Delgado Steuter via Guix-patches via's message of "Mon, 10 Apr 2023 10:49:37 +0200") Message-ID: <875ya2nsf7.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681240465; a=rsa-sha256; cv=none; b=YBuafk+XExMN78JCN3RE0xkPCi+4ilbg9t30hdsjZaWbPJ3pvx/LYByOKjl/UmdCI6FjTZ rSr64U2Tyi5bVMLfrbSH+2Al3lVKU/ksUjBQsD67Jb+E3h9EUJOUsM9aU1q3kw0uQy1aEs N4f8hyasueJYTyp8zPJyAm+ofCMvofv566yp/5fe3QQnHrawd3DOP5toiNgH+9uzQns/6r Zd+kNq2HC1gXQmbA1Tach4WFH0DJ7KQJcl6afhl75eKI08XkQXqbgY6MctXdvDb62zCJ/S 5CVJyMuqqZNWz9ywh+a8SwjhEnNK/EZf5yspHfF/7750U8lVBeM5Cki2aRGckw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681240465; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=X8pM0VXRbkcYDLS/yx75sCD4ddlO4R5IJmhjsmnLfIQ=; b=fCqe+vUNKgGOY3pgkVXfvrLteGUMIiJE7g/aOegYMkUfz+Y32FCuYY+32jQSoyL8/uboAO OmDD3K1cZVvU9XKx2ASCU3ZeD3xpAefPZpyIhfUmSqsRwJnT9oVl3cFV6QXZfi+g2XCV2U GyZvWQv/aXOUMBl6Y7GxAFJRNq03xjCldcHTPrwTm3Xdw/jeU5FFBXY4PC6HcHtw4wVMJl uhFKb3qITwI92xnDtbgEJthWT8Z5N3nb9sVWOGVuDEjI35yondFTsbLLwsDF+hNDfSROlf WjzQZ6G83QL4UJlmxSWY2bmfharTIHNyTKHODYX6Tnd/KISVd7jIMqPtwfgY0Q== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.52 X-Spam-Score: -2.52 X-Migadu-Queue-Id: 6C38F19899 X-TUID: CiGDq4QH8XKn Hello, Dominik Delgado Steuter via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-eradio): New variable. Thank you for the patch. Some comments follow. > +(define-public emacs-eradio > + (package > + (name "emacs-eradio") > + (version "20210327.1000") We don't use MELPA date-based versioning system, unless it is also used upstream. It isn't the case here as upstream set library's version to 0.1. > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/eradio-" > + version ".el")) I suggest to use GitHub as upstream. > + (sha256 > + (base32 > + "0i9mfy5xck0qbbgjhagd35hxd091254w0wga60wd44n04m46h05l")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/olavfosse/eradio") > + (synopsis "The simple radio player for GNU Emacs") You should drop "The" in front of the synopsis. I think "./pre-inst-env guix lint emacs-eradio" should warn about it. > + (description > + "eradio is a simple Internet radio player for Emacs. Start, stop or > +toggle custom-defined channels. An external media player like mpv or vlc is > +required.") I would capitalize "Eradio", but not "internet". Also I suggest to write "Mpv" and "VLC". On this topic, would it make sense to provide VLC as an input, so the Emacs library works out of the box? You also need to separate sentences with two spaces, according to Texinfo syntax. > + (license license:gpl3))) License is actually GPL3+. Could you send an updated patch? Regards, -- Nicolas Goaziou