From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id xbeWE1gTV2QUGwEASxT56A (envelope-from ) for ; Sun, 07 May 2023 04:56:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id Am3IElgTV2TpUAAA9RJhRA (envelope-from ) for ; Sun, 07 May 2023 04:56:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B3712A4AB for ; Sun, 7 May 2023 04:56:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvUZA-0006sT-0M; Sat, 06 May 2023 22:56:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvUZ8-0006s6-0a for bug-guix@gnu.org; Sat, 06 May 2023 22:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvUZ7-00027P-Oj for bug-guix@gnu.org; Sat, 06 May 2023 22:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvUZ7-0001Kk-Kc for bug-guix@gnu.org; Sat, 06 May 2023 22:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 07 May 2023 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.16834281174968 (code B ref 63082); Sun, 07 May 2023 02:56:01 +0000 Received: (at 63082) by debbugs.gnu.org; 7 May 2023 02:55:17 +0000 Received: from localhost ([127.0.0.1]:36091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvUYO-0001I1-Qv for submit@debbugs.gnu.org; Sat, 06 May 2023 22:55:17 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:45286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvUYM-0001HG-OV for 63082@debbugs.gnu.org; Sat, 06 May 2023 22:55:15 -0400 Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-61af33bdf1dso16667926d6.2 for <63082@debbugs.gnu.org>; Sat, 06 May 2023 19:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683428109; x=1686020109; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=+/IY8cJ+w8bIxvdCbtOxEHNoEEv3i6XZL9gqBCjCwWg=; b=T/Mpg1ZL8wD1cGRGYimIzPJM1GD+vdLLBLO24beENT3gatbmQyVDRWkJNqEQNof2mz l/5sZqIECRc0qEKvUHoFqs+k+LqDHs8VFVLB9Z8QS/waehhNppixxf2QyFNoef1xtLcF 6A7ivrhmtguB3MaNiU/SwtJekLaY/u5TGAQlevtzMdP0RMchKbMqJIG9mqGcSpNAg6Gr ldq6LaImlPwr6gFswnxnvYcPI1HDmTrwdKK75yd7SJYfUsgfRZqRXD4a3McQpxNNpyHF W0FNxINfKU3kUuTPqSxS4eBCwC7On58pP9u1lD9pF02yKXyFHIvSsye5/sLf/dx52pmD jCzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683428109; x=1686020109; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+/IY8cJ+w8bIxvdCbtOxEHNoEEv3i6XZL9gqBCjCwWg=; b=DwZppROPQL9kZhiKb3YILubur2gYHyLNhSh1a1rF/Hs4YVymti5AujvcHDVaySZBPu JEg6Jnr+JBh08g1RZDcbQufgGhUmiZimiwmjZOYTOL8HHl1uW970HtBWQMs1E4xc3gCa bplgThDgFUYBqAavHNCChoj9/x/KpAFCdfG1Ck0fqt6UsVRhNz4y/Nqfk/mY7htrYTDb QxI+avA+2uGNaUNPJjmzcx/+XN6nNBMBHcODMdu18c+8lPa8ry5kMQWKX6SBuFUbttBv KYapwR9pR5NQumIG2roskBQSeeLrT0Jl+5lhTqD7sOvat3zFkNkRa1NqJXLMmOm9Y4WR nljQ== X-Gm-Message-State: AC+VfDwwFDGnmCo0ByM9AQoetCfNhXR1kSPRjOEnuW6RAZLdmOxBIJDq zYK/+XrhMXHf/ySRFtPdXzD7T6D8gaA= X-Google-Smtp-Source: ACHHUZ6S2SPl0Wy69MgVEXhnrNLt1krmN1DoVLpsLIqP2lohfZdRsUTz2draT7uOQMlN1hl9DOfOSg== X-Received: by 2002:ad4:594b:0:b0:621:78a:dd84 with SMTP id eo11-20020ad4594b000000b00621078add84mr7593363qvb.47.1683428108997; Sat, 06 May 2023 19:55:08 -0700 (PDT) Received: from hurd (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id h10-20020a0cf20a000000b005e9a1409458sm1801457qvk.71.2023.05.06.19.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 19:55:08 -0700 (PDT) From: Maxim Cournoyer References: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> Date: Sat, 06 May 2023 22:55:07 -0400 In-Reply-To: <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> (Liliana Marie Prikler's message of "Fri, 05 May 2023 21:51:59 +0200") Message-ID: <875y943l6c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683428184; a=rsa-sha256; cv=none; b=skOrMbOwsEfO+3hoP9Lb710te+Uf6rjnKPhxnAxq1bp5AiVRW6xzPYMBRvdCsKsyYX6H90 CTNe64+YRk7xqEU9xO9PU8cbGYjiiK1/U/4zKdnBZiksvjKBpCnJlAu6XpQNbqYzguKFMF 6dhZmRDwUZP9yTVG284zcaV1CVS+siZDiRW3+NokpAFjyohDYk1A7lnCCeHTD77NI92/R9 +80ZiOOLffV/02KKudC1oQUBEpsOOZ7HtoG9wKAeY3SvaaTs20gAdAnsutYeo0ixzpQ75h XwHOZ0LCrEuc85N70OLg4naIn5wGPwcAFlbOt15sHr+uqd1McZ4DKI6Yszx6cA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="T/Mpg1ZL"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683428184; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+/IY8cJ+w8bIxvdCbtOxEHNoEEv3i6XZL9gqBCjCwWg=; b=OlQmdU325WJ3vohJHS+ghlNeAprLO/TY6/C+6+LKElilQnvUOatA3MUklYjUgDlUqndWH2 ifZ4/u0CAvgjomQkYL8r0iUCxOlWJ356HdlgGKQNyalErhti4vnqQhtTP6fOor2xjzI8GL uTafiWtd1fNxR3/ZKYbfg6qZM8ld0RJcGtcC+VonlVCx4iPzQeqmjTT0b54mFpFqOAplWA HaabIZ197AOpzvDPZp761utfZ4dSczkMnDEqBITGXb8QcSL8wqA6quJwp6g+e5KSJyGOO9 3bQeaMw+Nk5z5a8uH0yzG2ItLyoHOB8mX+3l7Qo4S/IT73FHNMGP/KTx7UtwHA== X-Migadu-Spam-Score: 0.69 X-Spam-Score: 0.69 X-Migadu-Queue-Id: 2B3712A4AB X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="T/Mpg1ZL"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: EIJh66jiJmGv Hi! Liliana Marie Prikler writes: > Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer: >> Prior to this change, there was a discrepancy where a user could have >> disagreeing groups between the group and user fields (the user field >> being a record, which includes its primary group as a >> string).=C2=A0 This could have caused problems because the USER's group >> was being used to set the file permissions, while the GROUP name was >> serialized to MPD's configuration, and MPD would use it to set the >> group of its running process.=C2=A0=C2=A0 > Didn't we agree in v2 that we want to address this on the account- > service level? Unless the rest of this series somehow depends on this > patch, I'd rather delay it until we have a proper solution. I think we agreed the idea to have support objects for its group field was a good idea that should be implemented, but I declined doing this new work as part of this series :-). >> Synchronizing both is not practical, as it can easily lead to >> slightly different objects conflicting, again causing >> problems. > It might not be practical to do so inside the service, but note how > this has already become an effort in defensive programming. There are > easier ways to not make this a problem on the configuration level, > namely by specifying the same group for both user and group fields. As > far as I see this is even the default state of being if the user is > supplied as a string. I really don't like the group information being duplicated in both the user and a distinct field; it's an awkward API that raises more questions than it provides answers, in my opinion (non-intuitive). One of the reasons I came think this way is because a can differ by being a system group or not, which would make it easy to introduce unexpected, subtle variants. --=20 Thanks, Maxim