From: Jelle Licht <jlicht@fsfe.org>
To: Lars-Dominik Braun <lars@6xq.net>, 64203@debbugs.gnu.org
Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too.
Date: Thu, 22 Jun 2023 11:29:46 +0200 [thread overview]
Message-ID: <875y7f7sl1.fsf@fsfe.org> (raw)
In-Reply-To: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net>
Lars-Dominik Braun <lars@6xq.net> writes:
> * guix/build/node-build-system.scm (delete-dependencies): Remove supplied
> dependencies from peerDependencies field too.
> ---
>
> Hi,
>
> this is required to build a new RStudio. I’m also validating it does
> not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps
LGTM. You can consider adding a note to the commit message that thix
needed due to a change in how more recent npm versions deal with
peerDependencies.
Cheers,
- Jelle
next prev parent reply other threads:[~2023-06-22 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:38 [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too Lars-Dominik Braun
2023-06-22 9:29 ` Jelle Licht [this message]
2023-06-22 10:05 ` Lars-Dominik Braun
2023-06-22 10:23 ` Jelle Licht
2023-06-22 11:04 ` bug#64203: " Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y7f7sl1.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=64203@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.