From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gPgoCamGm2QM5QAASxT56A (envelope-from ) for ; Wed, 28 Jun 2023 03:02:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mEZLCKmGm2RlRgEAG6o9tA (envelope-from ) for ; Wed, 28 Jun 2023 03:02:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAC421CABE for ; Wed, 28 Jun 2023 03:02:32 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=sKqBvHX1; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687914152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gzvrssyV5PASBbk4pSIA/Zg2jVb0H2D2tGpGz+tnDWM=; b=MwFKTzlRH5d9jn2JZfScniaSD4Bhroe5NkkVn0T11CqFkFzt+VgpCiAh4b+6CwZpN35iLl 4Zq4+smhUWH1O/hCCilVKagXce6sqpcfugdlITHG8d771rYOrciPgt7Lf0mwi86NYBD9R8 gvZqIKb7uH2aIpXWSLkgl/y/zzw7T7vWLr5uoaurd5DvkKcaDHZ7NmBwmiH2ny+GL8VUEn UvxG5S+X/bT6/28zSe4P316ULEzPCyV7osZOFnP/f1OWmBwvzPBK2OAt+KaXI6qXtYZ9fb nztb5c6yYLvATcfFJBfaGFl0aBb43HQ8HqaJ2UcdVyQP49QIkV9Ge5qEiJDc9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=sKqBvHX1; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687914152; a=rsa-sha256; cv=none; b=WfbKh4zJkAvNXUsklroAFXg8YL28Ib+0BaN8Jx3D7JzpGRLHeutjbLhTUpP9z2CzMSGqPD pJGvXCIzQR+4lMUhCEtodN103aEwiWQt7Sr8sapJAXjt+pbsxqAb4BP2GIpbamv4jfQ1yG PnGNbrxJ6eh0ogvXVI9Bsu0/VjHCfPC7sHvfPZ2c9RSVJdv8hAHk0ta0ilhOd4+4lnZp57 b30QQ6TzGxg4BBHWcl00qz7og7ZX3ukO6brECz8jCAlfguThDbji+91beeoUajS7vcBlDG 7Oy85zAJuqn+vSuQvyJ1qgdrvUH2+kpnAPzpKGPeL2JRB+lbqVk/gL0l/k6QnQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEJZI-0007KT-Sd; Tue, 27 Jun 2023 21:02:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEJZI-0007KI-7o for guix-devel@gnu.org; Tue, 27 Jun 2023 21:02:00 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEJZG-00075D-6V for guix-devel@gnu.org; Tue, 27 Jun 2023 21:01:59 -0400 Date: Wed, 28 Jun 2023 01:01:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1687914115; x=1688173315; bh=gzvrssyV5PASBbk4pSIA/Zg2jVb0H2D2tGpGz+tnDWM=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=sKqBvHX1A4VVXu9M1Yj5VnvhegLR+RoQC0Dqb1CP3eG7V5YaS2A0PgjaREL6sVVDX mfXY25s3tRZjd6hcq0bJqrxJfRZ0M0xNoPSqKeDOKJdyBKknVXIjqyFXB7QJk1nwI6 pc2LfmjdBOgsj4ChN2ChWN8RRNnlBvg11WYRMynFCp9TqIIgIcZzjQc9Cvdw9LkMF9 Pa7tDoP2vfPOQ9/fPWrK89AvOfIfhjLMfs7sQLgfEtBcat6F9cU+W5Wb+7lPq+cyhx uRFXrWUYz+XLm7tw6KDwSr1PkFjlFiRrQER398RXpID3OzYg5hDzLgkCTHahjJgSOG Qwx5zF2gm5NJQ== To: guix-devel@gnu.org From: John Kehayias Subject: Re: modifying (rather than fully replacing) a build phases Message-ID: <875y788kne.fsf@protonmail.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.134; envelope-from=john.kehayias@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.45 X-Spam-Score: -7.45 X-Migadu-Queue-Id: DAC421CABE X-TUID: u+KtdJcnUqbW My question remains, but I've updated the patch in question to use #:make-flags (thanks to mirai for the idea), separating out these parameters from the build command and making this a much easier change. Still, we have examples of just copying some phase by hand to make adjustments, is there anything better we can/should do? On Tue, Jun 27, 2023 at 12:29 PM, John Kehayias wrote: > Hi Guixers, > > A question that is either relatively simple or else getting into the > weeds a bit, that I came across in my proposed patch > The general question is: how can I > modify a build phase without replacing it completely? More > specifically (as seen in the proposed patch) there is a build phase > consisting of just an "apply invoke" call where I want to remove one > of the arguments given. Is there a simple way to do this rather than > just manually copying and deleting that string? > > I would assume so, but I wasn't sure how to do it and couldn't quite > grep any examples. Some light exploring in the guix repl shows me that > package-arguments is a keyword list (not sure the proper terminology > in Guile) with #:phases a big gexp. Essentially I want to modify that > to remove a string. I suppose it is a question of manipulating a gexp > directly. (I'm sure macros can do all this but there doesn't seem to > be a need for that at this level, right?) > > Thanks in advance! > John