all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: iyzsong@envs.net
Cc: 宋文武 <iyzsong@member.fsf.org>, 65126@debbugs.gnu.org
Subject: [bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC.
Date: Wed, 16 Aug 2023 20:07:50 +0200	[thread overview]
Message-ID: <875y5e6etl.fsf@gnu.org> (raw)
In-Reply-To: <3eba9a4c0ca80fa57106cd50ba827915b9bd91a0.1691416969.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Mon, 7 Aug 2023 22:03:03 +0800")

Hi!

iyzsong@envs.net skribis:

> From: 宋文武 <iyzsong@member.fsf.org>
>
> This fixes <https://issues.guix.gnu.org/57677>.

s/This fixes/Fixes/, for consistency.

> +         (add-after 'unpack 'patch-gcc-reference
> +           (lambda _
> +             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
> +             (substitute* "cmake/compilerFlags.cmake"
> +               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
> +                ""))))

Well done!  According to
<https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html>,
‘_GLIBCXX_ASSERTIONS’ enables various run-time checks; I guess disabling
it is acceptable.

So… LGTM!

Thanks,
Ludo’.




  reply	other threads:[~2023-08-16 18:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 14:03 [bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC iyzsong--- via Guix-patches via
2023-08-16 18:07 ` Ludovic Courtès [this message]
2023-08-16 18:08   ` Ludovic Courtès
2023-08-20  8:01     ` 宋文武 via Guix-patches via
2023-08-20 18:27       ` Christopher Baines
2023-10-19 19:58     ` Ludovic Courtès
2023-10-20  9:59       ` bug#65126: " 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y5e6etl.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=65126@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.