From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EJcQFgeE9GSozgAAG6o9tA:P1 (envelope-from ) for ; Sun, 03 Sep 2023 15:03:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EJcQFgeE9GSozgAAG6o9tA (envelope-from ) for ; Sun, 03 Sep 2023 15:03:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5374D47C54 for ; Sun, 3 Sep 2023 15:03:02 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Li9HaKgn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693746183; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=kPazCQz/y+Adq8LNGxjrB1xJxBbFByZ6WziammRhVc8=; b=K31DcGlcBSqODMrLB+MOz4ZphjQ0qscSiks2gnleP05nag4xpxZpgGgyacXL0LQehGyqhd enFcMqKCG2Jic4qMc1aD3vKQfCMM+A5rIUQ0cCCJ3r53HlIdGXijzoiejahe9VmIuNzMhD dHvKSLq24QjEVxrumBhgzgUsq6rYkoBMAnEJasbifPRrPZSF+Dz4rjPA5UO9DabxCBQ+DS qB0qlWn3u4xeOjBVCkc2vCOQnW+MHLa32icHjSURCxN0KzzDGUTf54NgSM4+kKSLBXBFku MrH71yQGG8J7CXQP9SrWpil8GKd2gzzPFGOwfYiBai9tPC0tJPOD2XkbdU7DwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693746183; a=rsa-sha256; cv=none; b=U1QwZmnG3bIgGSKuJ92ApsJMiGiFcbue9t7HqnmYDfeqXo1QCeJhZX2yYBmT+h3es+3q6H 8M/fV4CdZiMMbX6jY94x5ESgDe//QGJKkKc26GDx9HHOVazMJ/wkLOxt49xB1HxnWa1BNa V2M1VF7mGn8W9yFD+lMgqRdOEbB97Dv4+yumpBBk8bqH3xtd3jQpF5XB7OC2Jso9J1pflI 7Bq/F/gnKE1dgGQSuAdn7YYOl744ZFQlA+Hoy715hCLfrSKj3VGAC+wAJIxUlItU6a1KVW GY31ePRC69DNHJ9FPXEcLiS09NAMD1pAwsZYWdBGPLDNvqYWJdNLyn+cl5l7+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Li9HaKgn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcmkg-0004Wc-Uz; Sun, 03 Sep 2023 09:02:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcmke-0004WP-Th for bug-guix@gnu.org; Sun, 03 Sep 2023 09:02:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcmkd-0002mF-Nc for bug-guix@gnu.org; Sun, 03 Sep 2023 09:02:51 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcmko-0000y8-1e for bug-guix@gnu.org; Sun, 03 Sep 2023 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65665: package-mapping with #:deep? #t doesn't get all the implicit inputs Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 03 Sep 2023 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65665 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ulf Herrman Cc: dev@jpoiret.xyz, zimon.toutoune@gmail.com, othacehe@gnu.org, ludo@gnu.org, me@tobias.gr, 65665@debbugs.gnu.org, rekado@elephly.net, guix@cbaines.net Received: via spool by 65665-submit@debbugs.gnu.org id=B65665.16937461743704 (code B ref 65665); Sun, 03 Sep 2023 13:03:02 +0000 Received: (at 65665) by debbugs.gnu.org; 3 Sep 2023 13:02:54 +0000 Received: from localhost ([127.0.0.1]:40003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmkf-0000xg-TR for submit@debbugs.gnu.org; Sun, 03 Sep 2023 09:02:54 -0400 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:48613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcmkc-0000xR-K6 for 65665@debbugs.gnu.org; Sun, 03 Sep 2023 09:02:52 -0400 Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6bf58009a8dso507161a34.1 for <65665@debbugs.gnu.org>; Sun, 03 Sep 2023 06:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693746154; x=1694350954; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kPazCQz/y+Adq8LNGxjrB1xJxBbFByZ6WziammRhVc8=; b=Li9HaKgnEOP+EWjLWmaztvFlGxVF9QAfPiOzMdrJ3lFdmD8Nxn4j5h0woy6CndT6HR PHrrz97jqbBv93bmUPPvElr4MjzgstIKiLyoZS+ey9Mu/aOeFXlta3C/l1bldUbT94lz 1ZQLsqSEZ7PVRfTikQAY6/a37bisIGs1RFXva/MEu3zKbRo0728e9sFxqkLbbxCFHK4y CYV5UgINz9CwtzZCELByuCCDMrU7XfAbZ9ZDiq5aMZRm6YyNmjwHGMAilXo3m23GZ4Pl jBeVEcm3VRAn784DhL0hLhd2+a9ogvcCKejMVGNKNAkpzrhxYtARbQPu32HTN+cbdrId mQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693746154; x=1694350954; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kPazCQz/y+Adq8LNGxjrB1xJxBbFByZ6WziammRhVc8=; b=bAI57qRGB/m9gyeY5QnjAadqbXaHl2qIXQvfACuhrLSy9JbAXN9cIrm2XcgbfGBdab fNzFFCYmd7Co5cJ9cFVYXuo1Lv9/WK7lzqqB2+/YHNjCGSe/A2tPtGEMRTW9X3bK1ak+ HOri6rTwBuLm+3b6PryF04Eq/P2B08aY1ymq8obIcFfZbK2fpJt1MOwnU4e1h7siep1/ D/0xe1Z3dDFIea/9PbLuCxGivNONMU2onbhISqezyoBBaAv8XS74qcZaRVaJ/rmBJBcD HhuIaGdcUpHb3qRaf9fj7oXYNHNjXfR6DeJ70+ernuNOGZkm5VNHmsD2WiYXICHuqQrI 95sQ== X-Gm-Message-State: AOJu0YyISkfYQsq97O8C+NwskE4NhqkvVzOZ4Tk9VTR3zMFhFAuqWsdP wU+2e0JtwxlQgt6+7HiGNHk= X-Google-Smtp-Source: AGHT+IEJ+DJ09Y4d9KyR23a+x1OKs797Cvr3jVlDvHVEZcjxhHg2H5MXhb3RUh/b2MeEoBP5fCiDlQ== X-Received: by 2002:a9d:4d84:0:b0:6bd:63b:4b21 with SMTP id u4-20020a9d4d84000000b006bd063b4b21mr7289622otk.15.1693746154390; Sun, 03 Sep 2023 06:02:34 -0700 (PDT) Received: from hurd (dsl-10-135-141.b2b2c.ca. [72.10.135.141]) by smtp.gmail.com with ESMTPSA id d4-20020a05620a140400b0075772c756e0sm2689580qkj.101.2023.09.03.06.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 06:02:33 -0700 (PDT) From: Maxim Cournoyer References: <87h6ofufy5.fsf@tilde.club> Date: Sun, 03 Sep 2023 09:02:31 -0400 In-Reply-To: <87h6ofufy5.fsf@tilde.club> (Ulf Herrman's message of "Thu, 31 Aug 2023 15:14:58 -0500") Message-ID: <875y4rwgt4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -3.62 X-Spam-Score: -3.62 X-Migadu-Queue-Id: 5374D47C54 X-TUID: Q1g0J88j0I5s Hello Ulf, Ulf Herrman writes: > #:deep? #t currently works by interposing a dummy build system that > lowers the package to a bag using the original build system, then > applies the supplied transformation to all of the bag's inputs, then > returns a new bag with the new inputs. > > The problem with this approach is that it doesn't affect the bag > arguments. This means that packages passed in as arguments may still > end up being used without being transformed. Worse still, packages > *not* passed in as arguments may end up being used *unless one is > explicitly passed in as an argument*, as is the case with > qt-build-system's #:qtbase argument. > > In short, the current approach of having the build-system lower > procedure leave the arguments mostly unchanged and letting the > bag->derivation procedure (the "bag builder") fill in lots of defaults > means that there are implicit inputs that cannot be touched at the > package level without adding special logic for every single build system > that does something like this. This is indeed sub-optimal! > I propose that we have the build system lower procedure (that is, the > one that converts from package to bag) completely fill in the argument > list with all defaults, and we modify build-system-with-package-mapping > to transform all arguments that look like a package or a list of > packages (or maybe even a tree containing packages). [...] > What do you think? Like Csepp, I like your proposition! I'm CC'ing the core team, in case they have something to add to it, but otherwise, we only need a volunteer to turn it into code :-). -- Thanks, Maxim