From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OMOHNnm4HmU3EwEAG6o9tA:P1 (envelope-from ) for ; Thu, 05 Oct 2023 15:22:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OMOHNnm4HmU3EwEAG6o9tA (envelope-from ) for ; Thu, 05 Oct 2023 15:22:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9FDCD4D4E6 for ; Thu, 5 Oct 2023 15:22:00 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=PdeO79Sv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696512121; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=e/Uqx+S4JKOlUa44TdUqIFGF6putoyCT+ovVvuOwV+I=; b=a5V06mDpn9LrIsI60wzC2LNVNMdq1N5Vh+kRhnZP2XWlSO/pySDX2odbPySCfVqhJEHzzw Ha90wTcjHB39f1ui+NHAa7mxC4UQxwgSE0j+abgjOdIEB9iMibZBMRbZLkFQrTfcSWXINi 0HTjLFaCZ30u/0h9Mp5iIPf/oD12lcY4P0gI695TbjIl1m9O5xN7XXMVjGuiR3oqWUP5Pd 2aC3rkxgbT3Djsx3A2zLarWFpQ2cTcykcBocs2wcyJa3rMT7TsByYHcFdez2P3ydTGoXJ4 +0v+xGwslJtMPs3JJ1uaGNQXBuhwZ5nUT0wZ63yam7rK+9TN/U6wC9vTyCMPnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696512121; a=rsa-sha256; cv=none; b=Lk38IHmGcUMRlOZsN5pooUwFy+kCVy5fyxHl9NNQpIOspupAWN6SpgVacuEAEkhcN+0Tlo MMyStJbkrU0aLIqCKe4d4k7z4S78O8eCjwrlPVzEx0qpU1BbHmm2PUQ5z0I1REkNjha229 /yUqYfuLvwwioqdJGVmfDeR13TTzzcFp0cY2mA4cMFLByU2XWLGqVSP4yFJoojrMKV2t/w RLLNZrw5uB0XTGspxXeApipDhCESLhIT+VRVsp8TJWduO2po5BIFaBSZgo4lPMJrqdH+nG Yr7Z/RQHYhCHTzf7Xyuy53Lo/f+y9LUUee7GNLC8onsG3SJAhfEuLXH12lmAog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=PdeO79Sv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoOIb-0005sz-4c; Thu, 05 Oct 2023 09:21:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoOIT-0005sV-03 for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoOIS-0007uc-BB for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:44 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoOIk-0003YJ-Gf for guix-patches@gnu.org; Thu, 05 Oct 2023 09:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66129] [PATCH 00/20] Split SuiteSparse into subpackages Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2023 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66129 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Elsing Cc: 66129@debbugs.gnu.org Received: via spool by 66129-submit@debbugs.gnu.org id=B66129.169651208413608 (code B ref 66129); Thu, 05 Oct 2023 13:22:02 +0000 Received: (at 66129) by debbugs.gnu.org; 5 Oct 2023 13:21:24 +0000 Received: from localhost ([127.0.0.1]:46264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOI7-0003XP-MC for submit@debbugs.gnu.org; Thu, 05 Oct 2023 09:21:24 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:57096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOI3-0003Wt-TI for 66129@debbugs.gnu.org; Thu, 05 Oct 2023 09:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=e/Uqx+S4JKOlUa44TdUqIFGF6putoyCT+ovVvuOwV+I=; b=PdeO79SvEqrasdZSRyPMRfvSe1RGNYAaRDCdH2usdkjO1UE2DVFX0bNS aP98gr1L71/rWaSwapAV9b5E14KrIu6rQ3KoUTe6u2ofowI/BeY/FCWkA zqNB5zlGAJuAIa4OE1lbdW83ZS+6QvjNwX2f6AdeIWOUjqscsnZH9oAZe k=; X-IronPort-AV: E=Sophos;i="6.03,203,1694728800"; d="scan'208";a="67870579" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2023 15:20:54 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (David Elsing's message of "Wed, 20 Sep 2023 22:05:16 +0000") References: Date: Thu, 05 Oct 2023 15:20:52 +0200 Message-ID: <875y3l6w97.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.76 X-Migadu-Spam-Score: 2.76 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 9FDCD4D4E6 X-TUID: /ol9oVa1micH Hi David, David Elsing skribis: > This patch series adds the individual SuiteSparse packages (as in > Gentoo: > https://packages.gentoo.org/packages/sci-libs/suitesparse/dependencies), > with autogenerated files and bundled libraries removed. Nice! > The GraphBLAS library is not yet included, but AFAICT it is not required > by any other package. It also makes up by far the most space of the > suitesparse package, e.g. on x86_64-linux, libgraphblas.so.7.2.0 is 196 > MB of the 201 MB SuiteSparse package. > > I think it would be best to keep the full suitesparse package until all > of its dependencies are updated and the GraphBLAS package is added, as > replacing them all at once would make the patch series quite large. > > Is the use of (@@ (guix packages) computed-origin-method) ok for > creating the individual origins or is there another alternative? Instead of: +(define (suitesparse-package-src name path) + (origin + (method (@@ (guix packages) computed-origin-method)) + (file-name + (string-append name "-" suitesparse-version)) + (sha256 #f) + (uri + (delay + (with-imported-modules '((guix build utils)) + #~(begin + (use-modules (guix build utils)) + (copy-recursively + (string-append #$suitesparse-src "/" #$path) #$output))))))) I=E2=80=99d suggest this: (define (suitesparse-package-source name directory) (computed-file (string-append name "-" suitesparse-version ".tar.xz") (with-imported-modules '((guix build utils)) #~(begin (use-modules (guix build utils)) (copy-recursively (string-append #$suitesparse-src "/" #$directory) #$output))))) That way we have something simple that doesn=E2=80=99t rely on a private procedure. > gnu: suitesparse: Tweak description. > gnu: Add suitesparse-config. > gnu: Add suitesparse-amd. > gnu: Add suitesparse-btf. > gnu: Add suitesparse-camd. > gnu: Add suitesparse-colamd. > gnu: Add suitesparse-ccolamd. > gnu: Add gklib. > gnu: Add metis-5.2. > gnu: Add gklib-suitesparse. > gnu: Add metis-suitesparse. > gnu: Add suitesparse-cholmod. > gnu: Add suitesparse-cxsparse. > gnu: Add suitesparse-klu. > gnu: Add suitesparse-ldl. > gnu: Add suitesparse-rbio. > gnu: Add suitesparse-mongoose. > gnu: Add suitesparse-spex. > gnu: Add suitesparse-spqr. > gnu: Add suitesparse-umfpack. Apart from the trick above, this looks great to me! Could you send an updated version? Thanks, Ludo=E2=80=99.