From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WOyiNr9kNmWtYwAAauVa8A:P1 (envelope-from ) for ; Mon, 23 Oct 2023 14:19:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WOyiNr9kNmWtYwAAauVa8A (envelope-from ) for ; Mon, 23 Oct 2023 14:19:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9838939186 for ; Mon, 23 Oct 2023 14:19:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=nKfruaE0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698063551; a=rsa-sha256; cv=none; b=heAMPHCdz4p6KLJRsMhAInepjkBlHFfx7lRcz2+gpR5lXc75YJWWlKupSewwOWDTMo4uLg jKDwHRZosdSiAr877thdYTAzy2x5isY7W9HlNqqu/dosCbNBF01qXX8BSyW7Ags67cqT2j Uj2kn7h2iaM2goiPkPy40e59a582ox5GTun1yD+sIO0YigCqI5Ih4SUqDiXJF77GhO/xnD cX1kt6DN+R7la1F/5rvmxwrEsx+//CZEeNRdoWspt2gNZlLLKgvFT1wtuqwVm1/HK5q0y8 BKLF2P2wChNJlgpCZ94SBUeh/sGyyVa8QDwmfJmsjgzSBUe+5JMXPQBg1mW+uA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=nKfruaE0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698063551; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vZ5wWIwt+8DNQIKWomqdDMg43E8JnrDuQQ5Ed5fG8r0=; b=hOW83EDqgQxk4nV7Oj8hOJdfRz2xA6cctXq4XrUe+xD6zY1NcbZrAFvpyyS/LX3upzKw5W palE40QBD2ay98x5XIGJwxTG4wwaXQpHYaXzQ2nsLoteUse156MM3ZFD6Vh1GIgxFK0Yh3 d6Sjr64YaxqQY681NMnnzBeFhWCtCUIoJvtY0ZhJuWlRXndXxzK21VHHBI9QHxMCd/moNA ONv8HwEROLevjfGbAiFpzQwd6RcaPjJMRwUbv5jarVlc1gvjEsJd33lyPMFBzq1BL+qfBe KHDstgXznfErAbobKv/RLFJBt6QLFpRvKu2dYjSzS0vvHG0eR5tPq32JoyLgeg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quttF-0002R8-2F; Mon, 23 Oct 2023 08:18:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quttD-0002P5-1M for bug-guix@gnu.org; Mon, 23 Oct 2023 08:18:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quttC-0005Vh-OX for bug-guix@gnu.org; Mon, 23 Oct 2023 08:18:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quttf-0006oR-LJ for bug-guix@gnu.org; Mon, 23 Oct 2023 08:19:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65225: [bug#66640] [PATCH 0/2] Build profile hooks for the right system Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 23 Oct 2023 12:19:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65225 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 66640@debbugs.gnu.org Cc: Josselin Poiret , 65225@debbugs.gnu.org, Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 65225-submit@debbugs.gnu.org id=B65225.169806350126086 (code B ref 65225); Mon, 23 Oct 2023 12:19:03 +0000 Received: (at 65225) by debbugs.gnu.org; 23 Oct 2023 12:18:21 +0000 Received: from localhost ([127.0.0.1]:49282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutsy-0006ma-Ed for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:18:20 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:39990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutss-0006lA-U8; Mon, 23 Oct 2023 08:18:15 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-408434ce195so8709995e9.0; Mon, 23 Oct 2023 05:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698063460; x=1698668260; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vZ5wWIwt+8DNQIKWomqdDMg43E8JnrDuQQ5Ed5fG8r0=; b=nKfruaE0nUI84mxK/wuRQ+bPl/fKkNA7txlI5WAQz0+U7thYvkq6MQFWpU31EeJQtW prt5Qh5t18zfsa9+3lW5APsw+A7ZZ4VC2A+rEbvAwJ3uJPfsM4bqewHGyTQV2fngO65s ntYOwD5L2WgOXxG8PQUIk78w/GAMmmCufM9eb1U/y2BA3zx/d/YG0+fJYQ2yfNtiujTh RORtjMdVxSWQ7NM5cp5gWZaBxK1sL8HbUFEsv2Wd+cWzXQgiB+pmn6vHhOz+QQJgBpy7 P3efNRmvyvElWZ/q3PiWYnZJnX2Mos3Dqt6LRp6bIqigabL/Af/QjSpO7NaSULwTGH4S LEPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698063460; x=1698668260; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZ5wWIwt+8DNQIKWomqdDMg43E8JnrDuQQ5Ed5fG8r0=; b=oLfFmknH4HHZNzOx5nQkoQpttj++H+PC11KE+Kr5YMn9Ml9qv+70U81CrCW6dDu5Uk DLFT74Of53HwoUc2xk9ITylUkp5s1InV3zxfBDvJbY5ijCVbRoe3DLnh3FdICMaGsVXG 6/dWnVCRLgJD+dHUJAGdkINT2o+vfpJ91tMCkpv52G4IZu4rGlEW4FiZ7/kbZHtuVIkt 3DbmIpOVNfsb+RKVF+cZcpiv58WlRRH8R/HtkEsxlv/pjIYC6TAkTeRo5tkvZ9RmqP4W n9U/1Fi2ZZfQQXS7E4Hi++yfI9fdpRYK1jU87+f4jzbT2pLDcBL65p9kTdFCkueSMRlI oBqg== X-Gm-Message-State: AOJu0YywLPKiCBGnPPRQPQT/jOioxvk3g7oE513o4z6fKrO+0MOXHi5O zMya1YhBJtH1NMMU9xe2alA= X-Google-Smtp-Source: AGHT+IEzIy3tK0d52s4ykcJbyIfZr3403YU5kF7+O+Dx/r1TNzP6x8Q7XVQiBRIexjJ7XeKQa7nX5A== X-Received: by 2002:a05:600c:1c22:b0:408:3836:525f with SMTP id j34-20020a05600c1c2200b004083836525fmr6872932wms.1.1698063460128; Mon, 23 Oct 2023 05:17:40 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id bh9-20020a05600c3d0900b003feae747ff2sm14245748wmb.35.2023.10.23.05.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 05:17:39 -0700 (PDT) From: Simon Tournier In-Reply-To: References: Date: Mon, 23 Oct 2023 12:36:48 +0200 Message-ID: <875y2xlj5r.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 2.87 X-Spam-Score: 2.87 X-Migadu-Queue-Id: 9838939186 X-TUID: PNEyw5beKMX8 Hi Ludo, A naive question about the default value. On Thu, 19 Oct 2023 at 16:48, Ludovic Court=C3=A8s wrote: > packages: Add =E2=80=98system=E2=80=99 parameter for =E2=80=98set-guile= -for-build=E2=80=99. The change reads, --8<---------------cut here---------------start------------->8--- +(define* (set-guile-for-build guile #:optional system) [...] + (let ((guile (package-derivation store guile + (or system (%current-system))))) --8<---------------cut here---------------end--------------->8--- > profiles: Hooks honor the #:system parameter of =E2=80=98profile-deriva= tion=E2=80=99. The change reads for all hooks, --8<---------------cut here---------------start------------->8--- + (define* (efi-bootloader-profile-hook manifest #:optional system) [...] (gexp->derivation "efi-bootloader-profile" build + #:system system --8<---------------cut here---------------end--------------->8--- Do I understand correctly when I consider that =E2=80=99(efi-bootloader-profile-hook manifest)=E2=80=99 pass #false as =E2= =80=99system=E2=80=99 and then it is =E2=80=99set-guile-for-build=E2=80=99 that sets =E2=80=99(%curre= nt-system)=E2=80=99? Somehow, my question is about the readability of default values. Why not, #:system (or system (%current-system)) for all the hooks? Cheers, simon