From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uK6fHKgJhmW2igAAkFu2QA (envelope-from ) for ; Fri, 22 Dec 2023 23:11:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id OAyqFqgJhmWsiAAAe85BDQ (envelope-from ) for ; Fri, 22 Dec 2023 23:11:52 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=fwgyCj70; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1703283112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=4V949yqYxOTNxiTYPqRVEZr4h/YjcFRIeFuKluGjCYc=; b=RkE4UYpKp1/f8jH2hqp/dcGJYNEeuE6AQIa19+OB9jbPBVGKjGzNsY3tEvXHMsj4n9OI64 2gUS2xGISfmGufMUIO7sWkWe1oyJxJ3ufCxcpD+Q9BltlPMr9T75q5kpDU5161jlet85WR ek4TjvacC6B0fta8p27fInTxfDH90KBkTXkJwyhWyCf7gnSBGi19fWYmDx96A5Wj9pcRMz 3N47WXmRkMwWDWSheOGH6zymxwBdH27vh6l4fHirC7e9Yfi2OHpOyqjtBraBvX9Ebb6LLO 0eS3/j+PDp3vmCMq+OfMDMM+8OMw1btXkjeAHlkLknZLxUGYlDhcYpTVyFgcAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1703283112; a=rsa-sha256; cv=none; b=h7rz5rljLWim4sLD2TYB+nnWFdWjX4e9lfEiYonS+lhXiPi3RkwoYTpdRR915LwGsdhSIQ rkB6dRKcQVE39ye1SiSH1GoMPrPgZJIZ9Y6efn9x2BluwD+baNDfKkDfvQnEswD+oiVBVI 5VJf5+p0GS1lS3kioHETnJ6tPhjq/2uLtmqemxe+W5pdpjnMzaswVN19aeIE50mzGRYokK LviSowbyWgpb7wd2LAIQCcG4MP4MJ5vB+wC095XqJkKbFmKcEhWxCc7lil45d5UDxUrq4Q JA9tiTEirvgv8F6260wgAENxkGTckf5Ggh3tVAUKcga5dVVZWPS65os1BsReQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=fwgyCj70; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3CC37214B1 for ; Fri, 22 Dec 2023 23:11:52 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGnjc-00087w-EG; Fri, 22 Dec 2023 17:11:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGnjb-00087d-33 for guix-devel@gnu.org; Fri, 22 Dec 2023 17:11:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGnja-00077A-If; Fri, 22 Dec 2023 17:11:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=4V949yqYxOTNxiTYPqRVEZr4h/YjcFRIeFuKluGjCYc=; b=fwgyCj70X49QOzA51mGd 10tM7wWb8jtBkp6NVFMs8D9Qmj6dDfb9scn4jO0bCkMfa3sRRvEYyFwykQOIm3jZuom0GWpdUiFA0 y/VFCcNCwUBSmm6jW4KShM0lFiES+Vy8giNCy9+RQZBsKrlPqEv+s7cdg/QZhcFSOIp75ByMCKizt Uxj+O2m62LPOsF4bJmwJvLMRJONBLbNup51BSGKJ63V+u2cAOU3Q9OpoHTX/DwIYOqfWmeLxCK9/C EJ2vB2W4PZa76nD9Fn8jm/jeChp48NA5EMTCYf6YiRIex8DgM4vQyeS2m7Lst7QKZ9jRCG35VRczA vbl8vjA3VrrIdQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Oleg Pykhalov Cc: guix-devel , 64173@debbugs.gnu.org, 62153@debbugs.gnu.org Subject: Re: [bug#62153] Merging guix pack changes for Docker containers packaging In-Reply-To: <878r9xb2e6.fsf@gmail.com> (Oleg Pykhalov's message of "Sun, 27 Aug 2023 06:16:49 +0300") References: <20230313003012.14325-1-go.wigust@gmail.com> <878r9xb2e6.fsf@gmail.com> Date: Fri, 22 Dec 2023 23:11:07 +0100 Message-ID: <875y0p99c4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.34 X-Spam-Score: -9.34 X-Migadu-Queue-Id: 3CC37214B1 X-Migadu-Scanner: mx12.migadu.com X-TUID: HpCb8/ZnTqc/ Hi Oleg, Apologies for not replying earlier. I occasionally get reminded of the fact that building single-layer images is a problem, but only now did I take the time to look more closely at the latest version of these patches. Oleg Pykhalov skribis: > I would like to merge 62153. After 64173 will be merge, merging 62153 > is not possible without conflict resolving with Git. > > 64173 introduces =E2=80=98%docker-format-options=E2=80=99 variable. With= this variable > it's possible in 62153 to replace =E2=80=98--image-type=3Ddocker-layered= =E2=80=99 with > =E2=80=98--docker-layers=3DN=E2=80=99 option, where: > > if =E2=80=98N=E2=80=99 is zero, then use current non layered format > if =E2=80=98N=E2=80=99 is bigger than zero, then use layered format OK we should do that. However, the original submitter of #64173 apparently dropped the ball as we were approaching the final version. Would you like to adopt it and submit/push a version that incorporates the latest comments? Alternatively, we could do the opposite: merge the Docker layer patches first, and then rebase the =E2=80=98%docker-format-options=E2=80=99 patch, = after which we could add the =E2=80=98--docker-layers=E2=80=99 option. What=E2=80=99s your preference? > Number of layers specification is nice to have, because Docker layers > are limited. So if user would like to modify a Docker image by adding > more layers on top, then hacks like squashing layers are not required. > Also, it will be possible to delete code which builds non layered Docker > image without deprecating command line options. Agreed. Anyway, apart from the stylistic issues I reported, v4 of this patch set looks great to me. (For clarity I=E2=80=99d have preferred three patches, = one for (guix docker), one for =E2=80=98guix pack=E2=80=99, and one for =E2=80= =98guix system=E2=80=99; but it=E2=80=99s really a detail, let=E2=80=99s not block this patch series any= longer.) Thanks, Ludo=E2=80=99.