From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qGX5B9xXnGUHJwEAkFu2QA (envelope-from ) for ; Mon, 08 Jan 2024 21:15:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KPj9BNxXnGV1GgEA62LTzQ (envelope-from ) for ; Mon, 08 Jan 2024 21:15:24 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Mdw+qdYq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704744924; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wu6A1y6Ms0pkBS6G/RRGU+nvvH0VkiQ1gPavroaZLcg=; b=TDDZA+3ete0Wiym0VpEubWYXEhseEOJoCZv+CYuCpBCxHM29E+JmtES8IJb/PhNTIyDCs0 8fWyN12FesVUig3tpmJmUg+IM+Cnf+ShX8bAa2dDrb6kOWFxDHW1+GYiGZ4830G4zYBOaV hRkTMX1huJk4X6WjrjdVkw2Z0i+MlLBZQfzQn1IgxCBknAnmgSt8STqV1JQyZvmnhyy15a 1XVjolvR9dDYRp9eW8SqQeGeENy48KGya2TZROYOm38BYb6+PRTQsXGTULTLj2SGtanNT0 sNHm069s0eNbxVSJcOUHTTr1TrFHicBSfeM9pd8eO7N8HG7OcLyyYXSqn1QFHg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704744924; a=rsa-sha256; cv=none; b=A88b8o9HmIb0xFXWBsLHQbA7gSLEqs94gjHf5ctAoXu8PMR2l5HE85HUjKA38jaq49eURL GxjbSuzu69aISDl6qh51DNVn3gncntzYCfkDyj2KKB1u6NFVEtY46rsvrz5bHZ4cO4Z6N0 yE4VnSuEK5yxYm7+2SUIAQorUDboXjsyUr76HOUWURnK0gL/Jt2tnGL1UxiNdWwkhOeEPx 5rboZZCBwcX82Nvo6b6jnHP0bFaZPaCwz0iM8TK3Jp5J2TWPA90RLJ9B8Y2+F9pgf8J3wd dTjYbFtK/z4v9gpzJ6xVRzDb02VAoUMq+ZScoJt7zUmqeJDVxTUXrW+p7pHDuA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Mdw+qdYq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EADA211D66 for ; Mon, 8 Jan 2024 21:15:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMw1R-0000rm-52; Mon, 08 Jan 2024 15:14:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMw1P-0000rO-Om for guix-patches@gnu.org; Mon, 08 Jan 2024 15:14:55 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMw1P-0004hh-Gq for guix-patches@gnu.org; Mon, 08 Jan 2024 15:14:55 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMw1V-00013o-Rf for guix-patches@gnu.org; Mon, 08 Jan 2024 15:15:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68263] [PATCH 0/2] libsmbios: Restrict to only supported systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jan 2024 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: Vagrant Cascadian , 68263@debbugs.gnu.org, Efraim Flashner Received: via spool by 68263-submit@debbugs.gnu.org id=B68263.17047448904045 (code B ref 68263); Mon, 08 Jan 2024 20:15:01 +0000 Received: (at 68263) by debbugs.gnu.org; 8 Jan 2024 20:14:50 +0000 Received: from localhost ([127.0.0.1]:37706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMw1K-00013A-8i for submit@debbugs.gnu.org; Mon, 08 Jan 2024 15:14:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMw1J-00012y-4x for 68263@debbugs.gnu.org; Mon, 08 Jan 2024 15:14:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMw15-0004Wt-J6; Mon, 08 Jan 2024 15:14:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wu6A1y6Ms0pkBS6G/RRGU+nvvH0VkiQ1gPavroaZLcg=; b=Mdw+qdYqWOn7eklD1IG6 eggnikcT2zA42zKdEl+CcwCgCrbZ1Ss3GveAKjua/mFaTQLjF7TDT/oUSZ9x58Mr8TqyUQH7barkA mY3GqPBgQ4bxKqlFh1OM5INqJcslji2Fk0I5F/nQZx15bt08AWdi0Xhj+tDG3zbtRxXmuHsGKZkSE Z+/3I7ElcJ+KD3L0jEGCdoYNxxfRrLEEFN7M/68AOGayEJxx0KRfgivBmXC5djrgDaoHPFPTsPoXd LA+1l4hk+sX4s3Kv5XC1viebmZdpLmx0FznfXZ5lmoTl+WyI05sPwTDvgLPSDByjRRCFkbKZ8Bkov j2Su5jmBImZlCA==; From: Mathieu Othacehe In-Reply-To: <871qar7k7n.fsf@simonsouth.net> (Simon South's message of "Mon, 08 Jan 2024 13:29:00 -0500") References: <87y1d0rki4.fsf@gnu.org> <87jzok87y3.fsf@gnu.org> <87cyub7llv.fsf@simonsouth.net> <871qar7k7n.fsf@simonsouth.net> Date: Mon, 08 Jan 2024 21:14:29 +0100 Message-ID: <875y038twa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.01 X-Spam-Score: -7.01 X-Migadu-Queue-Id: EADA211D66 X-Migadu-Scanner: mx12.migadu.com X-TUID: AZ9mcdxgwtKQ Hello, So, here is what happens: You are adding --8<---------------cut here---------------start------------->8--- (supported-systems (list "i686-linux" "x86_64-linux")) --8<---------------cut here---------------end--------------->8--- to libsmbios. That is fine, it prints: --8<---------------cut here---------------start------------->8--- package libsmbios@2.4.3 does not support aarch64-linux --8<---------------cut here---------------end--------------->8--- when running `guix build -s aarch64-linux libsmbios`. It doesn't print anything when cross-compiling this way: `guix build --target=aarch64-linux-gnu libsmbios`, tries to cross-compile and fails because of the header as you noticed. It makes me think that we should turn `supported-systems` into `supported-platforms` so that we get the same kind of warning when trying to cross-compile. But that's another topic. Now regarding your second patch, this part: --8<---------------cut here---------------start------------->8--- (if (supported-package? libsmbios (or (%current-target-system) (%current-system))) --8<---------------cut here---------------end--------------->8--- will actually call (supported-package? libsmbios "aarch64-linux-gnu") when cross-compiling, which prints this error message: --8<---------------cut here---------------start------------->8--- ice-9/boot-9.scm:1685:16: In procedure raise-exception: dynamic linker name not known for this system "aarch64-linux-gnu" --8<---------------cut here---------------end--------------->8--- It has nothing to do with ABI break and .go files. It is just that supported-package? is expecting a system not a target. What you could do is rewriting this part as: --8<---------------cut here---------------start------------->8--- (if (supported-package? libsmbios (if (%current-target-system) (platform-target->system (%current-target-system)) (%current-system))) --8<---------------cut here---------------end--------------->8--- which works as expected because the target is translated into a system. A better fix would be to have supported-package? deal with both systems and targets internally. Then fwupd cross-compilation fails because other dependencies such as gts fail to cross-compile, but that irrelevant here. Thanks, Mathieu