From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id iNLJMAgJQmZwlwAAqHPOHw:P1 (envelope-from ) for ; Mon, 13 May 2024 14:35:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iNLJMAgJQmZwlwAAqHPOHw (envelope-from ) for ; Mon, 13 May 2024 14:35:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IRivrjoC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715603720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RciltivjIDzuUyHEG5NAKktcJCu2atzJ4z4Ava/EGWk=; b=hu+Y1PJht1xR1OwGG2v+ZJWba87V3ySGCwN6NCj2DOuXuSAH/udexmeikIzIu3XPJaYqPo y5GvOgIk8PJxiNlXB+h3202D24xpgGJcxzfOK6EOmZIuOAdtmt/RdNbbjfh8f2/92P/rwH KrU0H7vQImbwLwGPaAAoRVD2reW/3W5OhsjPXryY9mykrL+qTESHJUOLzBni89XuGziezn XjMYzQxVr7LkIEy1/dDYFvm57yuRkStJCNcnJ76oelNTCAG0DcFy6t89YhmKjw2c3CiUKH dYhdkRLrpFzW42G71vqpXMFEt1mPvRYmz4gvM/AIyOtAGqpc0DTOcvjql9w54w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IRivrjoC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715603720; a=rsa-sha256; cv=none; b=YFIvKN9bE3b9ucvqda0X8gS0/LOc6VPs0FiYILgz8n9Av28mu0GeJV6ZNM6wtqCPtirkIJ 5qpfZeI80iUC5GYAkWGElfGHnDezz6qYx8FLxP7f69IE2B3jvwFol4sgxsdiNzvEd485Xz InFY7XoRueTJwVTWntW2ENeyUjmhGk8vU7jacPOFK9b43xexZVCfwp9L8yyFWQ1HRd/pif G06/QEPwYjeQn2TUsRueimCwcUd7SZsxV+XHAWzlvt8uKQW9RwrnOpzyA7eHk1eh3RA/HU t+CqDR/ErKWwNbQGEHUnOyre/39ocjrlqip7cU259rsL9XyHCz4SV/d1YfMWow== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8481F54BDA for ; Mon, 13 May 2024 14:35:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6UtU-0004zA-3S; Mon, 13 May 2024 08:35:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6UtS-0004wr-CZ for guix-patches@gnu.org; Mon, 13 May 2024 08:35:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6UtS-0004nn-2H for guix-patches@gnu.org; Mon, 13 May 2024 08:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6UtS-00016V-9K for guix-patches@gnu.org; Mon, 13 May 2024 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70563] QA review for 70563 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 May 2024 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70563 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves , Andy Tai Cc: control@debbugs.gnu.org, 70563@debbugs.gnu.org Received: via spool by 70563-submit@debbugs.gnu.org id=B70563.17156036924220 (code B ref 70563); Mon, 13 May 2024 12:35:02 +0000 Received: (at 70563) by debbugs.gnu.org; 13 May 2024 12:34:52 +0000 Received: from localhost ([127.0.0.1]:60702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6UtI-00015z-Gf for submit@debbugs.gnu.org; Mon, 13 May 2024 08:34:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6UtE-00015q-J9; Mon, 13 May 2024 08:34:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Ut7-0004hJ-0Q; Mon, 13 May 2024 08:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=RciltivjIDzuUyHEG5NAKktcJCu2atzJ4z4Ava/EGWk=; b=IRivrjoCP1Ao+w8LaR3i aYnFkKGb4mf7TKA5o5hdxCT4DmmlKQfbnE6kd4P5rF40SMXDF+FL5Otcx/zudvfwbhjrapRnDNf/X 57yNhaIS06+U5E9S0kN1kSVfO9FDxHVpcOwvx2I/VSgM0pBnIMAPYqcUZC/xOPp9Yuh+J2y9iN6al nuVXNxghN9e5Aj0Z4MiFT87dR7RNt1DgD/KwBr+MMFNQafb9mx7IZuOWfZ1JA1XOVnhUtvFGnqZDU kHPpJAbQpOACXSGY7fLODcG0kTFSEU+A9yVyAHxXMTlH1QMPNb1nICHA2/xmTYwEnUz1zIMPrmiH9 jDiorcd3dM2J+Q==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <877cfyci07.fsf@ngraves.fr> (Nicolas Graves's message of "Mon, 13 May 2024 09:01:44 +0200") References: <356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org> <877cfyci07.fsf@ngraves.fr> Date: Mon, 13 May 2024 14:34:37 +0200 Message-ID: <875xvhc2le.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.97 X-Spam-Score: -5.97 X-Migadu-Queue-Id: 8481F54BDA X-Migadu-Scanner: mx13.migadu.com X-TUID: QYH18zReiPSM Hi Andy, Did you receive Nicolas=E2=80=99 message below? Nicolas Graves skribis: > user guix > usertag 70563 + reviewed-looks-good > thanks > > Guix QA review form submission: > The description probably needs a little bit more precision. In particular= , it would be good to include the statement "PKCS#11 is the de-facto s= tandard to access cryptographic devices." or something like that.=20 > > Otherwise LGTM. Note that despite being marked as =E2=80=9Creviewed-looks-good=E2=80=9D, Ni= colas makes a suggestion that I think is worth addressing in a second version. Thanks, Ludo=E2=80=99.