From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AMFeJhGf1GYbDAAAe85BDQ:P1 (envelope-from ) for ; Sun, 01 Sep 2024 17:06:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id AMFeJhGf1GYbDAAAe85BDQ (envelope-from ) for ; Sun, 01 Sep 2024 19:06:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HmThKUC9; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=hKspKhSK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725210385; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5jl7IVourHEtttquYdaxyep7eunSb7m/8agQtbb70+c=; b=ebtfkexrHCs09HQbshD7DVJiChQolHVgmmKCnrOIXGk7/Q7BVKcxv0f97Xl9ZY919BJvrF S88MlKUYEMXOvzIv4I7da53SWJMpk4b6eGtgvzOXsRYU3/CPitRLJfJ7KZ9uQ8uXOqX/G+ uF89wy2pTU5lQVnHDHJCF4GDZ/ziQfXSQWQ8i0m4BdBh7rIRinvrU5+wTeBxyKlvc9g7Hz S3Ek+zLRyRsWU2hDHZpm6DMc4D84FT/KTrWf0sYswKZAs+p8eUr4LVF3wy53ehDnHZgBJi k6cqcsBTmSbi6gl99U1EyVmUesoICJ5nB+ankv2sIcgHJnYbFAKBDN2wjrGQRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725210385; a=rsa-sha256; cv=none; b=T4e4zSEwAK5vl+nDazdW28KPGCkUffBxsvnU7WosK5eNzIuzAlUz7Dep9Za6tU8uI93oQk 81/RjmbNT9l1itfgER+RzG72Tsy8rKnWO4sjHKkjgCmLqlRxn0HcGiGsWxPOlKSE9eBOxv GcCps1RI8H0oTsJYEQlr2zwWH2aWijfJ7wdUoxohnb7I4j7xka8IrY+lZmYDt5zsQiEtBt +uoNxAEYh0vP5QKeoATep0A8NLUGhVrpNCB90LO0+eVdkjf60SgfuVp+a8V3wav763bWna dHplbxA5M+BxtMZ4FdGfFRvHVMprXa621TnYDqVuP6WngwA95m2RW1PNs8V5Rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HmThKUC9; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=hKspKhSK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7010F3AC57 for ; Sun, 01 Sep 2024 19:06:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sko1c-0001KZ-5V; Sun, 01 Sep 2024 13:06:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sko1b-0001Jj-00 for guix-patches@gnu.org; Sun, 01 Sep 2024 13:06:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sko1a-0004tu-N1 for guix-patches@gnu.org; Sun, 01 Sep 2024 13:06:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=5jl7IVourHEtttquYdaxyep7eunSb7m/8agQtbb70+c=; b=HmThKUC9dhgdldk0jmiBecciFrZEpoQO9oH+QHZL1fz+g7FJ6KtARYhPvCWTryOmaa+ebYmPxht1/ymANa+lps+WRO56kzV/Zmz8CDN/fhKw6SpUm6FhXfQ4OQdpMBmfUpblwTAcTUX9neeVfJ0JKz2soIOPSjddJH8CpzqTqjWRVCzwv9NG2cKj5wezE9YZ6+c4MeLUkCdvRadjMxyvLimtrj9vU8BDHVKs4S0/voAroC86T6UwZt7P00yPSVEY5UXHuL3ywPfrYQz+7CWhEcpVzGr6AhA6khAHpPed+dq1QzrVdC1I03aomvRlAYxUg+GC660Kt3QegVLblu59Ew==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sko2Y-0006sM-C7 for guix-patches@gnu.org; Sun, 01 Sep 2024 13:07:02 -0400 Subject: bug#72935: [PATCH] gnu: python-mpv: Update to 1.0.7. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 01 Sep 2024 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72935 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: 72935-done@debbugs.gnu.org Mail-Followup-To: 72935@debbugs.gnu.org, me@tobias.gr, ian@retrospec.tv Received: via spool by 72935-done@debbugs.gnu.org id=D72935.172521040426394 (code D ref 72935); Sun, 01 Sep 2024 17:07:02 +0000 Received: (at 72935-done) by debbugs.gnu.org; 1 Sep 2024 17:06:44 +0000 Received: from localhost ([127.0.0.1]:38025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sko2F-0006re-Rf for submit@debbugs.gnu.org; Sun, 01 Sep 2024 13:06:44 -0400 Received: from tobias.gr ([80.241.217.52]:54888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sko2D-0006rT-DP for 72935-done@debbugs.gnu.org; Sun, 01 Sep 2024 13:06:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=5jl7IVourHEtt tquYdaxyep7eunSb7m/8agQtbb70+c=; h=date:references:in-reply-to: subject:cc:to:from; d=tobias.gr; b=hKspKhSKXDw6ePW5mSMvHoP3ZtMU6jyeByF u3eZtt+beSVjho0ukXiOn05OkSqtj9gsrigSqGGKMinMfz/kmoUJ2Sl+YOmVTCNnAo+Vp7 ylhzWcWvHxRwhqDSPMHD0UjS1Yqh2t/zyjKpnWYV66EnWQPgCZjsAIueuvsAtlIi7z9ED2 p+rjyJPO0DUvqrIVqApuZ81/C8BH+82UkKMmfFT1pNlU4ACoHWY0k0MNsGymjzGbh9SIp5 X7fm1mS01QaLMGZEGVjJ6pXXp3jbpWlox+rVCvbLtKsiW7fRdrdC5MRjvZ/RLo+THsHTyB zMHJRgvO61d0c6XFVH4EKP6U5VQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a0429074 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 1 Sep 2024 17:05:36 +0000 (UTC) In-Reply-To: <20240901154647.7917-1-ian@retrospec.tv> (Ian Eure's message of "Sun, 1 Sep 2024 08:46:47 -0700") References: <20240901154647.7917-1-ian@retrospec.tv> BIMI-Selector: v=BIMI1; s=default; Date: Sun, 01 Sep 2024 19:05:35 +0200 Message-ID: <875xrfi9sw.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.58 X-Spam-Score: -5.58 X-Migadu-Queue-Id: 7010F3AC57 X-Migadu-Scanner: mx11.migadu.com X-TUID: 1gWtwmFh8f+K --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ian, Ian Eure =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/python-xyz.scm (python-mpv): Update to 1.0.7.=20 > The recent > core-updates merge broke the previous version of this package,=20 > so I updated to > the most recent upstream while fixing the build. Upstream=20 > switched to > pyproject, so use that build-system and add packages the tests=20 > need. Upstream > added an environment variable to skip the test the previous=20 > package patched > out, so use that rather than changing the source. Thanks! I rewrote this to follow our more formal change log=20 standards: gnu: python-mpv: Update to 1.0.7. =20=20=20=20 This fixes the build after the core-updates merge. =20=20=20=20 * gnu/packages/python-xyz.scm (python-mpv): Update to 1.0.7. [source]: Remove snippet obsoleted by PY_MPV_SKIP_TESTS. [build-system]: Switch to pyproject. [arguments]: Set newly-available PY_MPV_SKIP_TESTS variable. [native-inputs]: Add python-pytest and=20 python-pyvirtualdisplay. > + (modules '((guix build utils))))) Origin [modules] are only ever used for snippets, so with the=20 snippet gone this served no purpose. Removed. > (arguments > - (list #:phases > - #~(modify-phases %standard-phases > + (list > + #:phases #~(modify-phases %standard-phases After our chat on IRC, I reverted this dubious =E2=80=98guix style=E2=80=99= =20 indentation change. This makes your diff a breeze to read and=20 shortens some lines that had grown over 80 characters. As things stand, I don't recommend running =E2=80=98guix style=E2=80=99 on= =20 existing code. Maybe one day. > + (native-inputs (list > + ;; needed for tests > + python-pyvirtualdisplay python-xvfbwrapper=20 > python-pytest)) I added the newlines that we both preferred. Line comments (;;) are full sentences, so ;; Needed for tests. Pushed, minus some other =E2=80=98guix style=E2=80=99 noise, as=20 a977900d76b7585c401222a3ce8bbb82e5f6da45. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCZtSe4A0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15+0UA/0dM6rjnsTXmIoH2CJcsMjN6ddzDTNrpYEE3vS6A ZmV5AP42yLetx9kXHT+SvLtMkAhFjvJWcRPonQLsR9z3ZneGBw== =YdTX -----END PGP SIGNATURE----- --=-=-=--