From: "Ludovic Courtès" <ludo@gnu.org>
To: Ashish SHUKLA <ashish.is@lostca.se>
Cc: 71764@debbugs.gnu.org
Subject: [bug#71764] [PATCH v7] gnu: Add got.
Date: Tue, 17 Sep 2024 17:36:14 +0200 [thread overview]
Message-ID: <875xqu9tsh.fsf_-_@gnu.org> (raw)
In-Reply-To: <2b3365852f7368a67199c3b84e1502f6d499e379.1726149620.git.ashish.is@lostca.se> (Ashish SHUKLA's message of "Thu, 12 Sep 2024 14:00:21 +0000")
Hi,
Ashish SHUKLA <ashish.is@lostca.se> skribis:
> * gnu/packages/version-control.scm (got): New variable.
>
> Change-Id: I34d19d90ab36e8831fa88668676aa2399356b002
[...]
> +(define-public got
[...]
> + (inputs
> + `(("libevent" ,libevent)
> + ("libuuid" ,util-linux "lib")
> + ("zlib" ,zlib)
> + ("libressl" ,libressl)
> + ("libmd" ,libmd)
> + ("libbsd" ,libbsd)
> + ("ncurses" ,ncurses)))
Please run ‘guix style -S inputs --input-simplification=always got’.
> + `(;; disable runpath validation, courtesy: libbsd's special
> + ;; treatment of libmd
> + #:validate-runpath? #f
It isn’t clear from the comment why RUNPATH validation is disabled, and
there has to be a very good reason because usually any problem it
detects is going to be an issue at run time.
Could you double-check?
> + #:configure-flags
> + '("CFLAGS=-DGOT_DIAL_PATH_SSH=\\\"ssh\\\" -DGOT_TAG_PATH_SSH_KEYGEN=\\\"ssh-keygen\\\" -DGOT_TAG_PATH_SIGNIFY=\\\"signify\\\"")
Please wrap lines to 80 characters.
Also, setting CFLAGS like this runs the risk of overriding the default,
which are usually “-O2 -g”, and thus building without optimizations.
Could you check whether this is the case and perhaps add “-O2 -g”?
> + #:phases ,#~(modify-phases %standard-phases
> + (add-after 'unpack 'patch-execv-to-execvp
> + (lambda _
> + ;; got sources has paths hardcoded to /usr/bin
> + (substitute* "lib/dial.c"
> + (("execv\\(GOT_DIAL_") "execvp(GOT_DIAL_")
> + (("execv %s\", GOT_DIAL") "execvp %s\", GOT_DIAL"))
> + (substitute* "lib/sigs.c"
> + (("execv\\(GOT_TAG") "execvp(GOT_TAG")
> + (("execv %s\", GOT_TAG") "execvp %s\", GOT_TAG"))
> + #t)))))
Please remove the trailing #t.
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-09-17 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 23:01 [bug#71764] [PATCH] gnu: Add got ashish.is--- via Guix-patches via
2024-06-24 23:27 ` [bug#71764] [PATCH v2] " ashish.is--- via Guix-patches via
2024-06-28 5:13 ` [bug#71764] [PATCH v3] " ashish.is--- via Guix-patches via
2024-07-13 9:19 ` [bug#71764] [PATCH v4] " ashish.is--- via Guix-patches via
2024-07-19 13:02 ` [bug#71764] [PATCH v5] " ashish.is--- via Guix-patches via
2024-08-15 20:05 ` [bug#71764] [PATCH v6] " Ashish SHUKLA via Guix-patches via
2024-09-12 14:00 ` [bug#71764] [PATCH v7] " Ashish SHUKLA via Guix-patches via
2024-09-17 15:36 ` Ludovic Courtès [this message]
2024-09-30 12:19 ` bug#71764: Close Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xqu9tsh.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=71764@debbugs.gnu.org \
--cc=ashish.is@lostca.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.