From: Arnaud Daby-Seesaram via Guix-patches via <guix-patches@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: Hilton Chain <hako@ultrarare.space>, 72714@debbugs.gnu.org
Subject: [bug#72714] [PATCH v4] home: services: Add 'home-sway-service-type'.
Date: Sun, 22 Sep 2024 15:43:45 +0200 [thread overview]
Message-ID: <875xqn4xda.fsf@nanein.fr> (raw)
In-Reply-To: <87bk0icm0j.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Fri, 20 Sep 2024 18:45:00 +0200")
[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]
Hello Florian and Hilton,
Thank you for your words and reviews! It is nice to know that a few
people are interested :).
> I’m still looking at the details of sway, so I could myself push your
> patch with confidence to guix.git, but would also be happy if others
> pushed it
Nice, NB: it is also fine
Upon reading the code again, one point is still unclear: the list of
packages that I include in user profiles seems a bit random :/.
- sway, swaylock and swaybg: useful to launch some commands manually
(including swaymsg).
- waybar, dmenu and bemenu: do not seem necessary. I will probably
remove them.
- dbus, xdg-desktop-portal and xdg-desktop-portal-wlr: may be
interesting to have. On my laptop, screen sharing¹ only works when
xdg-desktop-portal and xdg-desktop-portal-wlr are in the same profile²
(associated executable files end up in ~/.guix-home/profile/libexec/).
¹: I do not have a fully functional setup
for screen sharing yet (it does not work
in all web browsers). I (or someone else)
should probably add elements in the
default `execs' / `always-execs' fields
if/when they have a working setup later.
NB: this should not be a road blocker for
the current patch IMHO.
²: I do not know if that is a hard
requirement or if my issues are related to
something else.
- slurp and grim: screenshots (+ screen selection when screen sharing).
I will probably define a new variable `%sway-default-packages'
containing the above packages (minus waybar, ...). WDYT?
Hilton Chain <hako@ultrarare.space> writes:
> Can `sway-configuration-bar' be optional? In my case it's not used.
Yes indeed. In the v6, I will try to make a few fields optional, and
also avoid empty groups in produced configuration file.
> Arnaud Daby-Seesaram <ds-ac@nanein.fr> writes:
>>>> The function @code{sway-configuration->file} defined below can be used
>>>> to provide the value for the @code{sway-configuration} field of
>>>> @code{greetd-wlgreet-sway-session}.
[...]
> That one can use your `sway-configuration' enables one to configure the
> inputs field declaratively to use another keyboard layout in the
> greeter. It is a good feature. But perhaps add the word “optionally”
> to make clear users do not have to provide a sway-configuration to the
> greeter.
Indeed; I will try to phrase this properly.
>> @lisp
>> (service home-sway-service-type
>> (sway-configuration
>> (gestures
>> '((swipe:3:down . "move to scratchpad")
>> (swipe:3:up . "scratchpad show")))
>> (outputs
>> (list (sway-output
>> (identifier '*)
>> (bg (file-append guix-backgrounds
>> "\
>> /share/backgrounds/guix/guix-checkered-16-9.svg")))))))
>> @end lisp
>
> Now that I tested this code, I notice that SVG backgrounds work only
> if and only if librsvg is found. Still, I think it is better this way
> with file-append. Perhaps add a note to doc/guix.texi here that this
> librsvg must be installed or propagated in the packages field.
I will add a note in the next version of the doc, to hint towards the
two solutions to use a svg file: adding librsvg to the profile, or
computing the png and put it in the store using a "computed-file" in the
configuration (as in the second version of the patch).
>> @table @asis
>> @item @code{mode-name} (default @code{"default"})
>> Name of the mode.
>> @item @code{keybindings} (default @code{'()})
>
> These fields are missing a colon “default: ”. In other places you
> correctly write “default: ”.
Got it, thx!
Best regards,
--
Arnaud
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2024-09-22 13:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 15:30 [bug#72714] [PATCH] home: services: Add 'home-sway-service-type' Arnaud Daby-Seesaram via Guix-patches via
2024-08-24 15:32 ` [bug#72714] [PATCH v2] " Arnaud Daby-Seesaram via Guix-patches via
2024-08-26 10:38 ` [bug#72714] [PATCH v3] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-03 7:27 ` [bug#72714] [PATCH v4] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-14 13:28 ` pelzflorian (Florian Pelz)
2024-09-14 14:06 ` pelzflorian (Florian Pelz)
2024-09-17 6:52 ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-20 16:45 ` pelzflorian (Florian Pelz)
2024-09-22 13:43 ` Arnaud Daby-Seesaram via Guix-patches via [this message]
2024-09-25 6:58 ` pelzflorian (Florian Pelz)
2024-09-25 7:52 ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-25 11:42 ` pelzflorian (Florian Pelz)
2024-09-18 8:15 ` [bug#72714] [PATCH v5] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-18 18:56 ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-22 8:14 ` Hilton Chain via Guix-patches via
2024-09-25 8:00 ` [bug#72714] [PATCH v6] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-30 20:07 ` Ludovic Courtès
2024-10-01 22:12 ` [bug#72714] [PATCH] " Arnaud Daby-Seesaram via Guix-patches via
2024-10-02 14:08 ` pelzflorian (Florian Pelz)
2024-10-02 20:49 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-03 12:41 ` pelzflorian (Florian Pelz)
2024-10-03 20:53 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-04 20:17 ` pelzflorian (Florian Pelz)
2024-10-05 17:02 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-06 8:15 ` pelzflorian (Florian Pelz)
2024-10-06 9:05 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-06 9:51 ` pelzflorian (Florian Pelz)
2024-10-06 10:44 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-08 16:39 ` pelzflorian (Florian Pelz)
2024-10-08 22:33 ` [bug#72714] [PATCH v8] " Arnaud Daby-Seesaram via Guix-patches via
2024-10-12 13:11 ` bug#72714: " pelzflorian (Florian Pelz)
2024-10-01 22:30 ` [bug#72714] [PATCH v7] " Arnaud Daby-Seesaram via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xqn4xda.fsf@nanein.fr \
--to=guix-patches@gnu.org \
--cc=72714@debbugs.gnu.org \
--cc=ds-ac@nanein.fr \
--cc=hako@ultrarare.space \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.