From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YOGjLlTnCmc29wAA62LTzQ:P1 (envelope-from ) for ; Sat, 12 Oct 2024 21:17:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YOGjLlTnCmc29wAA62LTzQ (envelope-from ) for ; Sat, 12 Oct 2024 23:17:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uXSwOhIe; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="F2bKtj9/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728767828; a=rsa-sha256; cv=none; b=VwtNu3788Hr2VY59UgTwW62iX5aU9Y+sBmF0DjdW1kINuGJPUXtJcjB5Bju4OQwoVtxxd0 ZCeONQdC0iUmDKVqsu/KodqLCY8yDsb8EqUD8+m0caslP2ENFJgnFiMv61gwcbIbKf5kUx 9vGekUPB54B0F7bxNVh4l0L3M/OYxSrugH5IMd0o5y4kEcyfu6X7jPh6d1FhGUwSt6N8HP WFh5Wk91F+pS/XFYZSYXXBVJVUYCCVKKUBplrr3iDPGknNqsqKHDu/dVxUbdZo8xrTvH8a cIBUq1sA0JNJYqSKA6qrJ+CNtMCYtbLUxIFM9ptTCaamg9Bx+6gbSDD6R1/Pbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=uXSwOhIe; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="F2bKtj9/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728767828; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=VAdoLFfkK53od/H1U97y28t78DzDjhvJoFtxiHahMU4chASCWl2LEpvblm4mZ4jqPPtFpS lbiYDCjUa4kBuS+zMHZLYPvxDL1jhH5ZGdBkKjflBArnSNQgc38z7vBzBWHMDqa7W+RKCO hvy6mMRbQckVbQ11/RCkQ3nezis4WjKqEAfbF6oiaJu/q3+BAxQi2W5r8tH+rs1YXg7UIC m/1QhJ6Lw40RUrnqZ/EmyzYoNxVapdbVA3gPN4hajQcGtKV2j5gw8rEcNhs6RMUmMMNbC/ NPbtlFFbXXPFebsGobbaewsTiDc3GC5FjmJnYvXD/SFOGsu5BSKX5+Ji2KxC5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6DA678228E for ; Sat, 12 Oct 2024 23:17:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szjTm-0003Be-1T; Sat, 12 Oct 2024 17:16:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szjTj-0003BG-V2 for guix-patches@gnu.org; Sat, 12 Oct 2024 17:16:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szjTj-00082o-Mq for guix-patches@gnu.org; Sat, 12 Oct 2024 17:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=uXSwOhIeo5P4KPYuyt8ZL+Bs5mvwSm7R9YZOSUwJBRx3ypgF/f+Ka3bbAWPnex5hTP840fPYmSEPOwzRgDjTOBK3ZcEHS//jqr3ILQ9BwYxnPPELJAxQ3QKwQG+zozheYsDOxJ0qcJ6sjLSvV7baX2unu/JefjKw3yA5aIlFfvlbp8NDCEcdkem7Lm279zsMSEPAWG55PlsruVxbp1oId6iPrTS6fAmkVocNT7U7ePjzBxt/YzXbjd9S+d9u4S61u7M33AaJW6LMI18g8H8SDqN8FtH+YHz7hVzhdWbrDgvIk3Qi5vW5h6RaUp/UKk5UOApjxD5/nhm7cHEkgRBf2g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szjTx-0004Tn-Ri for guix-patches@gnu.org; Sat, 12 Oct 2024 17:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Oct 2024 21:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart , Suhail Singh Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172876777517045 (code B ref 72925); Sat, 12 Oct 2024 21:17:01 +0000 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 21:16:15 +0000 Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szjTC-0004Qp-Gd for submit@debbugs.gnu.org; Sat, 12 Oct 2024 17:16:15 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:49564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szjTA-0004QN-TN for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 17:16:13 -0400 Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-45f091bf433so26253521cf.3 for <72925@debbugs.gnu.org>; Sat, 12 Oct 2024 14:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728767692; x=1729372492; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=F2bKtj9/YLAQ7pGlPC0j9js1qVMZDXdFWDovf5ve2VsAsJ0/x8CIGaBTkqug+rHiHc kyWb85GTsSKgMf/ZnDxcT0deQhk/Y7Nib8IikgarhOTIdPmQ0rWDtJgpB8PkK73xQq7f lnaLe3WcM95rmW0OcbXT4K5JM2jvAVC0HA4GQlBKBJfpiaEjhkL40xqqk0p7d+Gv3UtH eEilbX7ce8rjg8c4IvVnoOnGbG086hO8Qy6NpOOV60Ix8BraYkbbjc2OVTO5q2SvXGeW gAOJrZ8yPHsuujJ+nQISzzRppw3ON6HICsE8plc+bijC0X4hFcksjJyjKu0gd1xcWazb LJNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728767692; x=1729372492; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5lfiJ8E4Gcbjs2+C1xTJO43V+1JstI09kJC+GjMx/fI=; b=efOZIqr45hoSNIx2RI8TPOwELSknyiHmPvcBoWurr/j1+b++SMKob/FiHRTXCPy21Y /aUyCiV4EBM5FYuShuB+0b68XHDr+AVtoZPNUMiH6pSh+fdbKBVLwctDYMGa/6evwFje b/LDFzIgmiWqRfFZyqv8mWZpqtMiOA/dSRlrELsG7WtOIQj21gnTS738tJgH8vCoLsun Di+uoBst19caRqejWZNgdbVkjrW4nsq204EUBH9eB5fkfrj2M2VufwknqN26MdUjT4HD jCZ1ae46vDdvUtmmGcBrCzi15ZUTLINfHCBvE+EZGQIUpmGrQePFuaf0bm16MjEQ3tN6 oKKA== X-Forwarded-Encrypted: i=1; AJvYcCXomt3l41HnM2tFKXl/3dWVyiAHFKil/Y2VglVDTK+HDQG57QQ6IQSDhNhiFcd4q3JvomfUsw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywfu00TvpXG5ohEKQvqleSfiHueBrf3+WzmrDG2HJ/5Odz4B2Q1 leoxYVRenzGClYxQhOAtPfUVbjYq1xZDnVF1IG64qjQ0XfhqlPmM X-Google-Smtp-Source: AGHT+IFJCyFqZStmkEpJ/Euy0tmqWIB1XU2t1k1bxemjip19+RkZvsSwbiH+iexGd4A6YDlbT8VK6A== X-Received: by 2002:a05:6214:468a:b0:6cb:fff6:8f31 with SMTP id 6a1803df08f44-6cbfff6932emr46330796d6.47.1728767692539; Sat, 12 Oct 2024 14:14:52 -0700 (PDT) Received: from gnus (bras-base-mtrlpq0776w-grc-11-70-48-225-6.dsl.bell.ca. [70.48.225.6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cbe85a5d75sm29009466d6.20.2024.10.12.14.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 14:14:51 -0700 (PDT) From: Suhail Singh In-Reply-To: <87ldyts0cm.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 12 Oct 2024 19:22:01 +0200") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> <87ldyts0cm.fsf_-_@gnu.org> Date: Sat, 12 Oct 2024 17:14:49 -0400 Message-ID: <875xpxuipi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.30 X-Spam-Score: -0.30 X-Migadu-Queue-Id: 6DA678228E X-Migadu-Scanner: mx12.migadu.com X-TUID: Ed5yaTt7zUCW Ludovic Court=C3=A8s writes: >> + (wrap-program (string-append #$output "/bin/jp= m") >> + `("JANET_HEADERPATH" ":" prefix >> + (,(string-append #$janet "/include/janet")= )) >> + `("JANET_LIBPATH" ":" prefix >> + (,(string-append #$janet "/lib"))) >> + `("C_INCLUDE_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/include")= )) >> + `("CPLUS_INCLUDE_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/include/c= ++") >> + ,(string-append gcc-toolchain "/include")= )) >> + `("LIBRARY_PATH" ":" prefix >> + (,(string-append gcc-toolchain "/lib") >> + ,(string-append gcc-toolchain "/lib64"))) >> + `("PATH" ":" prefix >> + (,(string-append gcc-toolchain "/bin") >> + ,(string-append #$coreutils "/bin")))))))= ))) >> + (inputs (list bash-minimal >> + ;; Lazily resolve the gcc-toolchain to avoid a circul= ar >> + ;; dependency. >> + (module-ref (resolve-interface '(gnu packages commenc= ement)) >> + 'gcc-toolchain))) > > I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? > > I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80= =99, =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to > =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-t= oolchain=E2=80=99 dance. It seems "ld-wrapper" requires (gnu packages commencement) and this results in doing the lazy dereference similar to gcc-toolchain above. Am I doing something wrong? If not, is the guidance still to add "ld-wrapper" to inputs? > Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80= =99 rather than > direct references to these variables. Hmm just to be clear, instead of: #+begin_src scheme `("C_INCLUDE_PATH" ":" prefix (,(string-append gcc-toolchain "/include"))) #+end_src What we want is something like: #+begin_src scheme `("C_INCLUDE_PATH" ":" prefix (,(search-input-file inputs "/include"))) #+end_src Is my understanding correct? If so, adding "gcc", "glibc", "binutils", and "ld-wrapper" seems insufficient to make that work. The search-input-file for "/include" results in a "&search-error" when building the package. --=20 Suhail