From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YFnrCgOMM2dIAgAA62LTzQ:P1 (envelope-from ) for ; Tue, 12 Nov 2024 17:10:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YFnrCgOMM2dIAgAA62LTzQ (envelope-from ) for ; Tue, 12 Nov 2024 18:10:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=omM0VXrM; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=aWDrchbX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731431427; a=rsa-sha256; cv=none; b=qWMcDKuHddoIXCISYPfQlPJcBiNotF9i9fKjpWG6eRnaDmQHTng+/hPTwAG2NXkMMkzhll AXh9cs1A9Jn3n5HYnpefpNMypgpE1tUNkNjfO7Wq1GQHnEtVQUyF+2dtRooOA7Y9mAqgax mYq27QjgE8G0HNo4XdI6/1eCMr0gOAO1oV4oGUvrHi26iiv21CnXjVIy2Z2xyvXZq7VoAW QlDABOe8Wuflj2ZRL01dMVsVn/DBcZHPp9gqtW/DbJDfH2TX+whFMQOdd6sXkalxSW0LRe QO7X6ishufOqWc9U0chOL1qMf5/pmwLUeCla4ZFHxmY+ZKDfWf/SDZtFo3FvLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=omM0VXrM; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=aWDrchbX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731431427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=e9gQE6o6jFByBvprxpdyebqlGhbXizT9IjlrC6lbtsc=; b=C3TwKL69OK7PmXfGz4UAkYyJVbYemb2xwHQPm9H16Vg4kwkl+L8M9Ynv+rDk6C5wbJqEhJ 0T/DF/QuIjs5Q51pVScqUaPg4JVf8nf7bcl9z9BK74jBMHNR6mGXeT6RyxdYqgoG+3sksZ o6J7HfdyV1qPMgQk8ph4q123JA+/fLy0521FWJ2UuMxmWGJts6OqiRsLz663JXm6VhTsB6 NZl4NY5APhOTsiITIQPRSEQZDUiYUE66mPFMNjBsuksg2Q+Yxy9sgo1UlX/EOwUOjAuTSh sa9MYWMxcL9ReZNfnRD96awuVyj0VZmBw6wCpJmrc21rU7/a0/JKqNZ+AAS95w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EDF1380782 for ; Tue, 12 Nov 2024 18:10:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAuOy-0000M7-Ag; Tue, 12 Nov 2024 12:10:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAuOw-0000K0-Ji for bug-guix@gnu.org; Tue, 12 Nov 2024 12:10:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAuOw-0002Oh-9u for bug-guix@gnu.org; Tue, 12 Nov 2024 12:10:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=e9gQE6o6jFByBvprxpdyebqlGhbXizT9IjlrC6lbtsc=; b=omM0VXrMivnuMc4Ks5nfsEffk/adDnhmXkKw8fn8HewLkc9Lwiq69MhxFz9iYAjxeYzvQ6QCiUgoS751nSWkUSctVvp9IL8D5yuwkmFMChrIvS49oXhWDr47Efr41MyzmZaNB9SgAH55rE0oZJndt4B7QQleDQYYJ367sbBRxA8OEraD012WcXYNcOHr0IBMKMXIFUAZBYxIIN4anugIMhLgdP54WdW3Ye2HYPMwFFU/ol3c5aYLVEd9+wzVmdM3N5O5xaLKHmqol1nge4Aj6p/7zE6ryjW77HhfW0c89n9mkAgjhEUQVHDI/Y8WIB/DLZYFP6PQYknRX7qQUwMXPQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAuOw-0002KE-4D for bug-guix@gnu.org; Tue, 12 Nov 2024 12:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#73166: shell-autorized-directories Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 12 Nov 2024 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73166 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Nicolas Graves Cc: 73166@debbugs.gnu.org, ludo@gnu.org, suhailsingh247@gmail.com, andrew@trop.in, saku@laesvuori.fi X-Debbugs-Original-Cc: Saku Laesvuori via Bug reports for GNU Guix , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73166@debbugs.gnu.org, Suhail Singh , Andrew Tropin , Saku Laesvuori Received: via spool by submit@debbugs.gnu.org id=B.17314313678874 (code B ref -1); Tue, 12 Nov 2024 17:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Nov 2024 17:09:27 +0000 Received: from localhost ([127.0.0.1]:39378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAuOM-0002J3-Uz for submit@debbugs.gnu.org; Tue, 12 Nov 2024 12:09:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:60776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAuOK-0002It-5x for submit@debbugs.gnu.org; Tue, 12 Nov 2024 12:09:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAuOG-0007DE-Db for bug-guix@gnu.org; Tue, 12 Nov 2024 12:09:21 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAuOE-0002Hr-1f; Tue, 12 Nov 2024 12:09:20 -0500 Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-460d1145cd8so45125231cf.3; Tue, 12 Nov 2024 09:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731431345; x=1732036145; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=e9gQE6o6jFByBvprxpdyebqlGhbXizT9IjlrC6lbtsc=; b=aWDrchbX47C5LL6AeAfEXCDz5AwHL6InGUewTXC0+48Z7UG5m0lXBdeC3bH/FJKNui MR135irlnnqdOgfY7UUqQLjc2+ML6OXjxeoihEIcEtZnEJIE4zAIIW5bxuCB5nvfy7ip Kuno5K8dvBQKq/8cIkHg7uh9kxz0xGwpYvJll/LE8eCuDoM8gcBoG1itvet+OwxnPSmN eeSQh8yoH7T63gdr5MGGvi5VUHKu+kXfmXtZZNh7kLAQ4Tg3rQvHsmBEBUTIbdjSdEqq i2XPdDrHU2Bv6CAMfYcnSr+LuiVfIpbPRmYhHrc/jPl1yQ02IibHnbSGbShYpAlwTjFo TD6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731431345; x=1732036145; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e9gQE6o6jFByBvprxpdyebqlGhbXizT9IjlrC6lbtsc=; b=OAnss9yOa1KSUSKWitNNkkzBcxHQ3zIYIEsMyGj8GQDeEKTKi0E+YtIExqVbrXUYPS WrlkVwH4mm7MokxPtbPnxLgZdSWx2qK18c1iIjGMgYZMwmxpI9BouJNe8W5urf7wSQQj 0B1sHfiucxo9dVUlOaj890kld45KqzcqUS22GVyDQYgcKkbGFQgrclfKhSy60vZTwoOQ ewi+ZDlJgrsFblsgYoOrhZDYWN5etj9ziWjkQhAFMt/Z6l8IUPTsi5JD6NsIluCeg5DB 9U2tDd/y1f7ymJssNhb2jyaR306ZJbY+IeKAhgkt6eE7TDjc5QKbAY4HwBn5KNguE7yF 24yA== X-Forwarded-Encrypted: i=1; AJvYcCXDo52SCmyErlEPnHUpY5todaKzEFIiXhnyNHYFsP4SRhOzPVRcVFJM8yTlVQ66vroQbZKXYg==@gnu.org, AJvYcCXGShYVmtsSoNp2z3xtsqnoW4Ps8uz4gIDbErFKiWkf2K1swg5uPhe1IoeYnQ/eZyZIOa+TrY5q3A==@gnu.org X-Gm-Message-State: AOJu0YwstrcElE4vcZpgBfsw3Cn9R8iH4rf4HAH2+n2XYtkEsfyI70Uu GQuozpx2PFK3L15p5Y12Jhtwh57isxjbte4+LFvmFusmidyfU8AkshIVLnME X-Google-Smtp-Source: AGHT+IGu/clQ/+5tNOTCxOzoR5dqbh73Cmu8BiMwE+IdLRc7niY04GFupIGOR1ICvTHU/5QDykupZg== X-Received: by 2002:ac8:5e4d:0:b0:458:2894:984e with SMTP id d75a77b69052e-4630931f2d4mr259410181cf.3.1731431345190; Tue, 12 Nov 2024 09:09:05 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-462ff4677e7sm76748421cf.42.2024.11.12.09.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 09:09:03 -0800 (PST) From: Suhail Singh In-Reply-To: <87o72k4cty.fsf@ngraves.fr> (Nicolas Graves's message of "Tue, 12 Nov 2024 17:49:13 +0100") References: <877cbjwxs4.fsf@ngraves.fr> <87cyla7c0f.fsf@gnu.org> <87mske8emf.fsf@ngraves.fr> <874j4gpkbn.fsf@ngraves.fr> <87bjyn1ga7.fsf@ngraves.fr> <87ikstteal.fsf@gmail.com> <87cyj06g97.fsf@ngraves.fr> <87ttccmrp1.fsf@gmail.com> <87o72k4cty.fsf@ngraves.fr> Date: Tue, 12 Nov 2024 12:08:52 -0500 Message-ID: <875xosmlaz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::841; envelope-from=suhailsingh247@gmail.com; helo=mail-qt1-x841.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.30 X-Spam-Score: -1.30 X-Migadu-Queue-Id: EDF1380782 X-Migadu-Scanner: mx12.migadu.com X-TUID: ycNu7bXWuxqD Nicolas Graves writes: > Building a package yes, but you can have external commands in a > manifest.scm or guix.scm. > > ... > > What I was saying is that we could restrain recording `guix shell --allow` > only if the manifest builds properly containerized and without network > access (outside package building I mean), and otherwise refuse to allow > (failing manifest, possibly because it tries to access the network or > files outside the repo) with a warning message, providing the ability to > restrain "automatic loading" to certain "safer" conditions only. I see. I think in the event that the manifest doesn't build in a containerized environment without networking access, providing a warning when using --allow would be quite helpful. It would inform the user of situations where what's happening in the manifest has fewer guarantees. If we were to do the above for --allow, but still allow the user to bypass that via shell-authorized-directories if desired, I believe it would be a good tradeoff: make well-behaved code easier to use, while still allowing for less-well-behaved workflows with some minor inconvenience. I am assuming in the above that this wouldn't interfere with additional channels being used in the repo. > The downside is that we would have to basically run `guix shell > --container` (and build all there is to build) before being able to > run `guix shell --allow`. As long as we properly document this, I think that that's acceptable. -- Suhail