all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Evgeny Pisemsky <mail@pisemsky.site>
To: 73314@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: bug#73314: [PATCH] Fix null at home-page in PyPI importer
Date: Fri, 22 Nov 2024 19:38:49 +0300	[thread overview]
Message-ID: <875xofrzom.fsf@pisemsky.site> (raw)
In-Reply-To: <87plp2o76x.fsf@pisemsky.site>

[-- Attachment #1: Type: text/plain, Size: 36 bytes --]

Here is the fix that works for me.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-null-at-home-page-in-PyPI-importer.patch --]
[-- Type: text/x-patch, Size: 1965 bytes --]

From b3a7c4fb23dafe9ae3103c206a1cfc0a6676a0fc Mon Sep 17 00:00:00 2001
Message-ID: <b3a7c4fb23dafe9ae3103c206a1cfc0a6676a0fc.1732292783.git.mail@pisemsky.site>
From: Evgeny Pisemsky <mail@pisemsky.site>
Date: Fri, 22 Nov 2024 19:19:50 +0300
Subject: [PATCH] Fix null at home-page in PyPI importer

Change-Id: I501582988cf58b00bd201c12ad47e9b095988fae
---
 guix/import/pypi.scm | 4 ++--
 guix/packages.scm    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index 7b9f54a200..397ae5d5fd 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -114,8 +114,8 @@ (define-json-mapping <project-info> make-project-info project-info?
   (license      project-info-license)             ;string
   (download-url project-info-download-url         ;string | #f
                 "download_url" non-empty-string-or-false)
-  (home-page    project-info-home-page            ;string
-                "home_page")
+  (home-page    project-info-home-page            ;string | #f
+                "home_page" non-empty-string-or-false)
   (url          project-info-url "project_url")   ;string
   (release-url  project-info-release-url "release_url") ;string
   (version      project-info-version))            ;string
diff --git a/guix/packages.scm b/guix/packages.scm
index f373136d22..950e262274 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -648,7 +648,7 @@ (define-record-type* <package>
                (sanitize validate-texinfo))       ; one or two paragraphs
   (license package-license                        ; (list of) <license>
            (sanitize validate-license))
-  (home-page package-home-page)                   ; string
+  (home-page package-home-page)                   ; string | #f
   (supported-systems package-supported-systems    ; list of strings
                      (default %supported-systems))
 

base-commit: 2fec407b2745898d0a304c172a27dfe0a8787122
-- 
2.46.0


      parent reply	other threads:[~2024-11-22 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17 11:23 bug#73314: PyPI importer gives null at home-page for some packages Evgeny Pisemsky
2024-09-20 17:02 ` Simon Tournier
2024-09-22  7:00   ` Evgeny Pisemsky
2024-11-22 16:38 ` Evgeny Pisemsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xofrzom.fsf@pisemsky.site \
    --to=mail@pisemsky.site \
    --cc=73314@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.