all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
	Simon Tournier <zimon.toutoune@gmail.com>,
	Mathieu Othacehe <othacehe@gnu.org>,
	Tobias Geerinckx-Rice <me@tobias.gr>,
	75027@debbugs.gnu.org, Jakob Kirsch <jakob.kirsch@web.de>,
	Christopher Baines <guix@cbaines.net>
Subject: [bug#75027] [PATCH v2 0/3] 'guix system reconfigure' loads system for kexec reboot
Date: Sat, 28 Dec 2024 16:24:25 +0900	[thread overview]
Message-ID: <875xn4s21i.fsf@gmail.com> (raw)
In-Reply-To: <cover.1735233263.git.ludo@gnu.org> ("Ludovic Courtès"'s message of "Thu, 26 Dec 2024 18:21:24 +0100")

Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Changes compared to v1:
>
>   • Move kexec code outside of ‘upgrade-shepherd-services’.  Now both
>     (guix scripts system) and (gnu machine ssh) have to explicitly
>     call ‘load-system-for-kexec’.
>

I've sent a couple comments; assuming you can address them, LGTM!
Thanks for working on this interesting improvement.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

-- 
Thanks,
Maxim




  parent reply	other threads:[~2024-12-28  7:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-22 15:56 [bug#75027] [PATCH 0/3] 'guix system reconfigure' loads system for kexec reboot Ludovic Courtès
2024-12-22 15:57 ` [bug#75027] [PATCH 1/3] syscalls: Add ‘kexec-load-file’ Ludovic Courtès
2024-12-22 15:57 ` [bug#75027] [PATCH 2/3] system: Export ‘…-initrd-file’ and ‘…-root-file-system’ Ludovic Courtès
2024-12-22 15:57 ` [bug#75027] [PATCH 3/3] reconfigure: Call ‘kexec-load-file’ Ludovic Courtès
2024-12-22 21:47 ` [bug#75027] [PATCH 0/3] 'guix system reconfigure' loads system for kexec reboot Jakob Kirsch via Guix-patches via
     [not found]   ` <87y106ej9v.fsf@gnu.org>
2024-12-23 18:24     ` Jakob Kirsch via Guix-patches via
2024-12-26 17:25       ` Ludovic Courtès
2024-12-26 17:21 ` [bug#75027] [PATCH v2 " Ludovic Courtès
2024-12-26 17:21   ` [bug#75027] [PATCH v2 1/3] syscalls: Add ‘kexec-load-file’ Ludovic Courtès
2024-12-28  6:12     ` Maxim Cournoyer
2024-12-28 21:32       ` Ludovic Courtès
2024-12-26 17:21   ` [bug#75027] [PATCH v2 2/3] system: Export ‘…-initrd-file’ and ‘…-root-file-system’ Ludovic Courtès
2024-12-28  6:12     ` Maxim Cournoyer
2024-12-26 17:21   ` [bug#75027] [PATCH v2 3/3] reconfigure: Support loading the system for kexec reboot Ludovic Courtès
2024-12-28  7:22     ` Maxim Cournoyer
2024-12-28 21:46       ` Ludovic Courtès
2024-12-28  7:24   ` Maxim Cournoyer [this message]
2024-12-28 22:18     ` [bug#75027] [PATCH v2 0/3] 'guix system reconfigure' loads " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xn4s21i.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=75027@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=jakob.kirsch@web.de \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.