From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YNdSIM2ldmeHwAAAqHPOHw:P1 (envelope-from ) for ; Thu, 02 Jan 2025 14:42:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YNdSIM2ldmeHwAAAqHPOHw (envelope-from ) for ; Thu, 02 Jan 2025 15:42:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XKfuHie8; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dpKQUMor; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735828941; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZbfHCL2YCE7tdGq/w48Nd/wLuIAPQEo+qHOAD2AtPq0=; b=DDCImgOd6kSiva/gD4KZyu+AOQyxjaacZiZdpu1Bm1acuU+KOISlXxftSPXVwYPWDmcHeY eQN/rnbL62BXEDg0LV1P5uwaPPVp2jpZxTchDPsxItejkGJPJLvOExLYeaTVSom0oxkCdB F9JOIJ83KHkgBk9xSbx/Qgxo9mOsbVwEmYIiOxT8zek5lOrn05LJT64a5Aj+SSRkhl+mBK 2d/OXNVCeNN2NoHpvTfu1+SVxV0vaC8z/JyQAi0g87FJdwde+kwP1H44RFtGt0se/SVBrL WDxA/4xwvg/gaApbgz/8dKrn2EZDPbEhymQuSAX01Xb7OZ/Ylam/nxH/YaqcBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XKfuHie8; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=dpKQUMor; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735828941; a=rsa-sha256; cv=none; b=Dz3iWLt45gogU8E+dPvuDoXMxI9kkKkUcQbS3jjqZW7dQRHoEkKaNgx5CtkNrQz/LYiqow 7d/yXJ48sK9/zfDafd6iSt9FwetedOf3TbwsA4X3lzACTYRnl1wL7F1K5u5o5Pc/LR9WYI CCcP6FlRtB/vln+IWeFkmRWQvK4n1aJg5553Q9ou0J92+hyckS1rV5TOZOiEbz8VFnO6kt elOdc4VxzftyXehiuFfp2mQVEjzoHJVT5oEadyWsgoPGFW8OzZrb/AhZBwIRMc5HkbPIAb ENqpE9Q47WaQXgp1cEcJBtgBS1baZ/o3cCijczLzzndAqFH053+P/cVim045qg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2415D5EA01 for ; Thu, 02 Jan 2025 15:42:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTMOi-00026O-NR; Thu, 02 Jan 2025 09:42:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTMOh-00026F-2x for guix-patches@gnu.org; Thu, 02 Jan 2025 09:42:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTMOg-0002DM-Qm for guix-patches@gnu.org; Thu, 02 Jan 2025 09:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ZbfHCL2YCE7tdGq/w48Nd/wLuIAPQEo+qHOAD2AtPq0=; b=XKfuHie8lNlKger48bXJmudVEm1GEecEoTQHEZnxTd9INcMef5oYMYJz7jtX/MPZgANUA7ku61su3UjJRToi9RbU85a406ZA9baG5UPMm2sABx8mKoObxIYBr0wBjuLkgbeRbQIMrCFHN88h+B0w52PziJ4MSFYqIjy0Kl/3MZvbrkVHz3hBwAv3lrDu5SHPZGKNXYVi3wVm3E+qXdhLcoeoJUQJGep51lPWRqBgkfXlpEIc6nBKe7IKNXejse40Q5ObpNNqMh6eplREomNwxE9JW39+kTfM/zMcFeAkYf+mFJL2KgwT/d7KIvVCUJzrWiyozC1lIxWuQwMlltT/LQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTMOg-0003wX-Cj for guix-patches@gnu.org; Thu, 02 Jan 2025 09:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74860] [PATCH 05/10] services: Switch from mcron + Rottlog to =?UTF-8?Q?Shepherd=E2=80=99s?= log rotation. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jan 2025 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74860@debbugs.gnu.org Received: via spool by 74860-submit@debbugs.gnu.org id=B74860.173582889415105 (code B ref 74860); Thu, 02 Jan 2025 14:42:02 +0000 Received: (at 74860) by debbugs.gnu.org; 2 Jan 2025 14:41:34 +0000 Received: from localhost ([127.0.0.1]:43354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTMOE-0003vY-8K for submit@debbugs.gnu.org; Thu, 02 Jan 2025 09:41:34 -0500 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:59716) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTMOC-0003vQ-2T for 74860@debbugs.gnu.org; Thu, 02 Jan 2025 09:41:32 -0500 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2ef72924e53so15812551a91.3 for <74860@debbugs.gnu.org>; Thu, 02 Jan 2025 06:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735828890; x=1736433690; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZbfHCL2YCE7tdGq/w48Nd/wLuIAPQEo+qHOAD2AtPq0=; b=dpKQUMor5neo44jkP9TSbQ28ErQzAQCEF365kvzX1fXOaYakfErQOH92HyxpkJD8Hw H0lrbj8gEbHhWlXdrCxGJT12lHqT/8X9sVTgB0DvHJxPv8ID6jWguaOdWE/32m0gJpwL M6Tz2VxgZxpGZl4jhgGUUG1kGKZGJXq5by6s7nmbl1HRFBI2NNsW5L7ehKZmkEqeh31p JGDLxLNBC2MnfuWtvZUjqj+SjEhfoBqU1uFd4O47rJV37dXX2+6buGcRPdYKT2iAUhpb Q6w1iSDAr2Is2n0GmaOQHtGJGsI6nXqgCyLZXi8XhysjV+4FH0jVOmYKtuLNE63b416H 1Bew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735828890; x=1736433690; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZbfHCL2YCE7tdGq/w48Nd/wLuIAPQEo+qHOAD2AtPq0=; b=qu//iG/AJhLUPwFSjZBQWQN0miY8v9AhRb+4avX79g5JZOUfiq7egd6NinylxV338V Col23dFxxNafZ1JKsn2Rd6ArVjYyDmpLmDFU++7crVDPrT47SwbO2+hhplKR1hNPx5rY K0Aebk0EcQEmB9SFHlEmUdVwOiQiXg+jYNfAoXaM/M1J9lVutePpauVEkJzDiT8Mswc7 0j1nHAzCJmSdVJIUZ5mtlEuUlt/Mca4VFi54YLUNLKYMuWnxey3X5qBw/M79fYM4wnuI Rwm5rnZL7FefGQsrAYR/Aabo0irlejW8Ejgs7w4VGH1FzNW6b7OR4MKt1K1WFaleXkJO CrOg== X-Gm-Message-State: AOJu0YyRqw1BVrsFaoLY9Nxv7ozxY4vBmvC0I0TNcqulztyF+pA9GkXE hgBAXfbMzqUN2Y2AlxRjD7s/T65xXGvFqDc567DTOu/nVSF4JXvgoeFclNZa X-Gm-Gg: ASbGncvgdKrBTbZRehu0MOflnslIHzohdook23qNFh+fwQqsV8qQef56pqTgzfCevpq QzoXfu6/zenCGYjH9PTddVeON9vytzQWtrL7KJJFnRbOZ77u/iwRbeTrNRJZzhaRdZuTijx6mO5 L9aBVOtlcnyldyv85Z+777VDqCmDOe/Fr7gPhDk8H5PwgLUvEC23SVLKpF6eFtKjXL7649Tt06c Q3NdUhz2Se7OGUyk9jH6Ng1jmQOtfGNlEKIFaBtNLIa6sNbM229OQ== X-Google-Smtp-Source: AGHT+IEDsYxzKBnGLMuhYVW+pAGW2Pau3ll7NXHf7aFGh8IfuLSqKEQ1QfyakDO3hIC/h4+M6Un6Dg== X-Received: by 2002:a17:90a:f950:b0:2ea:5054:6c49 with SMTP id 98e67ed59e1d1-2f452d258bfmr82230460a91.0.1735828890154; Thu, 02 Jan 2025 06:41:30 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed82d456sm31303408a91.29.2025.01.02.06.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 06:41:29 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <996235434e14dd004d6ff36228e755aaf3451d9b.1734129908.git.ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 13 Dec 2024 23:58:25 +0100") References: <996235434e14dd004d6ff36228e755aaf3451d9b.1734129908.git.ludo@gnu.org> Date: Thu, 02 Jan 2025 23:41:19 +0900 Message-ID: <875xmx5ldc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 2415D5EA01 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -0.59 X-Spam-Score: -0.59 X-TUID: WZ4E5X0bNPyb Hi Ludovic, Ludovic Court=C3=A8s writes: > * gnu/services/admin.scm (unattended-upgrade-log-rotations): Remove. > (unattended-upgrade-service-type): Remove =E2=80=98rottlog-service-type= =E2=80=99 > extension. > * gnu/services/audio.scm (mpd-log-rotation): Remove. > (mpd-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 extensi= on. > (mympd-log-rotation): Remove. > (mympd-service-type): Remove rottlog-service-type=E2=80=99 extension. > * gnu/services/base.scm (%guix-publish-log-rotations): Remove. > (guix-publish-service-type): Remove =E2=80=98rottlog-service-type=E2=80= =99 extension. > (%base-services): Instantiate =E2=80=98log-rotation-service-type=E2=80=99= instead of > =E2=80=98rottlog-service-type=E2=80=99. > * gnu/services/cuirass.scm (cuirass-log-rotations): Remove. > (cuirass-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 ext= ension. > (cuirass-remote-worker-log-rotations): Remove. > (cuirass-remote-worker-service-type): Remove =E2=80=98rottlog-service-typ= e=E2=80=99 > extension. > * gnu/services/file-sharing.scm (%transmission-daemon-log-rotations): > Remove. > (transmission-daemon-service-type): Remove =E2=80=98rottlog-service-type= =E2=80=99 > extension. > * gnu/services/linux.scm (%earlyoom-log-rotation): Remove. > (earlyoom-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 ex= tension. > * gnu/services/networking.scm (%ntp-log-rotation): Remove. > (ntp-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 extensi= on. > (openntpd-service-type): Likewise. > (%connman-log-rotation): Remove. > (connman-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 ext= ension. > (%hostapd-log-rotation): Remove. > (hostapd-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 ext= ension. > (%pagekite-log-rotation): Remove. > (pagekite-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 ex= tension. > (%yggdrasil-log-rotation): Remove. > (yggdrasil-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 e= xtension. > (%ipfs-log-rotation): Remove. > (ipfs-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 extens= ion. > (%keepalived-log-rotation): Remove. > (keepalived-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 = extension. > * gnu/services/web.scm (%hpcguix-web-log-rotations): Remove. > (hpcguix-web-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99= extension. > (%mumi-log-rotations): Remove. > (mumi-service-type): Remove =E2=80=98rottlog-service-type=E2=80=99 extens= ion. > * doc/guix.texi (Log Rotation): Adjust text regarding which one is in > =E2=80=98%base-services=E2=80=99. > > Change-Id: I8802d4c2337a1e08e3c084d6217f76527d7ee1fb Like a breathe of fresh air! LGTM, and the following ones (I did have some comments requiring your attention for earlier commits, so please check them out). I also haven't tested anything hands on, merely reviewed the code by eye-balling it. --=20 Thanks, Maxim