[bug#74860] [PATCH 05/10] services: Switch from mcron + Rottlog to Shepherd’s log rotation.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> * gnu/services/admin.scm (unattended-upgrade-log-rotations): Remove.
> (unattended-upgrade-service-type): Remove ‘rottlog-service-type’
> extension.
> * gnu/services/audio.scm (mpd-log-rotation): Remove.
> (mpd-service-type): Remove ‘rottlog-service-type’ extension.
> (mympd-log-rotation): Remove.
> (mympd-service-type): Remove rottlog-service-type’ extension.
> * gnu/services/base.scm (%guix-publish-log-rotations): Remove.
> (guix-publish-service-type): Remove ‘rottlog-service-type’ extension.
> (%base-services): Instantiate ‘log-rotation-service-type’ instead of
> ‘rottlog-service-type’.
> * gnu/services/cuirass.scm (cuirass-log-rotations): Remove.
> (cuirass-service-type): Remove ‘rottlog-service-type’ extension.
> (cuirass-remote-worker-log-rotations): Remove.
> (cuirass-remote-worker-service-type): Remove ‘rottlog-service-type’
> extension.
> * gnu/services/file-sharing.scm (%transmission-daemon-log-rotations):
> Remove.
> (transmission-daemon-service-type): Remove ‘rottlog-service-type’
> extension.
> * gnu/services/linux.scm (%earlyoom-log-rotation): Remove.
> (earlyoom-service-type): Remove ‘rottlog-service-type’ extension.
> * gnu/services/networking.scm (%ntp-log-rotation): Remove.
> (ntp-service-type): Remove ‘rottlog-service-type’ extension.
> (openntpd-service-type): Likewise.
> (%connman-log-rotation): Remove.
> (connman-service-type): Remove ‘rottlog-service-type’ extension.
> (%hostapd-log-rotation): Remove.
> (hostapd-service-type): Remove ‘rottlog-service-type’ extension.
> (%pagekite-log-rotation): Remove.
> (pagekite-service-type): Remove ‘rottlog-service-type’ extension.
> (%yggdrasil-log-rotation): Remove.
> (yggdrasil-service-type): Remove ‘rottlog-service-type’ extension.
> (%ipfs-log-rotation): Remove.
> (ipfs-service-type): Remove ‘rottlog-service-type’ extension.
> (%keepalived-log-rotation): Remove.
> (keepalived-service-type): Remove ‘rottlog-service-type’ extension.
> * gnu/services/web.scm (%hpcguix-web-log-rotations): Remove.
> (hpcguix-web-service-type): Remove ‘rottlog-service-type’ extension.
> (%mumi-log-rotations): Remove.
> (mumi-service-type): Remove ‘rottlog-service-type’ extension.
> * doc/guix.texi (Log Rotation): Adjust text regarding which one is in
> ‘%base-services’.
>
> Change-Id: I8802d4c2337a1e08e3c084d6217f76527d7ee1fb

Like a breathe of fresh air!  LGTM, and the following ones (I did have
some comments requiring your attention for earlier commits, so please
check them out).

I also haven't tested anything hands on, merely reviewed the code by
eye-balling it.

-- 
Thanks,
Maxim