From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: /bin/sh in configure tests
Date: Wed, 16 Jan 2013 15:33:41 +0100
Message-ID: <874nihgptm.fsf@gnu.org>
References: <201301132306.27948.andreas@enge.fr> <877gngram1.fsf@gnu.org>
	<201301161456.47873.andreas@enge.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:40278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TvU3p-0007wu-2S
	for bug-guix@gnu.org; Wed, 16 Jan 2013 09:33:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TvU3n-00017o-36
	for bug-guix@gnu.org; Wed, 16 Jan 2013 09:33:48 -0500
Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:34660)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1TvU3m-00017e-TA
	for bug-guix@gnu.org; Wed, 16 Jan 2013 09:33:47 -0500
In-Reply-To: <201301161456.47873.andreas@enge.fr> (Andreas Enge's message of
	"Wed, 16 Jan 2013 14:56:47 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org

Hello!

Andreas Enge <andreas@enge.fr> skribis:

> Yes, it does! Attached is a patch for a new package. If it is okay, I can=
=20
> push it.

Just minor nitpicking below, but if it builds in a chroot without /bin
or anything, please push!

> +   (inputs `(("perl" ,perl)
> +             ))

Please put closing parentheses at the end of the line.

> +   (arguments
> +    (lambda (system)

Since the =E2=80=98system=E2=80=99 variable isn=E2=80=99t used, you don=E2=
=80=99t need a lambda here.
Instead you can just write:

  (arguments
    `(#:phases ...))

> +             (substitute* "configure"
> +                           (("`/bin/sh")
> +                           (string-append "`" (which "bash"))))

The opening parenthesis on the second line is normally aligned with the
=E2=80=98u=E2=80=99 of =E2=80=98substitute*=E2=80=99.  :-)

Thanks,
Ludo=E2=80=99.