From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add 'guix hash'.
Date: Wed, 03 Apr 2013 10:34:17 +0200
Message-ID: <874nforp12.fsf@gnu.org>
References: <87li92alhe.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:34922)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UNJ9J-0001mG-7f
	for bug-guix@gnu.org; Wed, 03 Apr 2013 04:34:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UNJ9H-0002r4-Sl
	for bug-guix@gnu.org; Wed, 03 Apr 2013 04:34:29 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=42656
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UNJ9H-0002g5-NH
	for bug-guix@gnu.org; Wed, 03 Apr 2013 04:34:27 -0400
In-Reply-To: <87li92alhe.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Mon, 01 Apr 2013 09:06:05 +0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> This patch adds a 'guix hash' command.

Nice!

> I'd like it to output non-Base32 too, but I haven't found a way to
> convert the output of 'sha256', which is a bytevector, to a string.

You mean a hexadecimal string?  There=E2=80=99s bytevector->base16-string in
(guix utils).

> What options would you like to see implemented?

Could you copy/paste the --format option found in (guix scripts download)?

> Should we capitalize error messages?

No (info "(standards) Errors"):

     The string MESSAGE should not begin with a capital letter when it
  follows a program name and/or file name, because that isn't the
  beginning of a sentence.  (The sentence conceptually starts at the
  beginning of the line.)  Also, it should not end with a period.

     Error messages from interactive programs, and other messages such as
  usage messages, should start with a capital letter.  But they should not
  end with a period.

> Is it OK to output a backtrace when the specified file doesn't exist?

No, because it=E2=80=99s too scaring.  :-)

I=E2=80=99m sure there are still places where the guix commands spit out a
backtrace, but we should fix that.

> +  "Return the cryptographic hash of FILE in Base32."

=E2=80=9Cbase32=E2=80=9D (lower-case).

Also, could you add an entry in the manual (with a couple of sentences
explaining when users should care about this tool, and what it does), as
well as a line in po/POTFILES.in?

Thanks,
Ludo=E2=80=99.