From: ludo@gnu.org (Ludovic Courtès)
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] Add 'guix hash'.
Date: Wed, 03 Apr 2013 10:34:17 +0200 [thread overview]
Message-ID: <874nforp12.fsf@gnu.org> (raw)
In-Reply-To: <87li92alhe.fsf@karetnikov.org> (Nikita Karetnikov's message of "Mon, 01 Apr 2013 09:06:05 +0400")
Nikita Karetnikov <nikita@karetnikov.org> skribis:
> This patch adds a 'guix hash' command.
Nice!
> I'd like it to output non-Base32 too, but I haven't found a way to
> convert the output of 'sha256', which is a bytevector, to a string.
You mean a hexadecimal string? There’s bytevector->base16-string in
(guix utils).
> What options would you like to see implemented?
Could you copy/paste the --format option found in (guix scripts download)?
> Should we capitalize error messages?
No (info "(standards) Errors"):
The string MESSAGE should not begin with a capital letter when it
follows a program name and/or file name, because that isn't the
beginning of a sentence. (The sentence conceptually starts at the
beginning of the line.) Also, it should not end with a period.
Error messages from interactive programs, and other messages such as
usage messages, should start with a capital letter. But they should not
end with a period.
> Is it OK to output a backtrace when the specified file doesn't exist?
No, because it’s too scaring. :-)
I’m sure there are still places where the guix commands spit out a
backtrace, but we should fix that.
> + "Return the cryptographic hash of FILE in Base32."
“base32” (lower-case).
Also, could you add an entry in the manual (with a couple of sentences
explaining when users should care about this tool, and what it does), as
well as a line in po/POTFILES.in?
Thanks,
Ludo’.
next prev parent reply other threads:[~2013-04-03 8:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 5:06 [PATCH] Add 'guix hash' Nikita Karetnikov
2013-04-03 8:34 ` Ludovic Courtès [this message]
2013-04-05 14:04 ` Nikita Karetnikov
2013-04-05 14:14 ` Nikita Karetnikov
2013-04-05 16:15 ` Ludovic Courtès
2013-04-10 11:48 ` Nikita Karetnikov
2013-04-10 11:54 ` Ludovic Courtès
2013-04-10 12:21 ` Nikita Karetnikov
2013-04-10 17:30 ` Ludovic Courtès
2013-04-05 16:13 ` Ludovic Courtès
2013-04-09 16:28 ` Nikita Karetnikov
2013-04-11 20:35 ` Ludovic Courtès
2013-04-12 5:24 ` master: FAIL: tests/guix-package.sh (was: [PATCH] Add 'guix hash'.) Nikita Karetnikov
2013-04-12 6:48 ` master: FAIL: tests/guix-package.sh Nikita Karetnikov
2013-04-12 16:24 ` Ludovic Courtès
2013-04-18 5:01 ` Enhanced 'warning' (was: [PATCH] Add 'guix hash'.) Nikita Karetnikov
2013-04-18 5:06 ` Enhanced 'warning' Nikita Karetnikov
2013-04-18 11:55 ` Ludovic Courtès
2013-04-18 19:27 ` Nikita Karetnikov
2013-04-18 20:59 ` Ludovic Courtès
2013-04-19 20:16 ` [PATCH] ui: Add a 'define-diagnostic' macro. (was: Enhanced 'warning') Nikita Karetnikov
2013-04-20 5:48 ` [PATCH] ui: Add a 'define-diagnostic' macro Nikita Karetnikov
2013-04-20 9:10 ` Ludovic Courtès
2013-04-20 17:33 ` Nikita Karetnikov
2013-04-20 19:55 ` Ludovic Courtès
2013-04-20 9:09 ` Ludovic Courtès
2013-04-21 18:14 ` [PATCH] Add 'guix hash' Nikita Karetnikov
2013-04-21 19:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nforp12.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.