all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Bavier <ericbavier@gmail.com>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: Add irrlicht.
Date: Fri, 05 Sep 2014 14:10:42 -0500	[thread overview]
Message-ID: <874mwl3mtp.fsf@gmail.com> (raw)
In-Reply-To: <1409943198-858-2-git-send-email-dthompson2@worcester.edu>


David Thompson writes:

> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (let ((prefix (assoc-ref outputs "out")))

This should probably be named "out" rather than "prefix" for consistency
with the rest of guix's packages.

> +    (description
> +     "3D game engine.")

Perhaps something more descriptive.  Like:

"The Irrlicht Engine is a high performance realtime 3D engine written in
C++.  It is completely cross-platform, using D3D, OpenGL and its own
software renderers, and has all of the state-of-the-art features."

> +    (license bsd-3)))

It's actually the zlib license.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

  reply	other threads:[~2014-09-05 19:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 18:53 [PATCH 1/3] gnu: Add openal David Thompson
2014-09-05 18:53 ` [PATCH 2/3] gnu: Add irrlicht David Thompson
2014-09-05 19:10   ` Eric Bavier [this message]
2014-09-05 19:42     ` David Thompson
2014-09-05 18:53 ` [PATCH 3/3] gnu: Add minetest David Thompson
2014-09-05 20:18   ` Ludovic Courtès
2014-09-06  3:56     ` David Thompson
2014-09-06 10:52       ` Ludovic Courtès
2014-09-06 18:26         ` David Thompson
2014-09-05 20:13 ` [PATCH 1/3] gnu: Add openal Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mwl3mtp.fsf@gmail.com \
    --to=ericbavier@gmail.com \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.