Re: [PATCH 3/3] gnu: Add mupdf

[Alex Kost <alezost@gmail.com>]

Hello, I don't have real comments, I just noticed a couple of typos.

Dušan Xmetov (2014-09-14 13:15 +0400) wrote:

> From bfe5d62ebe379d9d3b5dde812316f7cefe94ddf5 Mon Sep 17 00:00:00 2001
> From: Marek Benc <merkur32@gmail.com>
> Date: Sun, 14 Sep 2014 11:08:10 +0200
> Subject: [PATCH] gnu: Add mupdf
>
> * gnu/packages/pdf.scm (mupdf): New variable.
> * gnu/packages/patches/mupdf-buildsystem-fix.patch: New vile.

New file.

[...]

> +Make use of the above alternatives, compile with gcc.
> +
> +--- a/Makerules	2014-09-14 09:13:40.729149860 +0200
> ++++ b/Makerules	2014-09-14 09:17:06.425156595 +0200
> +@@ -75,12 +75,14 @@
> + 
trailing space.

> + SYS_FREETYPE_CFLAGS = $(shell pkg-config --cflags freetype2)
> + SYS_FREETYPE_LIBS = $(shell pkg-config --libs freetype2)
> +-SYS_OPENJPEG_CFLAGS = $(shell pkg-config --cflags libopenjp2)
> +-SYS_OPENJPEG_LIBS = $(shell pkg-config --libs libopenjp2)
> ++SYS_OPENJPEG_CFLAGS = $(shell ./ojp2_cppflags.sh)
> ++SYS_OPENJPEG_LIBS = $(shell ./ojp2_ldflags.sh)
> + SYS_JBIG2DEC_LIBS = -ljbig2dec
> + SYS_JPEG_LIBS = -ljpeg
> + SYS_ZLIB_LIBS = -lz
> + 
trailing space.

> ++CC = gcc
> ++
> + endif
> + 
trailing space.

> + # The following section is an example of how to simply do cross-compilation
> +
> +Remove the -x11 from the built binaries, since X11 is implied on GNU. (This
> +might change when Wayland gets more popular)
> +
> +--- a/Makefile	2014-06-10 17:09:28.000000000 +0200
> ++++ b/Makefile	2014-09-14 09:57:10.381235299 +0200
> +@@ -255,7 +255,7 @@
> + 	$(LINK_CMD)
> + 
trailing space.

> + ifeq "$(HAVE_X11)" "yes"
> +-MUVIEW_X11 := $(OUT)/mupdf-x11
> ++MUVIEW_X11 := $(OUT)/mupdf
> + MUVIEW_X11_OBJ := $(addprefix $(OUT)/platform/x11/, x11_main.o x11_image.o pdfapp.o)
> + $(MUVIEW_X11_OBJ) : $(FITZ_HDR) $(PDF_HDR)
> + $(MUVIEW_X11) : $(MUPDF_LIB) $(THIRD_LIBS)
> +@@ -263,7 +263,7 @@
> + 	$(LINK_CMD) $(X11_LIBS)
> + 
trailing space.

[...]

> +    (inputs
> +      `(("curl" ,curl)
> +        ("freetype", freetype)

("freetype" ,freetype)

[...]

> +    (synopsis "A lightweight PDF viewer and toolkit.")
> +    (description
> +      "MuPDF is a C library that implements a PDF and XPS parsing and rendering
> +engine. It is used primarily to render pages into bitmaps, but also provides
> +support for other operations such as searching and listing the table of
> +contents and hyperlinks.
> +
> +The library ships with a rudimentary X11 viewer, and a set of command line tools
> +for batch rendering (pdfdraw), examining the file structure (pdfshow), and
> +rewriting files (pdfclean).")
> +    (license license:agpl3+)))

I think people usually avoid a period in a synopsis and use a double
space after a period in a description.  Also the description should be
wrapped by 72 (or 78?) characters in a line.