From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] emacs: Add 'pretty-sha-path'. Date: Wed, 05 Nov 2014 21:12:08 +0100 Message-ID: <874mud4dbb.fsf@gnu.org> References: <87d2926he1.fsf@gmail.com> <87h9ye8x6d.fsf@gnu.org> <87d291uby6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm6wE-0000Bx-65 for guix-devel@gnu.org; Wed, 05 Nov 2014 15:12:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm6w7-00022u-AT for guix-devel@gnu.org; Wed, 05 Nov 2014 15:12:18 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:48185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm6w7-000227-3b for guix-devel@gnu.org; Wed, 05 Nov 2014 15:12:11 -0500 In-Reply-To: <87d291uby6.fsf@gmail.com> (Alex Kost's message of "Wed, 05 Nov 2014 14:24:49 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Ludovic Court=C3=A8s (2014-11-05 00:37 +0300) wrote: > >> Alex Kost skribis: >> >>> Also I forgot to mention =E2=80=9Cemacs/guix-messages.el=E2=80=9D in = =E2=80=9Cemacs.am=E2=80=9D in >>> commit 62f261d, so I did it in this patch (I hope it's not too evil :-)) >> >> Maybe =E2=80=9Cevil=E2=80=9D is too strong a word ;-), but please keep t= he >> emacs/guix-messages.el addition in a separate commit. >> >> Commits are cheap and easy, so let=E2=80=99s favor clarity. > > Yes, cheap, I know, but not very easy for me as I never sure what to > write in a commit message and I have to ask guix-devel even about such > trivial changes (the patch is attached :-)). Per =E2=80=98HACKING=E2=80=99 ;-), you don=E2=80=99t *have* to ask for triv= ial changes. It=E2=80=99s nice of you to do it, but you don=E2=80=99t have to. IMO it=E2=80=99s time to formalize maintainership and responsibilities, as = I had proposed a while back. I=E2=80=99ll get back to it. > So I'm going to add =E2=80=98global-pretty-sha-path-mode=E2=80=99 and men= tion it in the > documentation, but I also leave =E2=80=98pretty-sha-path-global-mode=E2= =80=99 just in > case (I'll make it an alias). Sounds good. > I've realized that "pretty-sha-path" is a bad name, because those 32 > numbers and letters have nothing to do with SHA-sequences as I thought > initially. So maybe it would be better to rename it into > "pretty-hash-path" or "guix-pretty-path" (as it will be a part of Guix) > or something else. Or is it OK to leave it as it is? Good point. Prefixing with =E2=80=98guix-=E2=80=99 makes sense, and it wil= l be easier for users to find it. While we=E2=80=99re at it, =E2=80=9Cpath=E2=80=9D in GNU normally means =E2= =80=9Csearch path=E2=80=9D, not =E2=80=9Cfile name=E2=80=9D (info "(standards) GNU Manuals"), so perhaps =E2=80=98guix-pretty-file-names=E2=80=99 or something like that would be ev= en better. WDYT? (Yes, (guix store) still uses the =E2=80=9Cstore path=E2=80=9D terminology = inherited from Nix.) > From 4648af5bab6a9e98cc4c725b8fcca159874d4380 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Wed, 5 Nov 2014 14:00:05 +0300 > Subject: [PATCH] build: Add missing "emacs/guix-messages.el". > > * emacs.am (ELFILES): Add "emacs/guix-messages.el". OK for this one, of course. :-) Ludo=E2=80=99.